Re: Review Request 62186: Implement host recovery - backend changes

2017-09-08 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/#review184994
---


Ship it!




Ship It!

- Robert Levas


On Sept. 8, 2017, 2:34 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62186/
> ---
> 
> (Updated Sept. 8, 2017, 2:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21868
> https://issues.apache.org/jira/browse/AMBARI-21868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  8933dd3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  96280ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  a7b9d80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  bb360b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  013a063 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  d6b8ffc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  a23ab5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  2fd5abe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  81e345a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  f55c6f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  4e63f4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  e13f033 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  00c82a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  697f1d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  b4ff5c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  95e5513 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileTest.java
>  323ba8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
>  f63e6b8 
> 
> 
> Diff: https://reviews.apache.org/r/62186/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean test; cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62186: Implement host recovery - backend changes

2017-09-08 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/
---

(Updated Sept. 8, 2017, 6:34 p.m.)


Review request for Ambari, Dmytro Sen, Robert Levas, and Sid Wagle.


Bugs: AMBARI-21868
https://issues.apache.org/jira/browse/AMBARI-21868


Repository: ambari


Description
---

see jira


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 8933dd3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 96280ea 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 a7b9d80 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 bb360b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 013a063 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 d6b8ffc 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 a23ab5d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 2fd5abe 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
 81e345a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
 f55c6f4 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 4e63f4a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 e13f033 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 00c82a5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 697f1d1 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 b4ff5c1 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
 95e5513 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileTest.java
 323ba8e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
 f63e6b8 


Diff: https://reviews.apache.org/r/62186/diff/3/

Changes: https://reviews.apache.org/r/62186/diff/2-3/


Testing
---

mvn clean test; cluster deploy


Thanks,

Eugene Chekanskiy

Re: Review Request 62186: Implement host recovery - backend changes

2017-09-08 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/#review184991
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
Line 220 (original), 220 (patched)


It does not seem like you needed to move this line



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
Lines 132-133 (patched)


Maybe simplify to

```
boolean onlyWrite = 
"true".equalsIgnoreCase(identityRecord.get(KerberosIdentityDataFileReader.ONLY_KEYTAB_WRITE));
```



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
Lines 132-135 (original), 132-137 (patched)


Simplify to

```
  if (regenerateKeytabs) {
processPrincipal = 
!"true".equalsIgnoreCase(identityRecord.get(KerberosIdentityDataFileReader.ONLY_KEYTAB_WRITE));
  } else {
```


- Robert Levas


On Sept. 8, 2017, 12:17 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62186/
> ---
> 
> (Updated Sept. 8, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21868
> https://issues.apache.org/jira/browse/AMBARI-21868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  8933dd3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  96280ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  a7b9d80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  bb360b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  013a063 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  d6b8ffc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  a23ab5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  2fd5abe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  81e345a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  f55c6f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  4e63f4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  e13f033 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  00c82a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  697f1d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  b4ff5c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  95e5513 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileTest.java
>  323ba8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
>  f63e6b8 
> 
> 
> Diff: https://reviews.apache.org/r/62186/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test; cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62186: Implement host recovery - backend changes

2017-09-08 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/#review184988
---


Ship it!




Ship It!

- Sid Wagle


On Sept. 8, 2017, 4:17 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62186/
> ---
> 
> (Updated Sept. 8, 2017, 4:17 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21868
> https://issues.apache.org/jira/browse/AMBARI-21868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  8933dd3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  96280ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  a7b9d80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  bb360b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  013a063 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  d6b8ffc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  a23ab5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  2fd5abe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
>  81e345a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
>  f55c6f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
>  4e63f4a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
>  e13f033 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
>  00c82a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  697f1d1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  b4ff5c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  95e5513 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileTest.java
>  323ba8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
>  f63e6b8 
> 
> 
> Diff: https://reviews.apache.org/r/62186/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test; cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62186: Implement host recovery - backend changes

2017-09-08 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/
---

(Updated Sept. 8, 2017, 4:17 p.m.)


Review request for Ambari, Dmytro Sen, Robert Levas, and Sid Wagle.


Bugs: AMBARI-21868
https://issues.apache.org/jira/browse/AMBARI-21868


Repository: ambari


Description
---

see jira


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 8933dd3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 96280ea 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 a7b9d80 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 bb360b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 013a063 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 d6b8ffc 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 a23ab5d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 2fd5abe 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
 81e345a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
 f55c6f4 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 4e63f4a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 e13f033 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 00c82a5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 697f1d1 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 b4ff5c1 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
 95e5513 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileTest.java
 323ba8e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
 f63e6b8 


Diff: https://reviews.apache.org/r/62186/diff/2/

Changes: https://reviews.apache.org/r/62186/diff/1-2/


Testing
---

mvn clean test; cluster deploy


Thanks,

Eugene Chekanskiy

Review Request 62186: Implement host recovery - backend changes

2017-09-08 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/
---

Review request for Ambari, Dmytro Sen, Robert Levas, and Sid Wagle.


Bugs: AMBARI-21868
https://issues.apache.org/jira/browse/AMBARI-21868


Repository: ambari


Description
---

see jira


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
 8933dd3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 96280ea 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 a7b9d80 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 bb360b5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 013a063 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 d6b8ffc 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 a23ab5d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 2fd5abe 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFile.java
 81e345a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileWriter.java
 f55c6f4 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
 4e63f4a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
 e13f033 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
 00c82a5 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 697f1d1 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 b4ff5c1 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
 95e5513 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosIdentityDataFileTest.java
 323ba8e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
 f63e6b8 


Diff: https://reviews.apache.org/r/62186/diff/1/


Testing
---

mvn clean test; cluster deploy


Thanks,

Eugene Chekanskiy