Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185419
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 14, 2017, 11:13 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 11:13 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>



Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185415
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 14, 2017, 3:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>



Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Dmytro Grinenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185412
---


Ship it!




Ship It!

- Dmytro Grinenko


On Sept. 14, 2017, 3:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>



Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/
---

Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.


Bugs: AMBARI-21690
https://issues.apache.org/jira/browse/AMBARI-21690


Repository: ambari


Description
---

Remove repository_version and repository_version_id null checks for BP 
deployments since we want to use the default if-not-specified.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 092339bb7a 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 8d891b9534 


Diff: https://reviews.apache.org/r/62331/diff/1/


Testing
---

Manual cluster deployment.  Automated pending.


Thanks,

Nate Cole