Re: Review Request 62356: Log Feeder should not support german month names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62356/#review185486 --- Ship it! Ship It! - Robert Nettleton On Sept. 15, 2017, 1:27 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62356/ > --- > > (Updated Sept. 15, 2017, 1:27 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21968 > https://issues.apache.org/jira/browse/AMBARI-21968 > > > Repository: ambari > > > Description > --- > > Log Feeder grok patterns currently support german month names too. This has > almost no usefulness at all, as there are no german language logs, and we > don't even support german day names, but it may cause errors as the März > contains a ä character which may lead to encoding related errors. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns > 920f521 > > > Diff: https://reviews.apache.org/r/62356/diff/1/ > > > Testing > --- > > Done. > > > Thanks, > > Miklos Gergely > >
Re: Review Request 62356: Log Feeder should not support german month names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62356/#review185482 --- Ship it! Ship It! - Oliver Szabo On Sept. 15, 2017, 1:27 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62356/ > --- > > (Updated Sept. 15, 2017, 1:27 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21968 > https://issues.apache.org/jira/browse/AMBARI-21968 > > > Repository: ambari > > > Description > --- > > Log Feeder grok patterns currently support german month names too. This has > almost no usefulness at all, as there are no german language logs, and we > don't even support german day names, but it may cause errors as the März > contains a ä character which may lead to encoding related errors. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns > 920f521 > > > Diff: https://reviews.apache.org/r/62356/diff/1/ > > > Testing > --- > > Done. > > > Thanks, > > Miklos Gergely > >
Review Request 62356: Log Feeder should not support german month names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62356/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-21968 https://issues.apache.org/jira/browse/AMBARI-21968 Repository: ambari Description --- Log Feeder grok patterns currently support german month names too. This has almost no usefulness at all, as there are no german language logs, and we don't even support german day names, but it may cause errors as the März contains a ä character which may lead to encoding related errors. Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns 920f521 Diff: https://reviews.apache.org/r/62356/diff/1/ Testing --- Done. Thanks, Miklos Gergely
