Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Levas


> On Sept. 19, 2017, 12:58 p.m., Jonathan Hurley wrote:
> > The Jira is marked for 2.6 and trunk - should you only put this fix into 
> > branch-2.6? Trunk is JDK 8 compatible...

The previous depencency was version 0.1.7, which was older than the one in this 
patch, 0.1.10. I should have gone with the newer one anyways.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185711
---


On Sept. 19, 2017, 11:54 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185711
---


Ship it!




The Jira is marked for 2.6 and trunk - should you only put this fix into 
branch-2.6? Trunk is JDK 8 compatible...

- Jonathan Hurley


On Sept. 19, 2017, 11:54 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185708
---


Ship it!




Ship It!

- Nate Cole


On Sept. 19, 2017, 11:54 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185702
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 19, 2017, 3:54 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 3:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>



Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21997
https://issues.apache.org/jira/browse/AMBARI-21997


Repository: ambari


Description
---

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
project ambari-server: Execution default-test of goal 
org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
Unsupported major.minor version 52.0 -> [Help 1]
```

#Cause#
com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
unit tests to fail when using Java 1.7

#Solution#
Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
using either Java 1.7 or Java 1.8.


Diffs
-

  ambari-server/pom.xml 4a896ad261 


Diff: https://reviews.apache.org/r/62412/diff/1/


Testing
---

Ran unit tests using Java7 and Java8


Thanks,

Robert Levas