Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-27 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62586/#review186384
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 26, 2017, 10:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62586/
> ---
> 
> (Updated Sept. 26, 2017, 10:12 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22066
> https://issues.apache.org/jira/browse/AMBARI-22066
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update unit tests to test recursive variable replacements using 
> VariableReplacementHelper. For example:
> 
> ```
> ${service-site/suffix_value_${host}}
> ```
> 
> `${host}` needs to be replaced and then the resulting value needs to be 
> replaced to generate the relevant value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  e46294a5b6 
> 
> 
> Diff: https://reviews.apache.org/r/62586/diff/1/
> 
> 
> Testing
> ---
> 
> ---
> Test set: 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> ---
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.438 s - in 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-26 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62586/#review186340
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 26, 2017, 4:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62586/
> ---
> 
> (Updated Sept. 26, 2017, 4:12 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22066
> https://issues.apache.org/jira/browse/AMBARI-22066
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update unit tests to test recursive variable replacements using 
> VariableReplacementHelper. For example:
> 
> ```
> ${service-site/suffix_value_${host}}
> ```
> 
> `${host}` needs to be replaced and then the resulting value needs to be 
> replaced to generate the relevant value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  e46294a5b6 
> 
> 
> Diff: https://reviews.apache.org/r/62586/diff/1/
> 
> 
> Testing
> ---
> 
> ---
> Test set: 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> ---
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.438 s - in 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-26 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62586/#review186322
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 26, 2017, 8:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62586/
> ---
> 
> (Updated Sept. 26, 2017, 8:12 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22066
> https://issues.apache.org/jira/browse/AMBARI-22066
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update unit tests to test recursive variable replacements using 
> VariableReplacementHelper. For example:
> 
> ```
> ${service-site/suffix_value_${host}}
> ```
> 
> `${host}` needs to be replaced and then the resulting value needs to be 
> replaced to generate the relevant value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  e46294a5b6 
> 
> 
> Diff: https://reviews.apache.org/r/62586/diff/1/
> 
> 
> Testing
> ---
> 
> ---
> Test set: 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> ---
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.438 s - in 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-26 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62586/
---

(Updated Sept. 26, 2017, 4:12 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-22066
https://issues.apache.org/jira/browse/AMBARI-22066


Repository: ambari


Description
---

Update unit tests to test recursive variable replacements using 
VariableReplacementHelper. For example:

```
${service-site/suffix_value_${host}}
```

`${host}` needs to be replaced and then the resulting value needs to be 
replaced to generate the relevant value.


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
 e46294a5b6 


Diff: https://reviews.apache.org/r/62586/diff/1/


Testing (updated)
---

---
Test set: org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
---
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.438 s - in 
org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest


Thanks,

Robert Levas

Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-26 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62586/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-22066
https://issues.apache.org/jira/browse/AMBARI-22066


Repository: ambari


Description
---

Update unit tests to test recursive variable replacements using 
VariableReplacementHelper. For example:

```
${service-site/suffix_value_${host}}
```

`${host}` needs to be replaced and then the resulting value needs to be 
replaced to generate the relevant value.


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
 e46294a5b6 


Diff: https://reviews.apache.org/r/62586/diff/1/


Testing
---

In progress


Thanks,

Robert Levas