Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-10-02 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186854
---


Ship it!




Ship It!

- Jayush Luniya


On Sept. 30, 2017, 5:31 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 30, 2017, 5:31 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/3/
> 
> 
> Testing
> ---
> 
> Ambari-2.6
> HDP-2.6.0.0
> Deploy Hive
> Deploy Oozie
> 
> [root@storm-simple-patch-madhu-2 conf]# pwd
> /var/lib/ambari-agent/cred/conf
> [root@storm-simple-patch-madhu-2 conf]# ls
> hive_metastore  hive_server  mysql_server  oozie_client  oozie_server
> 
> Run service checks
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/
---

(Updated Sept. 30, 2017, 5:31 a.m.)


Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Changes
---

Review comment


Bugs: AMBARI-22100
https://issues.apache.org/jira/browse/AMBARI-22100


Repository: ambari


Description
---

Change temp directory for jceks file from service level to component level.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8a433c83f4 


Diff: https://reviews.apache.org/r/62699/diff/3/

Changes: https://reviews.apache.org/r/62699/diff/2-3/


Testing
---

Ambari-2.6
HDP-2.6.0.0
Deploy Hive
Deploy Oozie

[root@storm-simple-patch-madhu-2 conf]# pwd
/var/lib/ambari-agent/cred/conf
[root@storm-simple-patch-madhu-2 conf]# ls
hive_metastore  hive_server  mysql_server  oozie_client  oozie_server

Run service checks


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186778
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Lines 284 (patched)


Need to check if 'role' is in commandJson first.

if 'role' in commandJson:
  roleName = commandJson['role']
  file_path = os.path.join(self.getProviderDirectory(roleName), 
"{0}.jceks".format(config_type))


- Jayush Luniya


On Sept. 30, 2017, 5:03 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 30, 2017, 5:03 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/2/
> 
> 
> Testing
> ---
> 
> Ambari-2.6
> HDP-2.6.0.0
> Deploy Hive
> Deploy Oozie
> 
> [root@storm-simple-patch-madhu-2 conf]# pwd
> /var/lib/ambari-agent/cred/conf
> [root@storm-simple-patch-madhu-2 conf]# ls
> hive_metastore  hive_server  mysql_server  oozie_client  oozie_server
> 
> Run service checks
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/
---

(Updated Sept. 30, 2017, 5:03 a.m.)


Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Changes
---

Review comments


Bugs: AMBARI-22100
https://issues.apache.org/jira/browse/AMBARI-22100


Repository: ambari


Description
---

Change temp directory for jceks file from service level to component level.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8a433c83f4 


Diff: https://reviews.apache.org/r/62699/diff/2/

Changes: https://reviews.apache.org/r/62699/diff/1-2/


Testing (updated)
---

Ambari-2.6
HDP-2.6.0.0
Deploy Hive
Deploy Oozie

[root@storm-simple-patch-madhu-2 conf]# pwd
/var/lib/ambari-agent/cred/conf
[root@storm-simple-patch-madhu-2 conf]# ls
hive_metastore  hive_server  mysql_server  oozie_client  oozie_server

Run service checks


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186753
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Line 284 (original), 284 (patched)


Will role ever be null? I am thinking about service checks etc. Might want 
to add service_name as fall back just in case.


- Jayush Luniya


On Sept. 29, 2017, 10:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 29, 2017, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/#review186751
---


Ship it!




Ship It!

- Swapan Shridhar


On Sept. 29, 2017, 10:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62699/
> ---
> 
> (Updated Sept. 29, 2017, 10:14 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22100
> https://issues.apache.org/jira/browse/AMBARI-22100
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change temp directory for jceks file from service level to component level.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 8a433c83f4 
> 
> 
> Diff: https://reviews.apache.org/r/62699/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62699/
---

Review request for Ambari, Jayush Luniya and Swapan Shridhar.


Bugs: AMBARI-22100
https://issues.apache.org/jira/browse/AMBARI-22100


Repository: ambari


Description
---

Change temp directory for jceks file from service level to component level.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8a433c83f4 


Diff: https://reviews.apache.org/r/62699/diff/1/


Testing
---


Thanks,

Madhuvanthi Radhakrishnan