Re: Review Request 62750: Cache becomes corrupt

2017-10-03 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62750/#review186949
---


Ship it!




Ship It!

- Attila Doroszlai


On Oct. 3, 2017, 3:35 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62750/
> ---
> 
> (Updated Oct. 3, 2017, 3:35 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22119
> https://issues.apache.org/jira/browse/AMBARI-22119
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Agent topology file cache became corrupt after writing of topology to it. It
> contained some gibberish. I think it might be a rare simplejson bug. The file
> was not trimmed correctly, during rewritting.
> 
> This happened only once on perf cluster. But worth a preventive fix.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterCache.py 40b32886cf 
> 
> 
> Diff: https://reviews.apache.org/r/62750/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 62750: Cache becomes corrupt

2017-10-03 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62750/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22119
https://issues.apache.org/jira/browse/AMBARI-22119


Repository: ambari


Description
---

Agent topology file cache became corrupt after writing of topology to it. It
contained some gibberish. I think it might be a rare simplejson bug. The file
was not trimmed correctly, during rewritting.

This happened only once on perf cluster. But worth a preventive fix.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ClusterCache.py 40b32886cf 


Diff: https://reviews.apache.org/r/62750/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk