Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187096
---


Ship it!




Ship It!

- Nate Cole


On Oct. 4, 2017, 9:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 4, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 395687da23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Robert Levas 


> On Oct. 3, 2017, 7:57 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 2775-2780 (patched)
> > 
> >
> > Can you also generate the new markdown file and include it in this 
> > patch?

I always forget to do this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187029
---


On Oct. 4, 2017, 9:19 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 4, 2017, 9:19 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 395687da23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/
---

(Updated Oct. 4, 2017, 9:19 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian 
Toader.


Changes
---

Regenerated the configiration index.md file.


Bugs: AMBARI-21220
https://issues.apache.org/jira/browse/AMBARI-21220


Repository: ambari


Description
---

Update Local Authentication process to work with improved user management 
facility


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 395687da23 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 3099bc0857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 21ab757e1c 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
 2a894374d1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
 2a2e397439 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 2dedc9e6ca 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 fea7fb978e 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 fb4ebf93e4 


Diff: https://reviews.apache.org/r/62757/diff/2/

Changes: https://reviews.apache.org/r/62757/diff/1-2/


Testing
---

Manually tested

Local test results: PASSED


Thanks,

Robert Levas

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187069
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 3, 2017, 10:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 10:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-03 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187029
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 2775-2780 (patched)


Can you also generate the new markdown file and include it in this patch?


- Jonathan Hurley


On Oct. 3, 2017, 4:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 4:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-03 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187004
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 3, 2017, 8:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 8:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-03 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review186998
---




ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
Lines 43 (patched)


This was renamed from AmbariLocalUserProvider to be more consisten with 
other authentication providers.

It was also moved from `org.apache.ambari.server.security.authorization` to 
`org.apache.ambari.server.security.authentication`



ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
Lines 40 (patched)


This was renamed from `AmbariLocalUserProviderTest`.

The generic authentication provider tests were moved to 
`AbstractAuthenticationProviderTes` to provide a way to test all relevant 
authentication providers so that they behave in a similar way.


- Robert Levas


On Oct. 3, 2017, 4:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 4:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-03 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and Sebastian 
Toader.


Bugs: AMBARI-21220
https://issues.apache.org/jira/browse/AMBARI-21220


Repository: ambari


Description
---

Update Local Authentication process to work with improved user management 
facility


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 3099bc0857 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 21ab757e1c 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
 2a894374d1 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
 2a2e397439 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 2dedc9e6ca 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
 fea7fb978e 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
 fb4ebf93e4 


Diff: https://reviews.apache.org/r/62757/diff/1/


Testing
---

Manually tested

Local test results: PASSED


Thanks,

Robert Levas