Re: Review Request 62848: Not able to perform revert after deleting the upgraded service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62848/#review187509 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 9, 2017, 10:06 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62848/ > --- > > (Updated Oct. 9, 2017, 10:06 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-22166 > https://issues.apache.org/jira/browse/AMBARI-22166 > > > Repository: ambari > > > Description > --- > > After deleting a service, you can't revert a PATCH or MAINT upgrade. This is > because we iterate over all prior services when creating the upgrade context > for the reversion. > > STR: > - Install ZK, HDFS, and Storm > - Upgrade ZK and Storm using a PATCH or MAINT VDF > - Remove Storm > - Revert the prior patch > > ``` > 09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] > AbstractResourceProvider:285 - Caught AmbariException when creating a resource > org.apache.ambari.server.ServiceNotFoundException: Service not found, > clusterName=cl1, serviceName=ATLAS > at > org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863) > at > org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403) > at > org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance() > at > com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40) > at > com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60) > at > com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85) > at > com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254) > at > com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978) > at > com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024) > at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974) > at > com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632) > at com.sun.proxy.$Proxy31.create(Unknown Source) > ``` > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 9f31ab8a62 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java > 5cf9a4c859 > > > Diff: https://reviews.apache.org/r/62848/diff/2/ > > > Testing > --- > > Manual reversion of a PATCH after removing a service. > > [INFO] Results: > [INFO] > [WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34 > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 62848: Not able to perform revert after deleting the upgraded service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62848/#review187444 --- Ship it! Ship It! - Nate Cole On Oct. 9, 2017, 3:06 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62848/ > --- > > (Updated Oct. 9, 2017, 3:06 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-22166 > https://issues.apache.org/jira/browse/AMBARI-22166 > > > Repository: ambari > > > Description > --- > > After deleting a service, you can't revert a PATCH or MAINT upgrade. This is > because we iterate over all prior services when creating the upgrade context > for the reversion. > > STR: > - Install ZK, HDFS, and Storm > - Upgrade ZK and Storm using a PATCH or MAINT VDF > - Remove Storm > - Revert the prior patch > > ``` > 09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] > AbstractResourceProvider:285 - Caught AmbariException when creating a resource > org.apache.ambari.server.ServiceNotFoundException: Service not found, > clusterName=cl1, serviceName=ATLAS > at > org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863) > at > org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403) > at > org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance() > at > com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40) > at > com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60) > at > com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85) > at > com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254) > at > com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978) > at > com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024) > at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974) > at > com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632) > at com.sun.proxy.$Proxy31.create(Unknown Source) > ``` > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 9f31ab8a62 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java > 5cf9a4c859 > > > Diff: https://reviews.apache.org/r/62848/diff/2/ > > > Testing > --- > > Manual reversion of a PATCH after removing a service. > > [INFO] Results: > [INFO] > [WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34 > > > Thanks, > > Jonathan Hurley > >
Re: Review Request 62848: Not able to perform revert after deleting the upgraded service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62848/ --- (Updated Oct. 9, 2017, 3:06 p.m.) Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. Bugs: AMBARI-22166 https://issues.apache.org/jira/browse/AMBARI-22166 Repository: ambari Description --- After deleting a service, you can't revert a PATCH or MAINT upgrade. This is because we iterate over all prior services when creating the upgrade context for the reversion. STR: - Install ZK, HDFS, and Storm - Upgrade ZK and Storm using a PATCH or MAINT VDF - Remove Storm - Revert the prior patch ``` 09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] AbstractResourceProvider:285 - Caught AmbariException when creating a resource org.apache.ambari.server.ServiceNotFoundException: Service not found, clusterName=cl1, serviceName=ATLAS at org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863) at org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403) at org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance() at com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40) at com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60) at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85) at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254) at com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978) at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024) at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974) at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632) at com.sun.proxy.$Proxy31.create(Unknown Source) ``` Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 9f31ab8a62 ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java 5cf9a4c859 Diff: https://reviews.apache.org/r/62848/diff/2/ Changes: https://reviews.apache.org/r/62848/diff/1-2/ Testing (updated) --- Manual reversion of a PATCH after removing a service. [INFO] Results: [INFO] [WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34 Thanks, Jonathan Hurley
Review Request 62848: Not able to perform revert after deleting the upgraded service
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62848/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. Bugs: AMBARI-22166 https://issues.apache.org/jira/browse/AMBARI-22166 Repository: ambari Description --- After deleting a service, you can't revert a PATCH or MAINT upgrade. This is because we iterate over all prior services when creating the upgrade context for the reversion. STR: - Install ZK, HDFS, and Storm - Upgrade ZK and Storm using a PATCH or MAINT VDF - Remove Storm - Revert the prior patch ``` 09 Oct 2017 10:02:59,142 ERROR [ambari-client-thread-22258] AbstractResourceProvider:285 - Caught AmbariException when creating a resource org.apache.ambari.server.ServiceNotFoundException: Service not found, clusterName=cl1, serviceName=ATLAS at org.apache.ambari.server.state.cluster.ClusterImpl.getService(ClusterImpl.java:863) at org.apache.ambari.server.state.UpgradeContext.(UpgradeContext.java:403) at org.apache.ambari.server.state.UpgradeContext$$FastClassByGuice$$6e2e5fe5.newInstance() at com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40) at com.google.inject.internal.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:60) at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85) at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254) at com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978) at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024) at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974) at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632) at com.sun.proxy.$Proxy31.create(Unknown Source) ``` Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 9f31ab8a62 Diff: https://reviews.apache.org/r/62848/diff/1/ Testing --- Manual reversion of a PATCH after removing a service. Unit Tests Pending... Thanks, Jonathan Hurley
