Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review192003
---



I have not uploaded fix for trunk as this file is not present in trunk code. 
This file is specific to BigInsights stack which is present in ambari 
branch-2.6. Hence added patch only for branch-2.6.

- Piyush Chavhan


On Oct. 30, 2017, 3:07 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 30, 2017, 3:07 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/2/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> Run UTs on CentOS release 6.9 with Python 2.6.6
> Observed only one test failure (with and without code changes) which is known 
> issue: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Python Test Results:
> Total run:1193
> Total errors:1
> Total failures:1
> FAIL: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Java Test Results:
> Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

> On Oct. 30, 2017, 3:32 p.m., Jonathan Hurley wrote:
> > Ship It!

Thanks.


- Piyush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review189596
---


On Oct. 30, 2017, 3:07 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 30, 2017, 3:07 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/2/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> Run UTs on CentOS release 6.9 with Python 2.6.6
> Observed only one test failure (with and without code changes) which is known 
> issue: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Python Test Results:
> Total run:1193
> Total errors:1
> Total failures:1
> FAIL: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Java Test Results:
> Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

> On Oct. 30, 2017, 3:01 p.m., Sebastian Toader wrote:
> > Ship It!

Thanks.


- Piyush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review189587
---


On Oct. 30, 2017, 3:07 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 30, 2017, 3:07 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/2/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> Run UTs on CentOS release 6.9 with Python 2.6.6
> Observed only one test failure (with and without code changes) which is known 
> issue: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Python Test Results:
> Total run:1193
> Total errors:1
> Total failures:1
> FAIL: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Java Test Results:
> Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review189587
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 30, 2017, 1:39 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 30, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/2/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> Run UTs on CentOS release 6.9 with Python 2.6.6
> Observed only one test failure (with and without code changes) which is known 
> issue: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Python Test Results:
> Total run:1193
> Total errors:1
> Total failures:1
> FAIL: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)
> 
> Java Test Results:
> Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/
---

(Updated Oct. 24, 2017, 2:49 p.m.)


Review request for Ambari.


Bugs: AMBARI-22187
https://issues.apache.org/jira/browse/AMBARI-22187


Repository: ambari


Description
---

If ambari-server and ambari-agents running using non-root user and tried to 
upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to "get 
safemode state" fails for NameNode


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
 5969fcf 


Diff: https://reviews.apache.org/r/62930/diff/2/


Testing (updated)
---

Tested this change on the running cluster by performing express upgrade from 
BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on the 
cluster.

Run UTs on CentOS release 6.9 with Python 2.6.6
Observed only one test failure (with and without code changes) which is known 
issue: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)

Python Test Results:
Total run:1193
Total errors:1
Total failures:1
FAIL: test_symlink_conversion_to_current (test_conf_select.TestConfSelect)

Java Test Results:
Tests run: 4921, Failures: 0, Errors: 0, Skipped: 34


Thanks,

Piyush Chavhan

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

> On Oct. 17, 2017, 10:56 a.m., Attila Doroszlai wrote:
> >

Hi Attila,

Thanks for reviewing this issue. I have incorporated the below mentioned two 
review comments.


- Piyush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review188291
---


On Oct. 17, 2017, 1:50 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 17, 2017, 1:50 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/2/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> UTs are still running for this.
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/
---

(Updated Oct. 17, 2017, 1:50 p.m.)


Review request for Ambari.


Bugs: AMBARI-22187
https://issues.apache.org/jira/browse/AMBARI-22187


Repository: ambari


Description
---

If ambari-server and ambari-agents running using non-root user and tried to 
upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to "get 
safemode state" fails for NameNode


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
 5969fcf 


Diff: https://reviews.apache.org/r/62930/diff/2/

Changes: https://reviews.apache.org/r/62930/diff/1-2/


Testing
---

Tested this change on the running cluster by performing express upgrade from 
BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on the 
cluster.

UTs are still running for this.


Thanks,

Piyush Chavhan

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review188291
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
Line 174 (original), 174 (patched)


Please use `{safemode_check}` for the first part of the command instead of 
repeating the contents.



ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
Line 175 (original), 175 (patched)


Need to pass `user=user` to the `call` function for the command to be run 
as the HDFS user.


- Attila Doroszlai


On Oct. 12, 2017, 4:22 p.m., Piyush Chavhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> ---
> 
> (Updated Oct. 12, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-22187
> https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/1/
> 
> 
> Testing
> ---
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> UTs are still running for this.
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/
---

Review request for Ambari.


Bugs: AMBARI-22187
https://issues.apache.org/jira/browse/AMBARI-22187


Repository: ambari


Description
---

If ambari-server and ambari-agents running using non-root user and tried to 
upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to "get 
safemode state" fails for NameNode


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
 5969fcf 


Diff: https://reviews.apache.org/r/62930/diff/1/


Testing
---

Tested this change on the running cluster by performing express upgrade from 
BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on the 
cluster.

UTs are still running for this.


Thanks,

Piyush Chavhan