Re: Review Request 62998: In case only Hive Server Interactive is deployed with no Hive Server in the cluster the hive metastore warehouse directory is not created on DFS.

2017-10-14 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62998/#review188073
---


Ship it!




Ship It!

- Attila Doroszlai


On Oct. 14, 2017, 8:05 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62998/
> ---
> 
> (Updated Oct. 14, 2017, 8:05 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22243
> https://issues.apache.org/jira/browse/AMBARI-22243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ware house directory creation logic was part only of HiveServer scripts. 
> The same logic had to be added to HiveServer Interactive scripts in order to 
> ensure that the warehouse directory is created if solely HiveServer 
> Interactive is deployed to the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 3dc78ab 
> 
> 
> Diff: https://reviews.apache.org/r/62998/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing using Blueprints (currently only with Blueprints it's possible 
> to deploy HiveServer Interactive with no HiveServer in the cluster)
> 
> 
> Unit tests:
> *mvn test  -DskipSurefireTests -am -pl ambari-server*
> 
> ```
> Total run:1204
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.473 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.003 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.727 
> s]
> [INFO] ambari-utility . SUCCESS [  2.642 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.185 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  0.351 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.374 
> s]
> [INFO] Ambari Server .. SUCCESS [01:32 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>



Re: Review Request 62998: In case only Hive Server Interactive is deployed with no Hive Server in the cluster the hive metastore warehouse directory is not created on DFS.

2017-10-14 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62998/#review188072
---


Ship it!




Ship It!

- Robert Levas


On Oct. 14, 2017, 2:05 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62998/
> ---
> 
> (Updated Oct. 14, 2017, 2:05 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
> Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22243
> https://issues.apache.org/jira/browse/AMBARI-22243
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ware house directory creation logic was part only of HiveServer scripts. 
> The same logic had to be added to HiveServer Interactive scripts in order to 
> ensure that the warehouse directory is created if solely HiveServer 
> Interactive is deployed to the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
>  2ed3e3a 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 3dc78ab 
> 
> 
> Diff: https://reviews.apache.org/r/62998/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing using Blueprints (currently only with Blueprints it's possible 
> to deploy HiveServer Interactive with no HiveServer in the cluster)
> 
> 
> Unit tests:
> *mvn test  -DskipSurefireTests -am -pl ambari-server*
> 
> ```
> Total run:1204
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
> [INFO] Starting audit...
> Audit done.
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [  0.473 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.003 
> s]
> [INFO] Ambari Views ... SUCCESS [  1.727 
> s]
> [INFO] ambari-utility . SUCCESS [  2.642 
> s]
> [INFO] ambari-metrics . SUCCESS [  0.185 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  0.351 
> s]
> [INFO] Ambari Service Advisor . SUCCESS [  0.374 
> s]
> [INFO] Ambari Server .. SUCCESS [01:32 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>



Review Request 62998: In case only Hive Server Interactive is deployed with no Hive Server in the cluster the hive metastore warehouse directory is not created on DFS.

2017-10-13 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62998/
---

Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Robert Levas, and 
Swapan Shridhar.


Bugs: AMBARI-22243
https://issues.apache.org/jira/browse/AMBARI-22243


Repository: ambari


Description
---

The ware house directory creation logic was part only of HiveServer scripts. 
The same logic had to be added to HiveServer Interactive scripts in order to 
ensure that the warehouse directory is created if solely HiveServer Interactive 
is deployed to the cluster.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 2ed3e3a 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py
 2ed3e3a 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 3dc78ab 


Diff: https://reviews.apache.org/r/62998/diff/1/


Testing
---

Manual testing using Blueprints (currently only with Blueprints it's possible 
to deploy HiveServer Interactive with no HiveServer in the cluster)


Unit tests:
*mvn test  -DskipSurefireTests -am -pl ambari-server*

```
Total run:1204
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server ---
[INFO] Starting audit...
Audit done.
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main  SUCCESS [  0.473 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.003 s]
[INFO] Ambari Views ... SUCCESS [  1.727 s]
[INFO] ambari-utility . SUCCESS [  2.642 s]
[INFO] ambari-metrics . SUCCESS [  0.185 s]
[INFO] Ambari Metrics Common .. SUCCESS [  0.351 s]
[INFO] Ambari Service Advisor . SUCCESS [  0.374 s]
[INFO] Ambari Server .. SUCCESS [01:32 min]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
```


Thanks,

Sebastian Toader