Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/#review190035
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 3, 2017, 4:10 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63537/
> ---
> 
> (Updated Nov. 3, 2017, 4:10 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22362
> https://issues.apache.org/jira/browse/AMBARI-22362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Hive scripts pass in a parameter called {{HIVE_BIN}}. Hive uses this to 
> determine where {{hdp.version}} and {{HADOOP_HOME}} should be sourced from. 
> In many cases, the binary chosen is:
> 
> {{/usr/bin/hive -> /usr/hdp/current/hive-client}}
> 
> This can lead to problems during an upgrade scenario where {{hive-client}} 
> has not yet moved forward. It should be chosen based on the component being 
> restarted...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  3c4255975b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9c6db006c8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  db253d3eed 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_service.py
>  c3bf30c9ab 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
>  8f2132aa76 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_service.py
>  b5640572b3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
>  528760a3b5 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 452c0b61ae 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
> fd92277c3b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 3421189f83 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> e497f3358c 
> 
> 
> Diff: https://reviews.apache.org/r/63537/diff/1/
> 
> 
> Testing
> ---
> 
> Manual deploy of Hive to verify Metastore starts using the right component
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 59.066 s
> [INFO] Finished at: 2017-11-03T10:09:14-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/#review190031
---


Ship it!




Ship It!

- Nate Cole


On Nov. 3, 2017, 10:10 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63537/
> ---
> 
> (Updated Nov. 3, 2017, 10:10 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22362
> https://issues.apache.org/jira/browse/AMBARI-22362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Hive scripts pass in a parameter called {{HIVE_BIN}}. Hive uses this to 
> determine where {{hdp.version}} and {{HADOOP_HOME}} should be sourced from. 
> In many cases, the binary chosen is:
> 
> {{/usr/bin/hive -> /usr/hdp/current/hive-client}}
> 
> This can lead to problems during an upgrade scenario where {{hive-client}} 
> has not yet moved forward. It should be chosen based on the component being 
> restarted...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  3c4255975b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9c6db006c8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  db253d3eed 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_service.py
>  c3bf30c9ab 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
>  8f2132aa76 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_service.py
>  b5640572b3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
>  528760a3b5 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 452c0b61ae 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
> fd92277c3b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 3421189f83 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> e497f3358c 
> 
> 
> Diff: https://reviews.apache.org/r/63537/diff/1/
> 
> 
> Testing
> ---
> 
> Manual deploy of Hive to verify Metastore starts using the right component
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 59.066 s
> [INFO] Finished at: 2017-11-03T10:09:14-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-22362
https://issues.apache.org/jira/browse/AMBARI-22362


Repository: ambari


Description
---

The Hive scripts pass in a parameter called {{HIVE_BIN}}. Hive uses this to 
determine where {{hdp.version}} and {{HADOOP_HOME}} should be sourced from. In 
many cases, the binary chosen is:

{{/usr/bin/hive -> /usr/hdp/current/hive-client}}

This can lead to problems during an upgrade scenario where {{hive-client}} has 
not yet moved forward. It should be chosen based on the component being 
restarted...


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/startMetastore.sh
 86541f07e1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 3c4255975b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9c6db006c8 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
 db253d3eed 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/files/startMetastore.sh
 86541f07e1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_service.py
 c3bf30c9ab 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
 8f2132aa76 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/files/startMetastore.sh
 86541f07e1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_service.py
 b5640572b3 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
 528760a3b5 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
452c0b61ae 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
fd92277c3b 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
3421189f83 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
e497f3358c 


Diff: https://reviews.apache.org/r/63537/diff/1/


Testing
---

Manual deploy of Hive to verify Metastore starts using the right component

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 59.066 s
[INFO] Finished at: 2017-11-03T10:09:14-04:00
[INFO] Final Memory: 21M/619M
[INFO] 


Thanks,

Jonathan Hurley