Re: Review Request 63671: Remove Auto-Installation of LZO Libraries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63671/#review190474 --- Ship it! Ship It! - Sid Wagle On Nov. 8, 2017, 5:08 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63671/ > --- > > (Updated Nov. 8, 2017, 5:08 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. > > > Bugs: AMBARI-22383 > https://issues.apache.org/jira/browse/AMBARI-22383 > > > Repository: ambari > > > Description > --- > > The LZO library licenses are not compatible with Ambari's license and should > not be assumed to be available in Apache-based repositories. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > f144b2da32 > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > cfbb7d81e8 > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 31e78b9e60 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 2df1b9f647 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 8bfa7e63e9 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 6f702d3616 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > 9c4f9d4493 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py > fe488c3004 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 25534e9ff5 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > 89719cff2c > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 5ca012b796 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > 7d22603184 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py > eb57c22834 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > cd1f7ad36f > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > ed3f5fd387 > ambari-server/src/main/resources/custom_actions/scripts/remove_bits.py > 0be9a34ab0 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/metainfo.xml > 8500839692 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py > 3a711c721a > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/metainfo.xml > 918cdb32fa > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/params.py > 1f76f8033a > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/oozie.py > 6cd2b71f8e > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/params.py > febd3e6580 > > ambari-server/src/main/resources/stacks/BigInsights/4.1/services/HDFS/metainfo.xml > 4c00b4f3f8 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/metainfo.xml > fc7c324ff6 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py > 1264284cd4 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py > da8de46165 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py > a77ec82cdc > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py > 33a309fa2e > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py > 0e6179b8a7 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/metainfo.xml > 72ce2be363 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/hdfs.py > 2b158bd128 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/install_params.py > fe488c3004 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/params.py > 7b9c449f28 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/oozie.py > 64a83c0ba9 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/params.py > d1a4a66f40 >
Re: Review Request 63671: Remove Auto-Installation of LZO Libraries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63671/#review190467 --- Ship it! Ship It! - Jonathan Hurley On Nov. 8, 2017, 12:08 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63671/ > --- > > (Updated Nov. 8, 2017, 12:08 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. > > > Bugs: AMBARI-22383 > https://issues.apache.org/jira/browse/AMBARI-22383 > > > Repository: ambari > > > Description > --- > > The LZO library licenses are not compatible with Ambari's license and should > not be assumed to be available in Apache-based repositories. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > f144b2da32 > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > cfbb7d81e8 > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 31e78b9e60 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 2df1b9f647 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 8bfa7e63e9 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 6f702d3616 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > 9c4f9d4493 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py > fe488c3004 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 25534e9ff5 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > 89719cff2c > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 5ca012b796 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > 7d22603184 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py > eb57c22834 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > cd1f7ad36f > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > ed3f5fd387 > ambari-server/src/main/resources/custom_actions/scripts/remove_bits.py > 0be9a34ab0 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/metainfo.xml > 8500839692 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py > 3a711c721a > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/metainfo.xml > 918cdb32fa > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/params.py > 1f76f8033a > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/oozie.py > 6cd2b71f8e > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/params.py > febd3e6580 > > ambari-server/src/main/resources/stacks/BigInsights/4.1/services/HDFS/metainfo.xml > 4c00b4f3f8 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/metainfo.xml > fc7c324ff6 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py > 1264284cd4 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py > da8de46165 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py > a77ec82cdc > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py > 33a309fa2e > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py > 0e6179b8a7 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/metainfo.xml > 72ce2be363 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/hdfs.py > 2b158bd128 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/install_params.py > fe488c3004 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/params.py > 7b9c449f28 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/oozie.py > 64a83c0ba9 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/params.py > d1a4a66f40 >
Re: Review Request 63671: Remove Auto-Installation of LZO Libraries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63671/#review190464 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 8, 2017, 7:08 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63671/ > --- > > (Updated Nov. 8, 2017, 7:08 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. > > > Bugs: AMBARI-22383 > https://issues.apache.org/jira/browse/AMBARI-22383 > > > Repository: ambari > > > Description > --- > > The LZO library licenses are not compatible with Ambari's license and should > not be assumed to be available in Apache-based repositories. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > f144b2da32 > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > cfbb7d81e8 > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > 31e78b9e60 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 2df1b9f647 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py > 8bfa7e63e9 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > 6f702d3616 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py > 9c4f9d4493 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py > fe488c3004 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py > 25534e9ff5 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > 89719cff2c > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 5ca012b796 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > 7d22603184 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py > eb57c22834 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > cd1f7ad36f > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > ed3f5fd387 > ambari-server/src/main/resources/custom_actions/scripts/remove_bits.py > 0be9a34ab0 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/metainfo.xml > 8500839692 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py > 3a711c721a > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/metainfo.xml > 918cdb32fa > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/params.py > 1f76f8033a > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/oozie.py > 6cd2b71f8e > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/params.py > febd3e6580 > > ambari-server/src/main/resources/stacks/BigInsights/4.1/services/HDFS/metainfo.xml > 4c00b4f3f8 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/metainfo.xml > fc7c324ff6 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py > 1264284cd4 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py > da8de46165 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py > a77ec82cdc > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py > 33a309fa2e > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py > 0e6179b8a7 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/metainfo.xml > 72ce2be363 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/hdfs.py > 2b158bd128 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/install_params.py > fe488c3004 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/params.py > 7b9c449f28 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/oozie.py > 64a83c0ba9 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/params.py > d1a4a66f40 >
Review Request 63671: Remove Auto-Installation of LZO Libraries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63671/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. Bugs: AMBARI-22383 https://issues.apache.org/jira/browse/AMBARI-22383 Repository: ambari Description --- The LZO library licenses are not compatible with Ambari's license and should not be assumed to be available in Apache-based repositories. Diffs - ambari-common/src/main/python/resource_management/libraries/functions/__init__.py f144b2da32 ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py cfbb7d81e8 ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 31e78b9e60 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 2df1b9f647 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 8bfa7e63e9 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 6f702d3616 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 9c4f9d4493 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py fe488c3004 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py 25534e9ff5 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 89719cff2c ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 5ca012b796 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 7d22603184 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py eb57c22834 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py cd1f7ad36f ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py ed3f5fd387 ambari-server/src/main/resources/custom_actions/scripts/remove_bits.py 0be9a34ab0 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/metainfo.xml 8500839692 ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py 3a711c721a ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/metainfo.xml 918cdb32fa ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/params.py 1f76f8033a ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/oozie.py 6cd2b71f8e ambari-server/src/main/resources/stacks/BigInsights/4.0/services/OOZIE/package/scripts/params.py febd3e6580 ambari-server/src/main/resources/stacks/BigInsights/4.1/services/HDFS/metainfo.xml 4c00b4f3f8 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/metainfo.xml fc7c324ff6 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/hdfs.py 1264284cd4 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/install_params.py da8de46165 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HDFS/package/scripts/params_linux.py a77ec82cdc ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/oozie.py 33a309fa2e ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/package/scripts/params_linux.py 0e6179b8a7 ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/metainfo.xml 72ce2be363 ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/hdfs.py 2b158bd128 ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/install_params.py fe488c3004 ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HDFS/package/scripts/params.py 7b9c449f28 ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/oozie.py 64a83c0ba9 ambari-server/src/main/resources/stacks/BigInsights/4.2/services/OOZIE/package/scripts/params.py d1a4a66f40 ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 07a9ef8e94 ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/HDFS/metainfo.xml 15fe9311b7 ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 63e85e363f ambari-server/src/test/python/custom_actions/TestRemoveBits.py 6537152afa Diff: https://reviews.apache.org/r/63671/diff/1/ Testing --- Manual testing: installed cluster (no LZO) including Tez, HDFS, Oozie. Manually added LZO libraries, changed confs, restarted and service check. All green. Unit tests: pending Thanks, Nate Cole
