Re: Review Request 63754: AMBARI-22426. Push down Logger instances

2017-11-13 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63754/#review190829
---


Ship it!




Ship It!

- Balázs Bence Sári


On Nov. 13, 2017, 2:31 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63754/
> ---
> 
> (Updated Nov. 13, 2017, 2:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-22426
> https://issues.apache.org/jira/browse/AMBARI-22426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make (almost) all loggers private, push down to subclasses, keep in super 
> class if also used there.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java
>  d0bd5d32f50820adfecfc2282f253e9ae03fbeb3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
>  549da76b3b0c1651507d612b037f3d70715cb7be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  d24780b4ac191743d1e2c2cf4ea8c62c6f5844da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java
>  c86b9a0e50958c693b3f52f1de3aa3df1783fdd4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  2dc45de22655d7c7a69a11335a50f6d130cef34a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  34888f2408b7abcb75825acc1f6b6d15ea9fe2fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
>  e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
>  322596ea5e96c1e17433ad339f39d16898384015 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  1501a0186a315cff2391e0aadbe8c3232bb4d9ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
>  5598650ef1681557464eed5cfbb573f2ecc33c95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  4e618e7ff63679086b507103adee2bc7736a16c4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  32f1fd8f4fcbddd47972add304648db9f44ba8a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  cf4e7475b3ab6ed1e5375af23dcbe28d0533c839 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  c71651e5ff0be669646950cc41b0aa56e73c47f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  43ee7fe7c79a14e2de4c27bb1b121625381f413e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
>  c5c02cf274239fe3493b69f97e69cc63967375dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java
>  135eefece20046037fc5440f4dc3bc946601b1e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a7cda0d8101abccefd0464b75777c78e8cbc9cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  73d24908eabfe76908a60ebe4c0d3d08deb1f32a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  54c83600b78d77ee26dffea947133cc7d07e098e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  98adcd112d768cca61c9eb0d59b00d85d8da0d9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
>  f05ffbe0167fe2a6d4970d3b628fea48a54217ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  2e86b2dcf45076315f54bbf298ab20a107fcf513 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
>  79254c6d8960867f737c64d2b48782e3a364d59d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  f051651e12e1395e24c73af10fafea9ffdb38c1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  6708560969fc4728ca9f56d0d762db9b4438f83e 
>   
> ambari-server/src/main/java/org/apache/am

Re: Review Request 63754: AMBARI-22426. Push down Logger instances

2017-11-13 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63754/#review190817
---


Ship it!




Ship It!

- Attila Magyar


On Nov. 13, 2017, 2:31 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63754/
> ---
> 
> (Updated Nov. 13, 2017, 2:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-22426
> https://issues.apache.org/jira/browse/AMBARI-22426
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make (almost) all loggers private, push down to subclasses, keep in super 
> class if also used there.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java
>  d0bd5d32f50820adfecfc2282f253e9ae03fbeb3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
>  549da76b3b0c1651507d612b037f3d70715cb7be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  d24780b4ac191743d1e2c2cf4ea8c62c6f5844da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java
>  c86b9a0e50958c693b3f52f1de3aa3df1783fdd4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  2dc45de22655d7c7a69a11335a50f6d130cef34a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  34888f2408b7abcb75825acc1f6b6d15ea9fe2fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
>  e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
>  322596ea5e96c1e17433ad339f39d16898384015 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  1501a0186a315cff2391e0aadbe8c3232bb4d9ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
>  5598650ef1681557464eed5cfbb573f2ecc33c95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  4e618e7ff63679086b507103adee2bc7736a16c4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  32f1fd8f4fcbddd47972add304648db9f44ba8a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  cf4e7475b3ab6ed1e5375af23dcbe28d0533c839 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  c71651e5ff0be669646950cc41b0aa56e73c47f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  43ee7fe7c79a14e2de4c27bb1b121625381f413e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
>  c5c02cf274239fe3493b69f97e69cc63967375dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java
>  135eefece20046037fc5440f4dc3bc946601b1e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a7cda0d8101abccefd0464b75777c78e8cbc9cb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  73d24908eabfe76908a60ebe4c0d3d08deb1f32a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  54c83600b78d77ee26dffea947133cc7d07e098e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  98adcd112d768cca61c9eb0d59b00d85d8da0d9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
>  f05ffbe0167fe2a6d4970d3b628fea48a54217ec 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  2e86b2dcf45076315f54bbf298ab20a107fcf513 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
>  79254c6d8960867f737c64d2b48782e3a364d59d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  f051651e12e1395e24c73af10fafea9ffdb38c1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  6708560969fc4728ca9f56d0d762db9b4438f83e 
>   
> ambari-server/src/main/java/org/apache/ambari

Review Request 63754: AMBARI-22426. Push down Logger instances

2017-11-13 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63754/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Jonathan 
Hurley.


Bugs: AMBARI-22426
https://issues.apache.org/jira/browse/AMBARI-22426


Repository: ambari


Description
---

Make (almost) all loggers private, push down to subclasses, keep in super class 
if also used there.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java
 d0bd5d32f50820adfecfc2282f253e9ae03fbeb3 
  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
 549da76b3b0c1651507d612b037f3d70715cb7be 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 d24780b4ac191743d1e2c2cf4ea8c62c6f5844da 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java
 c86b9a0e50958c693b3f52f1de3aa3df1783fdd4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 2dc45de22655d7c7a69a11335a50f6d130cef34a 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 34888f2408b7abcb75825acc1f6b6d15ea9fe2fa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
 e134f6dc6ef9850bb4e8d2cc58b7bf7c860f4da0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java
 322596ea5e96c1e17433ad339f39d16898384015 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 1501a0186a315cff2391e0aadbe8c3232bb4d9ee 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
 5598650ef1681557464eed5cfbb573f2ecc33c95 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
 4e618e7ff63679086b507103adee2bc7736a16c4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 32f1fd8f4fcbddd47972add304648db9f44ba8a3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
 cf4e7475b3ab6ed1e5375af23dcbe28d0533c839 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 c71651e5ff0be669646950cc41b0aa56e73c47f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 43ee7fe7c79a14e2de4c27bb1b121625381f413e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
 c5c02cf274239fe3493b69f97e69cc63967375dd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java
 135eefece20046037fc5440f4dc3bc946601b1e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 5a7cda0d8101abccefd0464b75777c78e8cbc9cb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 73d24908eabfe76908a60ebe4c0d3d08deb1f32a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 54c83600b78d77ee26dffea947133cc7d07e098e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 98adcd112d768cca61c9eb0d59b00d85d8da0d9a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
 f05ffbe0167fe2a6d4970d3b628fea48a54217ec 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 2e86b2dcf45076315f54bbf298ab20a107fcf513 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
 79254c6d8960867f737c64d2b48782e3a364d59d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 f051651e12e1395e24c73af10fafea9ffdb38c1a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 6708560969fc4728ca9f56d0d762db9b4438f83e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 5373ffe31cb367ab63a6940664cb5b7cfdafe7bb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 b1062090e114554cfe4490ac5e92308018e79e09 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
 f94b979a49c7d9cdddb913b5c32a600f026f0f9a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpPropertyProvider.java
 c556b06d5de91d806b6dafb542c7ca3f8aceb0ba 
  
ambari-server/src/main/java/org/apache/a