Re: Review Request 63755: Check if configurations used for commands are of correct version

2017-11-13 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63755/#review190847
---




ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Lines 466 (patched)


Shouldn't this exception be caught and subsequently result in refresh of 
config cache instead of failing?


- Sid Wagle


On Nov. 13, 2017, 2:45 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63755/
> ---
> 
> (Updated Nov. 13, 2017, 2:45 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22427
> https://issues.apache.org/jira/browse/AMBARI-22427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This was not reproduced, but theoretically race condition might occur causing
> configuration update event to be received later than the actual commands which
> needs those configs.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ConfigurationBuilder.py 
> f8bdb4299c 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 0debb1b603 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/CommandsEventListener.py 
> ae8d400d35 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
>  a4884d884e 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 162a809933 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/configurations_update.json
>  e8e1ab546d 
>   
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json
>  76dac1b975 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java
>  f9663860ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java
>  50779ffad4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java
>  a8b0a32a30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java
>  7c540f99a0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java
>  89fc8bc42a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ExecutionCommandEvent.java
>  c97ed6068a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AgentCommandsPublisher.java
>  bacdc2d896 
> 
> 
> Diff: https://reviews.apache.org/r/63755/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 63755: Check if configurations used for commands are of correct version

2017-11-13 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63755/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22427
https://issues.apache.org/jira/browse/AMBARI-22427


Repository: ambari


Description
---

This was not reproduced, but theoretically race condition might occur causing
configuration update event to be received later than the actual commands which
needs those configs.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ConfigurationBuilder.py f8bdb4299c 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
0debb1b603 
  ambari-agent/src/main/python/ambari_agent/listeners/CommandsEventListener.py 
ae8d400d35 
  
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
 a4884d884e 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
162a809933 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/configurations_update.json
 e8e1ab546d 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json
 76dac1b975 


Diff: https://reviews.apache.org/r/63755/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk