Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/#review192291 --- This has been pushed. Please close this review and appropriate JIRA. - Nate Cole On Nov. 20, 2017, 9:25 a.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63945/ > --- > > (Updated Nov. 20, 2017, 9:25 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22393 > https://issues.apache.org/jira/browse/AMBARI-22393 > > > Repository: ambari > > > Description > --- > > The bootstrap process fails with code 44 incase the ambari repository URL is > not set for a particular os type in the ambari.properties file. Checks for > the returned status code from bootstrap.py and accordingly displays a prompt > on UI for ambari reposiory URL for the failing os types. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java > 3d1b31c > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java > b72ca20 > ambari-web/app/controllers/wizard/step3_controller.js 29393e3 > ambari-web/app/messages.js 390f803 > ambari-web/app/styles/wizard.less cb9eb92 > ambari-web/app/templates/wizard/step3.hbs e00012c > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/63945/diff/2/ > > > Testing > --- > > Tests were successful in ambari-web and ambari-server. > > > Thanks, > > Sonia Garudi > >
Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/#review192168 --- Ship it! Ship It! - Nate Cole On Nov. 20, 2017, 9:25 a.m., Sonia Garudi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63945/ > --- > > (Updated Nov. 20, 2017, 9:25 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22393 > https://issues.apache.org/jira/browse/AMBARI-22393 > > > Repository: ambari > > > Description > --- > > The bootstrap process fails with code 44 incase the ambari repository URL is > not set for a particular os type in the ambari.properties file. Checks for > the returned status code from bootstrap.py and accordingly displays a prompt > on UI for ambari reposiory URL for the failing os types. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java > 3d1b31c > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java > b72ca20 > ambari-web/app/controllers/wizard/step3_controller.js 29393e3 > ambari-web/app/messages.js 390f803 > ambari-web/app/styles/wizard.less cb9eb92 > ambari-web/app/templates/wizard/step3.hbs e00012c > ambari-web/test/controllers/wizard/step3_test.js b8bc794 > > > Diff: https://reviews.apache.org/r/63945/diff/2/ > > > Testing > --- > > Tests were successful in ambari-web and ambari-server. > > > Thanks, > > Sonia Garudi > >
Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/ --- (Updated Nov. 20, 2017, 2:25 p.m.) Review request for Ambari and Nate Cole. Changes --- Fix for 1 test case failure in doBootstrapSuccessCallback Bugs: AMBARI-22393 https://issues.apache.org/jira/browse/AMBARI-22393 Repository: ambari Description --- The bootstrap process fails with code 44 incase the ambari repository URL is not set for a particular os type in the ambari.properties file. Checks for the returned status code from bootstrap.py and accordingly displays a prompt on UI for ambari reposiory URL for the failing os types. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java 3d1b31c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java b72ca20 ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/messages.js 390f803 ambari-web/app/styles/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/63945/diff/2/ Changes: https://reviews.apache.org/r/63945/diff/1-2/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/ --- (Updated Nov. 20, 2017, 9:48 a.m.) Review request for Ambari and Nate Cole. Bugs: AMBARI-22393 https://issues.apache.org/jira/browse/AMBARI-22393 Repository: ambari Description --- The bootstrap process fails with code 44 incase the ambari repository URL is not set for a particular os type in the ambari.properties file. Checks for the returned status code from bootstrap.py and accordingly displays a prompt on UI for ambari reposiory URL for the failing os types. Diffs - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java 3d1b31c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java b72ca20 ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/messages.js 390f803 ambari-web/app/styles/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/63945/diff/1/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22393 https://issues.apache.org/jira/browse/AMBARI-22393 Repository: ambari Description --- The bootstrap process fails with code 44 incase the ambari repository URL is not set for a particular os type in the ambari.properties file. Checks for the returned status code from bootstrap.py and accordingly displays a prompt on UI for ambari reposiory URL for the failing os types. Diffs - ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatus.java 3d1b31c ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java b72ca20 ambari-web/app/controllers/wizard/step3_controller.js 29393e3 ambari-web/app/messages.js 390f803 ambari-web/app/styles/wizard.less cb9eb92 ambari-web/app/templates/wizard/step3.hbs e00012c ambari-web/test/controllers/wizard/step3_test.js b8bc794 Diff: https://reviews.apache.org/r/63945/diff/1/ Testing --- Tests were successful in ambari-web and ambari-server. Thanks, Sonia Garudi
