Re: Review Request 64216: . Repository validation fails for HDP-GPL

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64216/
---

(Updated Лис. 30, 2017, 10:23 після полудня)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-22565
https://issues.apache.org/jira/browse/AMBARI-22565


Repository: ambari


Description
---

Server always fail to validate repository with unknown repo_id.
We perform repository lookup in stack only to get repo_name. Should use 
repo_name received from API request.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
 84929bfe0eb498917401445b5ce8cd8a015bfa0f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 cec43dd40f20061965cc98cc357d193a76a16533 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 6e9e5efcd408b683224db46e668a44336a9cf167 


Diff: https://reviews.apache.org/r/64216/diff/2/

Changes: https://reviews.apache.org/r/64216/diff/1-2/


Testing
---

mvn clean test


Thanks,

Myroslav Papirkovskyy

Re: Review Request 64216: . Repository validation fails for HDP-GPL

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64216/#review192317
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
Line 4585 (original), 4585 (patched)


Throw exception if StringUtils.isEmpty(repoName)



ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
Lines 89 (patched)


Maybe some documentation so people know what a repo name is. Something 
like: Gets the name of the repository without any version identifiers


- Jonathan Hurley


On Nov. 30, 2017, 12:14 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64216/
> ---
> 
> (Updated Nov. 30, 2017, 12:14 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22565
> https://issues.apache.org/jira/browse/AMBARI-22565
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Server always fail to validate repository with unknown repo_id.
> We perform repository lookup in stack only to get repo_name. Should use 
> repo_name received from API request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
>  84929bfe0eb498917401445b5ce8cd8a015bfa0f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  cec43dd40f20061965cc98cc357d193a76a16533 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  6e9e5efcd408b683224db46e668a44336a9cf167 
> 
> 
> Diff: https://reviews.apache.org/r/64216/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64216: . Repository validation fails for HDP-GPL

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64216/#review192314
---


Ship it!




Ship It!

- Sid Wagle


On Nov. 30, 2017, 5:14 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64216/
> ---
> 
> (Updated Nov. 30, 2017, 5:14 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22565
> https://issues.apache.org/jira/browse/AMBARI-22565
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Server always fail to validate repository with unknown repo_id.
> We perform repository lookup in stack only to get repo_name. Should use 
> repo_name received from API request.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
>  84929bfe0eb498917401445b5ce8cd8a015bfa0f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  cec43dd40f20061965cc98cc357d193a76a16533 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  6e9e5efcd408b683224db46e668a44336a9cf167 
> 
> 
> Diff: https://reviews.apache.org/r/64216/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 64216: . Repository validation fails for HDP-GPL

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64216/
---

(Updated Лис. 30, 2017, 7:14 після полудня)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-22565
https://issues.apache.org/jira/browse/AMBARI-22565


Repository: ambari


Description (updated)
---

Server always fail to validate repository with unknown repo_id.
We perform repository lookup in stack only to get repo_name. Should use 
repo_name received from API request.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
 84929bfe0eb498917401445b5ce8cd8a015bfa0f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 cec43dd40f20061965cc98cc357d193a76a16533 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 6e9e5efcd408b683224db46e668a44336a9cf167 


Diff: https://reviews.apache.org/r/64216/diff/1/


Testing
---

mvn clean test


Thanks,

Myroslav Papirkovskyy

Review Request 64216: . Repository validation fails for HDP-GPL

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64216/
---

Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-22565
https://issues.apache.org/jira/browse/AMBARI-22565


Repository: ambari


Description
---

AMBARI-22565


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 48ab1b93e880e6e46c3e6f70dc433a5a3643a2ee 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
 84929bfe0eb498917401445b5ce8cd8a015bfa0f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 cec43dd40f20061965cc98cc357d193a76a16533 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 00b87a69224c35a25c3c0e0ec39a9bbd4fc7a9b8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 6e9e5efcd408b683224db46e668a44336a9cf167 


Diff: https://reviews.apache.org/r/64216/diff/1/


Testing
---

mvn clean test


Thanks,

Myroslav Papirkovskyy