Re: Review Request 64542: Kerberos support for OneFS

2017-12-14 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193804
---


Ship it!




Ship It!

- Robert Levas


On Dec. 14, 2017, 6:26 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 14, 2017, 6:26 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Eugene Chekanskiy, Nate Cole, 
> Robert Levas, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 9c864a8 
>   ambari-web/app/messages.js b305196 
>   ambari-web/app/templates/main/admin/kerberos/step1.hbs 57d0637 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc5 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/3/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64542: Kerberos support for OneFS

2017-12-14 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193791
---


Ship it!




Ship It!

- Nate Cole


On Dec. 14, 2017, 6:26 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 14, 2017, 6:26 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Eugene Chekanskiy, Nate Cole, 
> Robert Levas, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 9c864a8 
>   ambari-web/app/messages.js b305196 
>   ambari-web/app/templates/main/admin/kerberos/step1.hbs 57d0637 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc5 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/3/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64542: Kerberos support for OneFS

2017-12-14 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/
---

(Updated Dec. 14, 2017, 11:26 a.m.)


Review request for Ambari, Andrii Babiichuk, Eugene Chekanskiy, Nate Cole, 
Robert Levas, and Sandor Molnar.


Changes
---

showing OneFS related prerequisite only if OneFS is installed


Bugs: AMBARI-22634
https://issues.apache.org/jira/browse/AMBARI-22634


Repository: ambari


Description
---

When kerberos is enabled, the OneFS service check should do a kinit before 
executing hdfs commands. I also removed some unused code from the servicecheck 
script.


Diffs (updated)
-

  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 9c864a8 
  ambari-web/app/messages.js b305196 
  ambari-web/app/templates/main/admin/kerberos/step1.hbs 57d0637 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
 PRE-CREATION 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
 b823fc5 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
 3d798a3 


Diff: https://reviews.apache.org/r/64542/diff/2/

Changes: https://reviews.apache.org/r/64542/diff/1-2/


Testing
---

- enabled kerberos, ran service checks on onefs


Thanks,

Attila Magyar

Re: Review Request 64542: Kerberos support for OneFS

2017-12-13 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193704
---


Ship it!




Ship It!

- Robert Levas


On Dec. 12, 2017, 10:38 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 12, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
> Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
>   ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc54b84e1149164e17504046a7a32070df1c 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3342ced3d99a4a2c955a6aca27108c 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/1/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64542: Kerberos support for OneFS

2017-12-13 Thread Eugene Chekanskiy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193700
---


Ship it!




Ship It!

- Eugene Chekanskiy


On Dec. 12, 2017, 3:38 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 12, 2017, 3:38 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
> Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
>   ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc54b84e1149164e17504046a7a32070df1c 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3342ced3d99a4a2c955a6aca27108c 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/1/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64542: Kerberos support for OneFS

2017-12-13 Thread Robert Levas 


> On Dec. 12, 2017, 11:03 a.m., Nate Cole wrote:
> > ambari-web/app/controllers/main/admin/kerberos/step1_controller.js
> > Lines 45-47 (patched)
> > 
> >
> > Is this, or can this be made to show conditionally if isilon is chosen?

+1.. We should not show this unless Isilon is involved, else it will cause some 
concusion.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193551
---


On Dec. 12, 2017, 10:38 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 12, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
> Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
>   ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc54b84e1149164e17504046a7a32070df1c 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3342ced3d99a4a2c955a6aca27108c 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/1/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64542: Kerberos support for OneFS

2017-12-12 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/#review193551
---


Fix it, then Ship it!





ambari-web/app/controllers/main/admin/kerberos/step1_controller.js
Lines 45-47 (patched)


Is this, or can this be made to show conditionally if isilon is chosen?


- Nate Cole


On Dec. 12, 2017, 10:38 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64542/
> ---
> 
> (Updated Dec. 12, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
> Sandor Molnar.
> 
> 
> Bugs: AMBARI-22634
> https://issues.apache.org/jira/browse/AMBARI-22634
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the OneFS service check should do a kinit before 
> executing hdfs commands. I also removed some unused code from the 
> servicecheck script.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
> 9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
>   ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
>  PRE-CREATION 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
>  b823fc54b84e1149164e17504046a7a32070df1c 
>   
> contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
>  3d798a3342ced3d99a4a2c955a6aca27108c 
> 
> 
> Diff: https://reviews.apache.org/r/64542/diff/1/
> 
> 
> Testing
> ---
> 
> - enabled kerberos, ran service checks on onefs
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 64542: Kerberos support for OneFS

2017-12-12 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64542/
---

Review request for Ambari, Eugene Chekanskiy, Nate Cole, Robert Levas, and 
Sandor Molnar.


Bugs: AMBARI-22634
https://issues.apache.org/jira/browse/AMBARI-22634


Repository: ambari


Description
---

When kerberos is enabled, the OneFS service check should do a kinit before 
executing hdfs commands. I also removed some unused code from the servicecheck 
script.


Diffs
-

  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 
9c864a8f48889515d5b72c0feaf340b7b9e1fe31 
  ambari-web/app/messages.js b3051962f56951fc6bae169b63c5f029c1ef301d 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/kerberos.json
 PRE-CREATION 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py
 b823fc54b84e1149164e17504046a7a32070df1c 
  
contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/service_check.py
 3d798a3342ced3d99a4a2c955a6aca27108c 


Diff: https://reviews.apache.org/r/64542/diff/1/


Testing
---

- enabled kerberos, ran service checks on onefs


Thanks,

Attila Magyar