Re: Review Request 64913: AMBARI-22718. Cannot set security.inter.broker.protocol: SASL_SSL via Blueprint with Kerberos

2018-01-03 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64913/#review194699
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 3, 2018, 9:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64913/
> ---
> 
> (Updated Jan. 3, 2018, 9:16 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22718
> https://issues.apache.org/jira/browse/AMBARI-22718
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change Kafka stack script `params.py` to accept `SASL_SSL` as a valid 
> `security.inter.broker.protocol` value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  c6b36a1c729e6edb3c26043d2392cc177ad6d220 
>   
> ambari-server/src/test/python/stacks/2.6/KAFKA/test_kafka_broker_other_sasl.py
>  e0bab4017057c25c958f5c93cff65e128cbbf72e 
>   ambari-server/src/test/python/stacks/2.6/configs/secure_kafka_sasl_ssl.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64913/diff/1/
> 
> 
> Testing
> ---
> 
> Tested per steps in 
> [AMBARI-22718](https://issues.apache.org/jira/browse/AMBARI-22718)
> 
> Added unit test.  Unit tests are OK:
> 
> ```
> Total run:1201
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>



Re: Review Request 64913: AMBARI-22718. Cannot set security.inter.broker.protocol: SASL_SSL via Blueprint with Kerberos

2018-01-03 Thread Robert Levas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64913/#review194694
---


Ship it!




Ship It!

- Robert Levas


On Jan. 3, 2018, 4:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64913/
> ---
> 
> (Updated Jan. 3, 2018, 4:16 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22718
> https://issues.apache.org/jira/browse/AMBARI-22718
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change Kafka stack script `params.py` to accept `SASL_SSL` as a valid 
> `security.inter.broker.protocol` value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  c6b36a1c729e6edb3c26043d2392cc177ad6d220 
>   
> ambari-server/src/test/python/stacks/2.6/KAFKA/test_kafka_broker_other_sasl.py
>  e0bab4017057c25c958f5c93cff65e128cbbf72e 
>   ambari-server/src/test/python/stacks/2.6/configs/secure_kafka_sasl_ssl.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64913/diff/1/
> 
> 
> Testing
> ---
> 
> Tested per steps in 
> [AMBARI-22718](https://issues.apache.org/jira/browse/AMBARI-22718)
> 
> Added unit test.  Unit tests are OK:
> 
> ```
> Total run:1201
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>