date:20170314

Re: Review Request 57582: Create a prototype of ambari-server swagger integration

2017-03-14 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57582/
---

(Updated March 14, 2017, 6:26 p.m.)

Review request for Ambari, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sid
Wagle, and Yusaku Sako.

Bugs: AMBARI-20436
https://issues.apache.org/jira/browse/AMBARI-20436

Repository: ambari

Description (updated)
---

A separate branch is created for this work: ambari-rest-api-explorer

## As part of this task, following changes are done:
1. Users, Groups and Views API are integrated with swagger and exposed from
ambari rest api explorer ui (swagger ui) on a deployed cluster at path:
http://c6404.ambari.apache.org:8080/api-docs
2. swagger-maven-plugin is used to generate swagger.json file on compile time.
This file is published in web resources directory. Note that this file is
generated build time and will be available on deployed ambari-server host at
web resources location but it is not yet decided to be committed and maintained
in Ambari source code
3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json
file (that can be shown as markdown in github). More information about this
format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This
generates files in docs/api/asciidoc/** location at build time. This directory
is currently intended to be committed and maintained in ambari source code
4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin
(adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to
ambari-web/api-docs directory with certain modification to make it work with
ambari api. Further ui polishing will be done in subsequent tasks. Also there
is a strong possibility to maintain the fork code of swagger-ui and compile
(minify and concanate) it during ambari compile time rather than directly using
swagger-ui dist files. Doing so will help developers when customization done
over swagger-ui will increase
5. swagger-annotation expects application to define schema of request body and
response for each endpoint to be encapsulated in a class. While Ambari follows
this pattern for some of the endpoint, there are many others which does not do
so. For The ones which do not does so, new request and response classes were
defined. Going forward at the completion of this epic, either each resource
type or each resource provider should be coupled with a resource response class
and a resource request class. As part of this patch, each resourceprovider
worked upon introduces a new method "getResponse". At completion of this epic
ResourceProvider interface should also declare methods like "getResponse" and
"getRequest" that returns response schema and request schema instances for the
resource API endpoints
6. Currently it seems that swagger has a limitation in supporting "subresource
locator methods". This issue is been reported to swagger community and is being
tracked at [link|https://github.com/swagger-api/swagger-core/issues/2136]. As a
result of which currently as a temporary workaround, all subresources are
converted to root resources. Also all root resources on similar path are moved
under same subpackages (like userApi, groupApi and viewApi).

Diffs
-

LICENSE.txt f05016f
ambari-server/docs/api/asciidoc/definitions.adoc PRE-CREATION
ambari-server/docs/api/asciidoc/overview.adoc PRE-CREATION
ambari-server/docs/api/asciidoc/paths.adoc PRE-CREATION
ambari-server/pom.xml f0c73e4

ambari-server/src/main/java/org/apache/ambari/server/api/services/ActiveWidgetLayoutService.java
40cd6e0

ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupPrivilegeService.java
9c1f1a3

ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupService.java
8ec0097

ambari-server/src/main/java/org/apache/ambari/server/api/services/MemberService.java
28e53e6

ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java
26a7107

ambari-server/src/main/java/org/apache/ambari/server/api/services/UserPrivilegeService.java
f9c95e7

ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java
31f3a8c

ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewDataMigrationService.java
2a9aa64

ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewExternalSubResourceService.java
66ccae7

ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java
53d4918

ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewPermissionService.java
8f7f4ef

ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewPrivilegeService.java
7393745

ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java
17a9f34

Re: Review Request 57453: Fix up tez view version

2017-03-14 Thread Ashwin Rajeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/#review168915
---


Ship it!




Ship It!

- Ashwin Rajeev


On March 14, 2017, 1:59 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57453/
> ---
> 
> (Updated March 14, 2017, 1:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav 
> Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20370
> https://issues.apache.org/jira/browse/AMBARI-20370
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> tez view version and build removed and short url of auto instance used for 
> property tez.tez-ui.history-url.base in tez-site
> Removed change of tez version from AbstractUpgradeCatalog.
> UpgardeCatalog250 now contains code to change the previous value of 
> tez.tez-ui.history-url.base to 
> http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance
> changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during 
> installation
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  9be541f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  e3afc33 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> d45cf96 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 6d0ce38 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java
>  5fa7cac 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  ad21331 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 5fce011 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> b1ec05b 
> 
> 
> Diff: https://reviews.apache.org/r/57453/diff/2/
> 
> 
> Testing
> ---
> 
> Tested the upgrade from 2.4.0.2 to 2.5.0.0.
> Tested installation of fresh 2.5.0.0
> Added test cases for changes in UpgardeCatalog250.
> updated test_stack_advisor.py test cases.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 57612: Some random status command takes more than 5 seconds to execute

2017-03-14 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57612/#review168930
---


Ship it!




Ship It!

- Sid Wagle


On March 14, 2017, 5:40 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57612/
> ---
> 
> (Updated March 14, 2017, 5:40 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-20448
> https://issues.apache.org/jira/browse/AMBARI-20448
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> reimporting subprocess and multiprocessing(this one just in case) modules in 
> StatusCommandsExecutor process to avoid bugs.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 3b23f1c 
> 
> 
> Diff: https://reviews.apache.org/r/57612/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57582: Create a prototype of ambari-server swagger integration

2017-03-14 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57582/#review168931
---




ambari-server/pom.xml
Lines 1628 (patched)


Is this specific impl a required dep? We probably should shade some 
specific deps, I know we are not doing that currently in ambari.


- Sid Wagle


On March 14, 2017, 6:27 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57582/
> ---
> 
> (Updated March 14, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert 
> Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20436
> https://issues.apache.org/jira/browse/AMBARI-20436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A separate branch is created for this work: ambari-rest-api-explorer
> 
> ## As part of this task, following changes are done:
> 1. Users, Groups and Views API are integrated with swagger and exposed from 
> ambari rest api explorer ui (swagger ui) on a deployed cluster at path: 
> http://c6404.ambari.apache.org:8080/api-docs
> 2. swagger-maven-plugin is used to generate swagger.json file on compile 
> time. This file is published in web resources directory. Note that this file 
> is generated build time and will be available on deployed ambari-server host 
> at web resources location but it is not yet decided to be committed and 
> maintained in Ambari source code
> 3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json 
> file (that can be shown as markdown in github). More information about this 
> format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This 
> generates files in docs/api/asciidoc/** location at build time. This 
> directory is currently intended to be committed and maintained in ambari 
> source code
> 4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin 
> (adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to 
> ambari-web/api-docs directory with certain modification to make it work with 
> ambari api. Further ui polishing will be done in subsequent tasks. Also there 
> is a strong possibility to maintain the fork code of swagger-ui and compile 
> (minify and concanate) it during ambari compile time rather than directly 
> using swagger-ui dist files. Doing so will help developers when customization 
> done over swagger-ui will increase
> 5. swagger-annotation expects application to define schema of request body 
> and response for each endpoint to be encapsulated in a class. While Ambari 
> follows this pattern for some of the endpoint, there are many others which 
> does not do so. For The ones which do not does so, new request and response 
> classes were defined. Going forward at the completion of this epic, either 
> each resource type or each resource provider should be coupled with a 
> resource response class and a resource request class. As part of this patch, 
> each resourceprovider worked upon introduces a new method "getResponse". At 
> completion of this epic ResourceProvider interface should also declare 
> methods like "getResponse" and "getRequest" that returns response schema and 
> request schema instances for the resource API endpoints
> 6. Currently it seems that swagger has a limitation in supporting  
> "subresource locator methods". This issue is been reported to swagger 
> community and is being tracked at 
> [link|https://github.com/swagger-api/swagger-core/issues/2136]. As a result 
> of which currently as a temporary workaround, all subresources are converted 
> to root resources. Also all root resources on similar path are moved under 
> same subpackages (like userApi, groupApi and viewApi).
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f05016f 
>   ambari-server/docs/api/asciidoc/definitions.adoc PRE-CREATION 
>   ambari-server/docs/api/asciidoc/overview.adoc PRE-CREATION 
>   ambari-server/docs/api/asciidoc/paths.adoc PRE-CREATION 
>   ambari-server/pom.xml f0c73e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ActiveWidgetLayoutService.java
>  40cd6e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupPrivilegeService.java
>  9c1f1a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupService.java
>  8ec0097 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/MemberService.java
>  28e53e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java
>  26a7107 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UserPrivilegeService.java
>

Re: Review Request 57612: Some random status command takes more than 5 seconds to execute

2017-03-14 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57612/
---

(Updated March 14, 2017, 5:40 p.m.)


Review request for Ambari, Attila Doroszlai and Andrew Onischuk.


Bugs: AMBARI-20448
https://issues.apache.org/jira/browse/AMBARI-20448


Repository: ambari


Description
---

reimporting subprocess and multiprocessing(this one just in case) modules in 
StatusCommandsExecutor process to avoid bugs.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 3b23f1c 


Diff: https://reviews.apache.org/r/57612/diff/1/


Testing (updated)
---

mvn clean test, manual test


Thanks,

Eugene Chekanskiy

Re: Review Request 57565: Ambari should allow empty string for hive.metastore.uris when running in embedded mode

2017-03-14 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57565/#review168923
---


Ship it!




Ship It!

- Madhuvanthi Radhakrishnan


On March 13, 2017, 6:30 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57565/
> ---
> 
> (Updated March 13, 2017, 6:30 p.m.)
> 
> 
> Review request for Ambari, Madhuvanthi Radhakrishnan, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-20427
> https://issues.apache.org/jira/browse/AMBARI-20427
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari UI prevents setting a value of null or empty string for 
> hive.metastore.uris
> This is a valid use-case for embedded mode.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestLibraryFunctions.py 
> 4e6b6c3 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_port_from_url.py
>  ed4586c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
>  3d08867 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  45a8c07 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  fdc96db 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
>  856941f 
> 
> 
> Diff: https://reviews.apache.org/r/57565/diff/1/
> 
> 
> Testing
> ---
> 
> Verified on live cluster.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 57612: Some random status command takes more than 5 seconds to execute

2017-03-14 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57612/#review168936
---


Ship it!




Ship It!

- Attila Doroszlai


On March 14, 2017, 6:40 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57612/
> ---
> 
> (Updated March 14, 2017, 6:40 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-20448
> https://issues.apache.org/jira/browse/AMBARI-20448
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> reimporting subprocess and multiprocessing(this one just in case) modules in 
> StatusCommandsExecutor process to avoid bugs.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 3b23f1c 
> 
> 
> Diff: https://reviews.apache.org/r/57612/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, manual test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57582: Create a prototype of ambari-server swagger integration

2017-03-14 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57582/#review168957
---


Ship it!




Instead of ../api/services/viewApi/*classes*
../resources/views/
etc

- Sid Wagle


On March 14, 2017, 11:35 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57582/
> ---
> 
> (Updated March 14, 2017, 11:35 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert 
> Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20436
> https://issues.apache.org/jira/browse/AMBARI-20436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A separate branch is created for this work: ambari-rest-api-explorer
> 
> ## As part of this task, following changes are done:
> 1. Users, Groups and Views API are integrated with swagger and exposed from 
> ambari rest api explorer ui (swagger ui) on a deployed cluster at path: 
> http://c6404.ambari.apache.org:8080/api-docs
> 2. swagger-maven-plugin is used to generate swagger.json file on compile 
> time. This file is published in web resources directory. Note that this file 
> is generated build time and will be available on deployed ambari-server host 
> at web resources location but it is not yet decided to be committed and 
> maintained in Ambari source code
> 3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json 
> file (that can be shown as markdown in github). More information about this 
> format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This 
> generates files in docs/api/asciidoc/** location at build time. This 
> directory is currently intended to be committed and maintained in ambari 
> source code
> 4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin 
> (adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to 
> ambari-web/api-docs directory with certain modification to make it work with 
> ambari api. Further ui polishing will be done in subsequent tasks. Also there 
> is a strong possibility to maintain the fork code of swagger-ui and compile 
> (minify and concanate) it during ambari compile time rather than directly 
> using swagger-ui dist files. Doing so will help developers when customization 
> done over swagger-ui will increase
> 5. swagger-annotation expects application to define schema of request body 
> and response for each endpoint to be encapsulated in a class. While Ambari 
> follows this pattern for some of the endpoint, there are many others which 
> does not do so. For The ones which do not does so, new request and response 
> classes were defined. Going forward at the completion of this epic, either 
> each resource type or each resource provider should be coupled with a 
> resource response class and a resource request class. As part of this patch, 
> each resourceprovider worked upon introduces a new method "getResponse". At 
> completion of this epic ResourceProvider interface should also declare 
> methods like "getResponse" and "getRequest" that returns response schema and 
> request schema instances for the resource API endpoints
> 6. Currently it seems that swagger has a limitation in supporting  
> "subresource locator methods". This issue is been reported to swagger 
> community and is being tracked at 
> [link|https://github.com/swagger-api/swagger-core/issues/2136]. As a result 
> of which currently as a temporary workaround, all subresources are converted 
> to root resources. Also all root resources on similar path are moved under 
> same subpackages (like userApi, groupApi and viewApi).
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f05016f 
>   ambari-server/docs/api/asciidoc/definitions.adoc PRE-CREATION 
>   ambari-server/docs/api/asciidoc/overview.adoc PRE-CREATION 
>   ambari-server/docs/api/asciidoc/paths.adoc PRE-CREATION 
>   ambari-server/pom.xml f0c73e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ActiveWidgetLayoutService.java
>  40cd6e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupPrivilegeService.java
>  9c1f1a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupService.java
>  8ec0097 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/MemberService.java
>  28e53e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UserAuthorizationService.java
>  26a7107 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UserPrivilegeService.java
>  f9c95e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UserService.java
>  31f3a8c 
>   
>

Re: Review Request 57582: Create a prototype of ambari-server swagger integration

2017-03-14 Thread Jaimin Jetly



> On March 14, 2017, 7:46 p.m., Sid Wagle wrote:
> > ambari-server/pom.xml
> > Lines 1628 (patched)
> > 
> >
> > Is this specific impl a required dep? We probably should shade some 
> > specific deps, I know we are not doing that currently in ambari.

No. I have removed that dependency in the 2nd revision of the patch


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57582/#review168931
---


On March 14, 2017, 11:35 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57582/
> ---
> 
> (Updated March 14, 2017, 11:35 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert 
> Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20436
> https://issues.apache.org/jira/browse/AMBARI-20436
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A separate branch is created for this work: ambari-rest-api-explorer
> 
> ## As part of this task, following changes are done:
> 1. Users, Groups and Views API are integrated with swagger and exposed from 
> ambari rest api explorer ui (swagger ui) on a deployed cluster at path: 
> http://c6404.ambari.apache.org:8080/api-docs
> 2. swagger-maven-plugin is used to generate swagger.json file on compile 
> time. This file is published in web resources directory. Note that this file 
> is generated build time and will be available on deployed ambari-server host 
> at web resources location but it is not yet decided to be committed and 
> maintained in Ambari source code
> 3. swagger2markup-maven-plugin is used to generate asciidoc from swagger.json 
> file (that can be shown as markdown in github). More information about this 
> format an be found at http://asciidoc.org/ and http://asciidoctor.org/. This 
> generates files in docs/api/asciidoc/** location at build time. This 
> directory is currently intended to be committed and maintained in ambari 
> source code
> 4. swagger-ui (version: v2.1.1-M2) compiled code with the different css skin 
> (adopted from [link|https://github.com/jensoleg/swagger-ui]) is committed to 
> ambari-web/api-docs directory with certain modification to make it work with 
> ambari api. Further ui polishing will be done in subsequent tasks. Also there 
> is a strong possibility to maintain the fork code of swagger-ui and compile 
> (minify and concanate) it during ambari compile time rather than directly 
> using swagger-ui dist files. Doing so will help developers when customization 
> done over swagger-ui will increase
> 5. swagger-annotation expects application to define schema of request body 
> and response for each endpoint to be encapsulated in a class. While Ambari 
> follows this pattern for some of the endpoint, there are many others which 
> does not do so. For The ones which do not does so, new request and response 
> classes were defined. Going forward at the completion of this epic, either 
> each resource type or each resource provider should be coupled with a 
> resource response class and a resource request class. As part of this patch, 
> each resourceprovider worked upon introduces a new method "getResponse". At 
> completion of this epic ResourceProvider interface should also declare 
> methods like "getResponse" and "getRequest" that returns response schema and 
> request schema instances for the resource API endpoints
> 6. Currently it seems that swagger has a limitation in supporting  
> "subresource locator methods". This issue is been reported to swagger 
> community and is being tracked at 
> [link|https://github.com/swagger-api/swagger-core/issues/2136]. As a result 
> of which currently as a temporary workaround, all subresources are converted 
> to root resources. Also all root resources on similar path are moved under 
> same subpackages (like userApi, groupApi and viewApi).
> 
> 
> Diffs
> -
> 
>   LICENSE.txt f05016f 
>   ambari-server/docs/api/asciidoc/definitions.adoc PRE-CREATION 
>   ambari-server/docs/api/asciidoc/overview.adoc PRE-CREATION 
>   ambari-server/docs/api/asciidoc/paths.adoc PRE-CREATION 
>   ambari-server/pom.xml f0c73e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ActiveWidgetLayoutService.java
>  40cd6e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupPrivilegeService.java
>  9c1f1a3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/GroupService.java
>  8ec0097 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/MemberService.java
>  28e53e6 
>   
>

Re: Review Request 57582: Create a prototype of ambari-server swagger integration

2017-03-14 Thread Jaimin Jetly

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57582/
---

(Updated March 14, 2017, 11:35 p.m.)

Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Robert
Nettleton, Sumit Mohanty, Sid Wagle, and Yusaku Sako.

Changes
---

Removed a extra jersey dependency from pom.xml

Bugs: AMBARI-20436
https://issues.apache.org/jira/browse/AMBARI-20436

Repository: ambari

Description
---

A separate branch is created for this work: ambari-rest-api-explorer

Diffs (updated)
-