Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-30 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review78245
---

Ship it!


Master (3ab8a9e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On March 30, 2015, 7:11 p.m., Benjamin Staffin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31101/
 ---
 
 (Updated March 30, 2015, 7:11 p.m.)
 
 
 Review request for Aurora and Jake Farrell.
 
 
 Bugs: AURORA-951
 https://issues.apache.org/jira/browse/AURORA-951
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Native Debian packaging for Aurora
 
 This uses Debian package dependencies to install gradle and thrift-compiler.  
 Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
 package easily enough using https://github.com/benley/gradle-packaging
 
 
 Diffs
 -
 
   build-support/embed_runner_in_executor.py PRE-CREATION 
   debian/aurora-doc.docs PRE-CREATION 
   debian/aurora-doc.examples PRE-CREATION 
   debian/aurora-executor.dirs PRE-CREATION 
   debian/aurora-executor.install PRE-CREATION 
   debian/aurora-executor.links PRE-CREATION 
   debian/aurora-executor.thermos.default PRE-CREATION 
   debian/aurora-executor.thermos.init PRE-CREATION 
   debian/aurora-executor.thermos.upstart PRE-CREATION 
   debian/aurora-scheduler.default PRE-CREATION 
   debian/aurora-scheduler.init PRE-CREATION 
   debian/aurora-scheduler.install PRE-CREATION 
   debian/aurora-scheduler.links PRE-CREATION 
   debian/aurora-scheduler.postinst PRE-CREATION 
   debian/aurora-scheduler.upstart PRE-CREATION 
   debian/aurora-tools.install PRE-CREATION 
   debian/aurora-tools.links PRE-CREATION 
   debian/changelog PRE-CREATION 
   debian/clusters.json PRE-CREATION 
   debian/compat PRE-CREATION 
   debian/control PRE-CREATION 
   debian/copyright PRE-CREATION 
   debian/pants.ini PRE-CREATION 
   debian/rules PRE-CREATION 
   debian/source/format PRE-CREATION 
   examples/vagrant/aurorabuild.sh 7dc9777c054a8f8a98059f263c49ba2e3e6d7207 
 
 Diff: https://reviews.apache.org/r/31101/diff/
 
 
 Testing
 ---
 
 Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
 pbuilder. Have been using debs built from this branch on a testing cluster 
 for a few months now.
 
 
 Thanks,
 
 Benjamin Staffin
 




Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-30 Thread Benjamin Staffin


 On Feb. 19, 2015, 10:48 a.m., Bill Farner wrote:
  Drive-by piecemeal review - should we create a top-level directory to house 
  these?  (Presumably a similar dir for RPMs would not be far off.)  Perhaps 
  `distributions/`?

It's appealing from a repo cleanliness perspective, but doing so complicates 
the Debian build process, as it tends to require that the debian/ directory be 
at the top level of the sources.  If we wanted to do something like, say, have 
a gradle task that generates a Debian source package, which could then be built 
using the usual Debian tools, that could be done.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review73174
---


On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31101/
 ---
 
 (Updated Feb. 16, 2015, 4:20 p.m.)
 
 
 Review request for Aurora and Jake Farrell.
 
 
 Bugs: AURORA-951
 https://issues.apache.org/jira/browse/AURORA-951
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Native Debian packaging for Aurora
 
 This uses Debian package dependencies to install gradle and thrift-compiler.  
 Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
 package easily enough using https://github.com/benley/gradle-packaging
 
 
 Diffs
 -
 
   debian/aurora-doc.docs PRE-CREATION 
   debian/aurora-doc.examples PRE-CREATION 
   debian/aurora-executor.dirs PRE-CREATION 
   debian/aurora-executor.install PRE-CREATION 
   debian/aurora-executor.links PRE-CREATION 
   debian/aurora-executor.thermos.default PRE-CREATION 
   debian/aurora-executor.thermos.init PRE-CREATION 
   debian/aurora-executor.thermos.upstart PRE-CREATION 
   debian/aurora-scheduler.default PRE-CREATION 
   debian/aurora-scheduler.init PRE-CREATION 
   debian/aurora-scheduler.install PRE-CREATION 
   debian/aurora-scheduler.links PRE-CREATION 
   debian/aurora-scheduler.postinst PRE-CREATION 
   debian/aurora-scheduler.upstart PRE-CREATION 
   debian/aurora-tools.install PRE-CREATION 
   debian/aurora-tools.links PRE-CREATION 
   debian/changelog PRE-CREATION 
   debian/clusters.json PRE-CREATION 
   debian/compat PRE-CREATION 
   debian/control PRE-CREATION 
   debian/copyright PRE-CREATION 
   debian/embed-runner-in-executor.py PRE-CREATION 
   debian/pants.ini PRE-CREATION 
   debian/rules PRE-CREATION 
   debian/source/format PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/31101/diff/
 
 
 Testing
 ---
 
 Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
 pbuilder. Have been using debs built from this branch on a testing cluster 
 for a few months now.
 
 
 Thanks,
 
 Benjamin Staffin
 




Re: Review Request 32641: Dropping incubator from Aurora.

2015-03-30 Thread Jake Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32641/#review78280
---



DISCLAIMER
https://reviews.apache.org/r/32641/#comment126800

whole disclaimer file should be removed


- Jake Farrell


On March 30, 2015, 9:08 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/32641/
 ---
 
 (Updated March 30, 2015, 9:08 p.m.)
 
 
 Review request for Aurora and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dropping any reference to `incubator` now that we've graduated.
 
 
 Diffs
 -
 
   CONTRIBUTING.md 48d3dde7b75cebe6eb76ca452f4b028a247b0a71 
   DISCLAIMER c754d88399b39bb939b16282321479ee844b043f 
   KEYS 4491fdc29c576d325fd4778348aa0e58a824f663 
   README.md 279fba3e5a10518e08cebb5192608d3a6358a042 
   build-support/release/release b07226bbc286cf5447ed229f9d55c910ade51c53 
   build-support/release/release-candidate 
 f63887f394a2a86c7ed3eb48927cfe262843dee0 
   build-support/release/verify-release-candidate 
 54b1743e0ac1c0c7457b0ed05f3dd1c1b284cf0f 
   docs/README.md b8a4cc3914f472dcd598a66db12362fc88a668fd 
   docs/committers.md 23a25c1e78450690102120ed61afb3f37b69c9c2 
   docs/cron-jobs.md 41770fd1f9db139e8778eb17add949574b95b55e 
   docs/deploying-aurora-scheduler.md 313b3225caa2586be8b7ca6051d7650d8ecbbb70 
   docs/tutorial.md 845ed8d1153205529ea681078ef6007ad6758dcc 
   docs/vagrant.md da632f05ddb04c335c20bf60860e5b492b86c764 
   examples/vagrant/provision-dev-cluster.sh 
 1f7379d3979f595af21c625d7efb6a96b63ab118 
 
 Diff: https://reviews.apache.org/r/32641/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 32641: Dropping incubator from Aurora.

2015-03-30 Thread Jake Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32641/#review78309
---



build-support/release/release-candidate
https://reviews.apache.org/r/32641/#comment126845

'-incubating' also appears in the release and release-candidate scripts and 
needs to be removed as part of this


- Jake Farrell


On March 31, 2015, 1:34 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/32641/
 ---
 
 (Updated March 31, 2015, 1:34 a.m.)
 
 
 Review request for Aurora and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dropping any reference to `incubator` now that we've graduated.
 
 
 Diffs
 -
 
   CONTRIBUTING.md 48d3dde7b75cebe6eb76ca452f4b028a247b0a71 
   DISCLAIMER c754d88399b39bb939b16282321479ee844b043f 
   KEYS 4491fdc29c576d325fd4778348aa0e58a824f663 
   README.md 279fba3e5a10518e08cebb5192608d3a6358a042 
   build-support/release/release b07226bbc286cf5447ed229f9d55c910ade51c53 
   build-support/release/release-candidate 
 f63887f394a2a86c7ed3eb48927cfe262843dee0 
   build-support/release/verify-release-candidate 
 54b1743e0ac1c0c7457b0ed05f3dd1c1b284cf0f 
   docs/README.md b8a4cc3914f472dcd598a66db12362fc88a668fd 
   docs/committers.md 23a25c1e78450690102120ed61afb3f37b69c9c2 
   docs/cron-jobs.md 41770fd1f9db139e8778eb17add949574b95b55e 
   docs/deploying-aurora-scheduler.md 313b3225caa2586be8b7ca6051d7650d8ecbbb70 
   docs/tutorial.md 845ed8d1153205529ea681078ef6007ad6758dcc 
   docs/vagrant.md da632f05ddb04c335c20bf60860e5b492b86c764 
   examples/vagrant/provision-dev-cluster.sh 
 1f7379d3979f595af21c625d7efb6a96b63ab118 
 
 Diff: https://reviews.apache.org/r/32641/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Maxim Khutornenko