Review Request 33612: Add a task store implementation that uses a relational database.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Bugs: AURORA-556 https://issues.apache.org/jira/browse/AURORA-556 Repository: aurora Description --- Add a task store implementation that uses a relational database. The meat of this review is in `DbTaskStore`, `TaskConfigManager`, and the mapper xml files. Some supporting actors include files under views/, which serve DB business objects. I suggest reviewers start by skimming `DbTaskStore` and digesting the comments in there. There are some known loose ends here, most notably being continued performance enhancements and cleanup of relations in different tables. I've included several relevant TODOs, ~all of which must be addressed before this becomes the default task store. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift 0182ecb3942cfa2d9dd21138779815f4500339be examples/vagrant/upstart/aurora-scheduler.conf 82ad42fd0a626672dca80a5362fc07d804b3e412 src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java ed1171d52655fef643330f34913c256f77300fa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3d19831ea0eb85032172b096ac87e126701aa218 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 94ce5c3499ced1b63abf19787acc21b2cd4d0c75 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java c8df88b77b9a2017c48bdc0c9a0477927ba0b179 src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 1a6c3f21d4fcb476539f588facecd8ef37332837 src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/shims/ContainerShim.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/ScheduleStatusTypeHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java 4d0c10d60037a3310226a6fd8936b84ae4135e7e src/main/java/org/apache/aurora/scheduler/storage/db/views/AssignedPort.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/ScheduledTaskWrapper.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/TaskConfigRow.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/db/views/TaskLink.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 21f7d4db821930d2c5b52648e1996aa1ef12a85c src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml f76f9a988669dab598e9d19f849018c6f55ce03e src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml PRE-CREATION src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java afb7db8eefa63b84d370877742870acdec58899c src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java e3b13407cb6875489e50cf93212845eab7aacb89 src/test/java/org/apache/aurora/scheduler/storage/db/DbTaskStoreTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java f18619a27eeb2aea8dcf01e54c23ed7d1c7d3d87 src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java bad9eb56b33c3e649c3b173e83d9c30da8f9317d Diff: https://reviews.apache.org/r/33612/diff/ Testing --- Unit tests and end-to-end tests, both using the new task store by default with this change. Thanks, Bill Farner
Re: Review Request 33608: Added a status update throughput benchmark.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 29, 2015, 12:48 a.m.) Review request for Aurora and Maxim Khutornenko. Changes --- Review feedback. Bugs: AURORA-1283 https://issues.apache.org/jira/browse/AURORA-1283 Repository: aurora Description --- In order to justify doing asynchronous batch acknowledgements and to better understand status update throughput, this introduces a benchmark. Note that this assumes that status update processing is not synchronous, so that the benchmark doesn't need to be updated for AURORA-1228. Diffs (updated) - src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeCommand.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java c54619f7cd617b48069363173dcf63b6254b4095 src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 9b8ab7c1027731f9d3f6cae77b85272ea63354d4 src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java d7d659bb13f085ff06291ef0033572f8bdf29874 Diff: https://reviews.apache.org/r/33608/diff/ Testing --- Ran the benchmarks against the existing code and some pending code I have for AURORA-1228 to demonstrate the improvement. The end to end tests are broken, appears to be unrelated to my change from what I can tell. Thanks, Ben Mahler
Re: Review Request 33608: Added a status update throughput benchmark.
On April 28, 2015, 1:30 a.m., Kevin Sweeney wrote: src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, lines 105-110 https://reviews.apache.org/r/33608/diff/1/?file=943452#file943452line105 You probably want http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/Uninterruptibles.html#sleepUninterruptibly(long,%20java.util.concurrent.TimeUnit) here. Thanks! - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81768 --- On April 28, 2015, 12:57 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 28, 2015, 12:57 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1283 https://issues.apache.org/jira/browse/AURORA-1283 Repository: aurora Description --- In order to justify doing asynchronous batch acknowledgements and to better understand status update throughput, this introduces a benchmark. Note that this assumes that status update processing is not synchronous, so that the benchmark doesn't need to be updated for AURORA-1228. Diffs - src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeCommand.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java 45de15a57baf7a2f7d437b590935714e28777f35 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java PRE-CREATION src/jmh/java/org/apache/aurora/benchmark/fakes/FakeUncaughtExceptionHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java c54619f7cd617b48069363173dcf63b6254b4095 src/main/java/org/apache/aurora/scheduler/mesos/Driver.java c7e45a89ceaa2c310feb610091eec0b04187860e src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 9b8ab7c1027731f9d3f6cae77b85272ea63354d4 src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java d7d659bb13f085ff06291ef0033572f8bdf29874 src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java da2d5df2e053e6e1b8fb08d6813dff9eac9777f8 Diff: https://reviews.apache.org/r/33608/diff/ Testing --- Ran the benchmarks against the existing code and some pending code I have for AURORA-1228 to demonstrate the improvement. The end to end tests are broken, appears to be unrelated to my change from what I can tell. Thanks, Ben Mahler
Review Request 33659: Add support for shorthand names of security realm modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1290 https://issues.apache.org/jira/browse/AURORA-1290 Repository: aurora Description --- I initially went down the path of a custom `Parser` that extended `ModuleParser`, but it turns out that doesn't work. Parsers are identified by type, and a specific parser on the `@CmdLine` arg would have to reimplement the guts of `SetParser`. As a result, i decided it was more sane to bake the shorthand list in our canonical parser of modules. Diffs - docs/security.md db2e92495661800ef513334568810f16fcf513e1 examples/vagrant/upstart/aurora-scheduler-kerberos.conf ef502b7dcc48c716f71ab5ce920084917564f6ff src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java c96821683b4569977d6d2b8ed657b0625bdd1903 Diff: https://reviews.apache.org/r/33659/diff/ Testing --- TODO(wfarner): Verify in end-to-end tests. Thanks, Bill Farner
Re: Review Request 33659: Add support for shorthand names of security realm modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/ --- (Updated April 29, 2015, 4:45 a.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1290 https://issues.apache.org/jira/browse/AURORA-1290 Repository: aurora Description --- I initially went down the path of a custom `Parser` that extended `ModuleParser`, but it turns out that doesn't work. Parsers are identified by type, and a specific parser on the `@CmdLine` arg would have to reimplement the guts of `SetParser`. As a result, i decided it was more sane to bake the shorthand list in our canonical parser of modules. Diffs - docs/security.md db2e92495661800ef513334568810f16fcf513e1 examples/vagrant/upstart/aurora-scheduler-kerberos.conf ef502b7dcc48c716f71ab5ce920084917564f6ff src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java c96821683b4569977d6d2b8ed657b0625bdd1903 Diff: https://reviews.apache.org/r/33659/diff/ Testing (updated) --- End-to-end tests pass. Thanks, Bill Farner
Re: Review Request 33537: Document Aurora security features.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81826 --- Ship it! Ship It! - Bill Farner On April 27, 2015, 11:24 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/ --- (Updated April 27, 2015, 11:24 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-817 https://issues.apache.org/jira/browse/AURORA-817 Repository: aurora Description --- SSIA A rendered version is available on github as https://github.com/kevints/aurora/blob/kts/security-docs/docs/security.md - feel free to send pull requests to fix typos, etc, from the markdown editor there and I will incorporate them into this review. Diffs - docs/deploying-aurora-scheduler.md 70d6e3d5a74cab808b327574c79f5b794aa63c28 docs/security.md PRE-CREATION Diff: https://reviews.apache.org/r/33537/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81836 --- src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java https://reviews.apache.org/r/33611/#comment132321 This benchmark is nearly identical to the role summary one. Any chance they could share common definitions? - Maxim Khutornenko On April 28, 2015, 12:57 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 12:57 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/ --- (Updated April 28, 2015, 5:24 p.m.) Review request for Aurora and Bill Farner. Changes --- Bill's comment. Repository: aurora Description --- Adjusting preemptor benchmark to test the correct functionality. ``` Benchmark (numPendingTasks) Mode Cnt Score Error Units SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 52.245 ± 3.140 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 10 thrpt 10 49.447 ± 1.606 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 100 thrpt 10 49.996 ± 2.105 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1000 thrpt 10 48.325 ± 1.710 ops/s ``` Diffs (updated) - src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java 8f43bd7068f3647fb2df22c60e913367924e2262 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 372addc6f6288ebf7c3dbf1e26902c2b62b69669 src/jmh/java/org/apache/aurora/benchmark/Tasks.java b4da057d658586f5e96c871a836011cb7a08d5d9 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java 4427115ceee0e5f3ca32462e3cfb2ad2f0ece913 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 156bac2d8cf941bcda0474ef75c7eaec74a39a3a Diff: https://reviews.apache.org/r/33458/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko
Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/#review81850 --- Ship it! Ship It! - Bill Farner On April 28, 2015, 5:24 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/ --- (Updated April 28, 2015, 5:24 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Adjusting preemptor benchmark to test the correct functionality. ``` Benchmark (numPendingTasks) Mode Cnt Score Error Units SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1 thrpt 10 52.245 ± 3.140 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 10 thrpt 10 49.447 ± 1.606 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 100 thrpt 10 49.996 ± 2.105 ops/s SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark 1000 thrpt 10 48.325 ± 1.710 ops/s ``` Diffs - src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java 8f43bd7068f3647fb2df22c60e913367924e2262 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 372addc6f6288ebf7c3dbf1e26902c2b62b69669 src/jmh/java/org/apache/aurora/benchmark/Tasks.java b4da057d658586f5e96c871a836011cb7a08d5d9 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java 4427115ceee0e5f3ca32462e3cfb2ad2f0ece913 src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java 156bac2d8cf941bcda0474ef75c7eaec74a39a3a Diff: https://reviews.apache.org/r/33458/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs (updated) - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81855 --- Ship it! Ship It! - Maxim Khutornenko On April 28, 2015, 6:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33611: Add benchmarks for fetching tasks over the API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81853 --- Ship it! Master (e9d723d) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 28, 2015, 6:16 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Add a benchmark for unscoped API task queries. This change also makes it possible to run specific benchmarks. I'm also sneaking in a cleanup - removing unnecessary parameter to `DbModule.testModule()`. Diffs - build.gradle 470d11ee0ab9f21e92d3796ab29e038cd9cce0dc src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 6ec0e14355850c8859f675d8fb2bc56fb64cb8b8 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java a4abbd8129c5e4799a07a1d0134d0232313b0eb8 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java d6ca430662d456df847ac53dbd6e5632c2c936dd src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java eae17707cc420793884519b579b79652b886a696 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2014b73a44cfdb198f738cb110399d62c396fa1f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 010e75f05449f618017cb40fd3298e7147a1d2c8 Diff: https://reviews.apache.org/r/33611/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 33537: Document Aurora security features.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/ --- (Updated April 28, 2015, 12:01 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Changes --- David and Ricardo's feedback. Bugs: AURORA-817 https://issues.apache.org/jira/browse/AURORA-817 Repository: aurora Description --- SSIA A rendered version is available on github as https://github.com/kevints/aurora/blob/kts/security-docs/docs/security.md - feel free to send pull requests to fix typos, etc, from the markdown editor there and I will incorporate them into this review. Diffs (updated) - docs/deploying-aurora-scheduler.md 70d6e3d5a74cab808b327574c79f5b794aa63c28 docs/security.md PRE-CREATION Diff: https://reviews.apache.org/r/33537/diff/ Testing --- Thanks, Kevin Sweeney
Re: Review Request 33537: Document Aurora security features.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81864 --- Ship it! Master (c760095) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On April 28, 2015, 7:01 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/ --- (Updated April 28, 2015, 7:01 p.m.) Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-817 https://issues.apache.org/jira/browse/AURORA-817 Repository: aurora Description --- SSIA A rendered version is available on github as https://github.com/kevints/aurora/blob/kts/security-docs/docs/security.md - feel free to send pull requests to fix typos, etc, from the markdown editor there and I will incorporate them into this review. Diffs - docs/deploying-aurora-scheduler.md 70d6e3d5a74cab808b327574c79f5b794aa63c28 docs/security.md PRE-CREATION Diff: https://reviews.apache.org/r/33537/diff/ Testing --- Thanks, Kevin Sweeney
