Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34373/#review84224
---

Ship it!


Master (920263b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On May 18, 2015, 9:41 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34373/
 ---
 
 (Updated May 18, 2015, 9:41 p.m.)
 
 
 Review request for Aurora, Ben Mahler and Zameer Manji.
 
 
 Bugs: AURORA-1047
 https://issues.apache.org/jira/browse/AURORA-1047
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Adding counters for the new `StatusChangeResult` values.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
 f1e5dd2d47af2570f404d198b3fbdd754174206e 
   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
 f4631c1cec4386d813d5869c28289207acf8523f 
 
 Diff: https://reviews.apache.org/r/34373/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Review Request 34372: Place api_util.py inside a `pants_library` target.

2015-05-18 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34372/
---

Review request for Aurora and Joshua Cohen.


Bugs: AURORA-1325
https://issues.apache.org/jira/browse/AURORA-1325


Repository: aurora


Description
---

This places `api_util.py` inside a `pants_library` target and has the two 
consumer targets depend on that file explicitly.


Diffs
-

  src/test/python/apache/aurora/BUILD 885e610a640f96583189d9b0f88c96efff0aa106 
  src/test/python/apache/aurora/admin/BUILD 
89cd875c4fe9af3c18b15320ae1e1adfaede11fd 
  src/test/python/apache/aurora/client/cli/BUILD 
5d922965dfbaf2eb0dc938e3d4d13f4cacb49627 

Diff: https://reviews.apache.org/r/34372/diff/


Testing
---

./pants test.pytest --no-fast --options='-v' src/test/python::


Thanks,

Zameer Manji



Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34373/
---

(Updated May 18, 2015, 10:42 p.m.)


Review request for Aurora, Ben Mahler and Zameer Manji.


Changes
---

Zameer's comments.


Bugs: AURORA-1047
https://issues.apache.org/jira/browse/AURORA-1047


Repository: aurora


Description
---

Adding counters for the new `StatusChangeResult` values.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
f1e5dd2d47af2570f404d198b3fbdd754174206e 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
f4631c1cec4386d813d5869c28289207acf8523f 

Diff: https://reviews.apache.org/r/34373/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko



Re: Review Request 34307: Upgrade pants to 0.0.32

2015-05-18 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34307/#review84212
---

Ship it!


Ship It!

- Joshua Cohen


On May 16, 2015, 1:20 a.m., Kevin Sweeney wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34307/
 ---
 
 (Updated May 16, 2015, 1:20 a.m.)
 
 
 Review request for Aurora, Joshua Cohen and Brian Wickman.
 
 
 Bugs: AURORA-1267
 https://issues.apache.org/jira/browse/AURORA-1267
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Upgrade pants to 0.0.32
 
 
 Diffs
 -
 
   .pantsversion 1fe6958562df8f355e1ca457397cb58c1c815b3f 
   build-support/pants_requirements.txt 
 0c20aaf60e6a5e069f5a28d9cbe8826f869e28f4 
   pants.ini 99648e46ca755c3c8e22d90c7b682107d8dee333 
 
 Diff: https://reviews.apache.org/r/34307/diff/
 
 
 Testing
 ---
 
 ./pants test.pytest --no-fast src/test/python:all
 ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
 
 
 Thanks,
 
 Kevin Sweeney
 




Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34373/#review84236
---

Ship it!


Master (920263b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On May 18, 2015, 10:42 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34373/
 ---
 
 (Updated May 18, 2015, 10:42 p.m.)
 
 
 Review request for Aurora, Ben Mahler and Zameer Manji.
 
 
 Bugs: AURORA-1047
 https://issues.apache.org/jira/browse/AURORA-1047
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Adding counters for the new `StatusChangeResult` values.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
 f1e5dd2d47af2570f404d198b3fbdd754174206e 
   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
 f4631c1cec4386d813d5869c28289207acf8523f 
 
 Diff: https://reviews.apache.org/r/34373/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34373/
---

Review request for Aurora, Ben Mahler and Zameer Manji.


Bugs: AURORA-1047
https://issues.apache.org/jira/browse/AURORA-1047


Repository: aurora


Description
---

Adding counters for the new `StatusChangeResult` values.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
f1e5dd2d47af2570f404d198b3fbdd754174206e 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
f4631c1cec4386d813d5869c28289207acf8523f 

Diff: https://reviews.apache.org/r/34373/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko