Re: Review Request 34733: Fixing default TaskReconciler initial delay.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/#review85438 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java https://reviews.apache.org/r/34733/#comment136996 Move this validation to the constructor so that it will halt injector creation. - Kevin Sweeney On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/ --- (Updated May 27, 2015, 1:52 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1339 https://issues.apache.org/jira/browse/AURORA-1339 Repository: aurora Description --- The current default value leads to overflow. Fixed the value and added validation. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 23f5f648d3404495e3e9e878592c2638621ce89a src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java f56ffd2d7c584042b5c47fa4dba83f35433762f5 Diff: https://reviews.apache.org/r/34733/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 34733: Fixing default TaskReconciler initial delay.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/ --- (Updated May 27, 2015, 9:22 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Changes --- Kevin's comments. Bugs: AURORA-1339 https://issues.apache.org/jira/browse/AURORA-1339 Repository: aurora Description --- The current default value leads to overflow. Fixed the value and added validation. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 23f5f648d3404495e3e9e878592c2638621ce89a src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java f56ffd2d7c584042b5c47fa4dba83f35433762f5 Diff: https://reviews.apache.org/r/34733/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 34733: Fixing default TaskReconciler initial delay.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/#review85441 --- Ship it! Ship It! - Zameer Manji On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/ --- (Updated May 27, 2015, 1:52 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1339 https://issues.apache.org/jira/browse/AURORA-1339 Repository: aurora Description --- The current default value leads to overflow. Fixed the value and added validation. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 23f5f648d3404495e3e9e878592c2638621ce89a src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java f56ffd2d7c584042b5c47fa4dba83f35433762f5 Diff: https://reviews.apache.org/r/34733/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 34733: Fixing default TaskReconciler initial delay.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/#review85447 --- Ship it! Master (5724099) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On May 27, 2015, 9:22 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/ --- (Updated May 27, 2015, 9:22 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1339 https://issues.apache.org/jira/browse/AURORA-1339 Repository: aurora Description --- The current default value leads to overflow. Fixed the value and added validation. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 23f5f648d3404495e3e9e878592c2638621ce89a src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java f56ffd2d7c584042b5c47fa4dba83f35433762f5 Diff: https://reviews.apache.org/r/34733/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Review Request 34733: Fixing default TaskReconciler initial delay.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1339 https://issues.apache.org/jira/browse/AURORA-1339 Repository: aurora Description --- The current default value leads to overflow. Fixed the value and added validation. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 23f5f648d3404495e3e9e878592c2638621ce89a src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java f56ffd2d7c584042b5c47fa4dba83f35433762f5 Diff: https://reviews.apache.org/r/34733/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 34733: Fixing default TaskReconciler initial delay.
On May 27, 2015, 8:58 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java, line 82 https://reviews.apache.org/r/34733/diff/1/?file=973043#file973043line82 Move this validation to the constructor so that it will halt injector creation. Thanks, came to the same conclusion when trying to simplify tests. Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/#review85438 --- On May 27, 2015, 8:52 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/ --- (Updated May 27, 2015, 8:52 p.m.) Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1339 https://issues.apache.org/jira/browse/AURORA-1339 Repository: aurora Description --- The current default value leads to overflow. Fixed the value and added validation. Diffs - src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 23f5f648d3404495e3e9e878592c2638621ce89a src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java f56ffd2d7c584042b5c47fa4dba83f35433762f5 Diff: https://reviews.apache.org/r/34733/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34501/#review85449 --- Ship it! Ship It! - Kevin Sweeney On May 22, 2015, 5:31 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34501/ --- (Updated May 22, 2015, 5:31 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1322 https://issues.apache.org/jira/browse/AURORA-1322 Repository: aurora Description --- Allowing TemporaryStorage to use command line controlled task store. Diffs - src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java 03dd5d99b269a1add709504b21fc197fdef9e18c src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java f361caa6f4e3b28f4a1e4d57f1989a6aa6fe258e src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 23c0c1e73a183be748199610ddf03e5d654fef74 src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 436d3841b9361df4db98a2217e61abb95e6e6bab src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java fe8e3f8f164732769fa0ae50a62e89c8aa77e9a5 src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 177d720b59ba601d59aada9650aba799babb9a73 src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 999d5e893897dc24659ca4a240ad3d4615cac0e5 Diff: https://reviews.apache.org/r/34501/diff/ Testing --- ./gradlew -Pq build Manual restore from backup in Vagrant. Thanks, Maxim Khutornenko
Re: Review Request 34739: Adding ChainedPathDetector into the GC executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34739/#review85479 --- Ship it! Master (5724099) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On May 28, 2015, 12:03 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34739/ --- (Updated May 28, 2015, 12:03 a.m.) Review request for Aurora, Brian Wickman and Zameer Manji. Bugs: AURORA-1025 https://issues.apache.org/jira/browse/AURORA-1025 Repository: aurora Description --- This has escaped the previous set of changes in AURORA-1025 to enable checkpoint dual-reading. Extracted a method to faciliated unit testing as patching twitter.common.app is not fun. Diffs - src/main/python/apache/aurora/executor/bin/BUILD 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201 src/main/python/apache/aurora/executor/bin/gc_executor_main.py 9e6508493abda4fe47213c485073d62ac81a99e4 src/test/python/apache/aurora/executor/bin/BUILD 918a76933a640ea5bed369a49a0b762e1e88 src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py d6998783eea0cb880f2ab1274e6c74104e3bd13c Diff: https://reviews.apache.org/r/34739/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 34484: Daemonize all deadline calls in aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/#review85482 --- Ship it! Ship It! - Joe Smith On May 26, 2015, 1:43 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/ --- (Updated May 26, 2015, 1:43 p.m.) Review request for Aurora, Joe Smith and Vinod Kone. Bugs: AURORA-698 https://issues.apache.org/jira/browse/AURORA-698 Repository: aurora Description --- Daemonize all deadline calls in aurora executor. If we do not daemonize, it's possible for the aurora executor to send TASK_KILLED and then block indefinitely on shutdown. This way the aurora executor process will at least exit, allow the cgroup to tear down all active processes. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py df0df0cba3269a137a370e2b4096fd61fd3af258 Diff: https://reviews.apache.org/r/34484/diff/ Testing --- ./pants test src/test/python/apache/aurora/executor:: Thanks, Brian Wickman
