Re: Review Request 34484: Daemonize all deadline calls in aurora executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/#review86035 --- Ship it! Ship It! - Vinod Kone On May 26, 2015, 8:43 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34484/ --- (Updated May 26, 2015, 8:43 p.m.) Review request for Aurora, Joe Smith and Vinod Kone. Bugs: AURORA-698 https://issues.apache.org/jira/browse/AURORA-698 Repository: aurora Description --- Daemonize all deadline calls in aurora executor. If we do not daemonize, it's possible for the aurora executor to send TASK_KILLED and then block indefinitely on shutdown. This way the aurora executor process will at least exit, allow the cgroup to tear down all active processes. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py df0df0cba3269a137a370e2b4096fd61fd3af258 Diff: https://reviews.apache.org/r/34484/diff/ Testing --- ./pants test src/test/python/apache/aurora/executor:: Thanks, Brian Wickman
Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/#review86028
---
Ship it!
Master (827b9ab) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On June 1, 2015, 6:05 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/
---
(Updated June 1, 2015, 6:05 p.m.)
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-739
https://issues.apache.org/jira/browse/AURORA-739
Repository: aurora
Description
---
It's possible to define nested refs that can cause the executor to stack
trace, e.g.
{{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor.
Diffs
-
src/main/python/apache/aurora/config/__init__.py
dd2f89014a3da730364b14e01c499ac0f2c288c1
src/main/python/apache/aurora/config/schema/base.py
a87524a8b3ad5aa0e337e0a0028cecb85865b4e6
src/main/python/apache/aurora/config/thrift.py
810febb637d168b07c4aea77984e1d1451a39af2
src/main/python/apache/aurora/executor/common/task_info.py
d110faf08135d94d9af95ad74613950c56248c09
src/main/python/apache/thermos/config/dsl.py
0663a9ad8ae194b63ce6d77dabfe65564e2d26dd
src/main/python/apache/thermos/config/loader.py
d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e
src/test/python/apache/aurora/client/test_config.py
c56779712b91f621261358aa7ebd6c4fc65446a0
src/test/python/apache/aurora/config/test_thrift.py
654c0b5ae82c98db163c7a44301ff6b23e19b211
src/test/python/apache/aurora/executor/common/test_task_info.py
102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8
Diff: https://reviews.apache.org/r/34300/diff/
Testing
---
Added some regression tests.
Thanks,
Brian Wickman
Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/
---
(Updated June 1, 2015, 6:05 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
---
Fix checkstyle violation.
Bugs: AURORA-739
https://issues.apache.org/jira/browse/AURORA-739
Repository: aurora
Description
---
It's possible to define nested refs that can cause the executor to stack trace,
e.g.
{{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor.
Diffs (updated)
-
src/main/python/apache/aurora/config/__init__.py
dd2f89014a3da730364b14e01c499ac0f2c288c1
src/main/python/apache/aurora/config/schema/base.py
a87524a8b3ad5aa0e337e0a0028cecb85865b4e6
src/main/python/apache/aurora/config/thrift.py
810febb637d168b07c4aea77984e1d1451a39af2
src/main/python/apache/aurora/executor/common/task_info.py
d110faf08135d94d9af95ad74613950c56248c09
src/main/python/apache/thermos/config/dsl.py
0663a9ad8ae194b63ce6d77dabfe65564e2d26dd
src/main/python/apache/thermos/config/loader.py
d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e
src/test/python/apache/aurora/client/test_config.py
c56779712b91f621261358aa7ebd6c4fc65446a0
src/test/python/apache/aurora/config/test_thrift.py
654c0b5ae82c98db163c7a44301ff6b23e19b211
src/test/python/apache/aurora/executor/common/test_task_info.py
102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8
Diff: https://reviews.apache.org/r/34300/diff/
Testing
---
Added some regression tests.
Thanks,
Brian Wickman
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review86104 --- @ReviewBot retry - Bhuvan Arumugam On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1237 https://issues.apache.org/jira/browse/AURORA-1237 Repository: aurora Description --- The tasks inside container should run as user that match aurora-role, if --nosetuid option is not passed for executor. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1237 Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 Diff: https://reviews.apache.org/r/34568/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 34568: run tasks as user that match aurora-role
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review86109 --- Master (73ceeb2) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1237 https://issues.apache.org/jira/browse/AURORA-1237 Repository: aurora Description --- The tasks inside container should run as user that match aurora-role, if --nosetuid option is not passed for executor. Testing Done: ./pants test.pytest --no-fast --options='--verbose' src/test/python:: Bugs closed: AURORA-1237 Diffs - src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 Diff: https://reviews.apache.org/r/34568/diff/ Testing --- Thanks, Bhuvan Arumugam
Re: Review Request 34827: Moving checkpoint root into the executor sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34827/#review86121 --- Ship it! Ship It! - Joe Smith On May 29, 2015, 12:54 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34827/ --- (Updated May 29, 2015, 12:54 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Bugs: AURORA-1337 https://issues.apache.org/jira/browse/AURORA-1337 Repository: aurora Description --- Checkpoints are now written into the executor sandbox instead of the default global location. Diffs - examples/vagrant/aurorabuild.sh 1a76e4f8fcfe79049e331211fad5ef617ba9a6e0 src/main/python/apache/aurora/executor/bin/BUILD 6ef669d8e3d7f1f4cb00dcc11175eedccb66a689 src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 3174e1f9635c47b2f3d789c39b1bc177db25a7e5 src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168e422b5d9703bbef8101333ed20581a3cd src/test/python/apache/aurora/executor/bin/BUILD b1bcfac16cb4675d66bdd0074f389f8c4978dffa src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py e89a01e4e76b0be35e0a65d7d3a06c3ba594de39 Diff: https://reviews.apache.org/r/34827/diff/ Testing --- ./pants test.pytest --no-fast src/test/python:all ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko
