Review Request 40922: AURORA-1548 | (Thermos) Add ability to forward process output to stdout

2015-12-03 Thread Martin Hrabovcin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40922/
---

Review request for Aurora.


Repository: aurora


Description
---

AURORA-1548 | (Thermos) Add ability to forward process output to stdout


Diffs
-

  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
0d02dc17da4d496560ea572659e281c736170da2 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
14e8b4bd539d2c295582d93fa01b5613345c1758 
  src/main/python/apache/thermos/core/process.py 
fe95cb3be01b47616596bd78cb9a919b2e8bd978 
  src/main/python/apache/thermos/core/runner.py 
f949f279a071c6464b026749f51afc776102f2aa 
  src/main/python/apache/thermos/runner/thermos_runner.py 
bd8cf7f4cda54b6be72dad64f9446eedeb132211 
  src/test/python/apache/thermos/core/test_process.py 
5e6ad2fca616b840299bd9ca1614c82c5c39e992 

Diff: https://reviews.apache.org/r/40922/diff/


Testing
---


Thanks,

Martin Hrabovcin

Re: Review Request 40922: AURORA-1548 | (Thermos) Add ability to forward process output to stdout

2015-12-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40922/#review108841
---


Master (676ee5b) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-12.1.1/virtualenv_embedded/deactivate.bat
virtualenv-12.1.1/virtualenv_embedded/distutils-init.py
virtualenv-12.1.1/virtualenv_embedded/distutils.cfg
virtualenv-12.1.1/virtualenv_embedded/site.py
virtualenv-12.1.1/virtualenv_support/
virtualenv-12.1.1/virtualenv_support/__init__.py
virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3-none-any.whl
virtualenv-12.1.1/virtualenv_support/setuptools-15.0-py2.py3-none-any.whl
+ touch virtualenv-12.1.1/BOOTSTRAPPED
+ popd
~/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.1.1/virtualenv.py
 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip...done.
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. For more information, see 
https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
You are using pip version 6.1.1, however version 7.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting isort==4.0.0
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. For more information, see 
https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
ERROR: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/test_process.py
 Imports are incorrectly sorted.
--- 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/test_process.py:before
  2015-12-03 16:36:13.407581
+++ 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/core/test_process.py:after
   2015-12-03 16:41:01.178345
@@ -16,9 +16,9 @@
 import os
 import pwd
 import random
+import StringIO
+import sys
 import time
-import sys
-import StringIO
 
 import mock
 import pytest


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 3, 2015, 4:41 p.m., Martin Hrabovcin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40922/
> ---
> 
> (Updated Dec. 3, 2015, 4:41 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-1548 | (Thermos) Add ability to forward process output to stdout
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 0d02dc17da4d496560ea572659e281c736170da2 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 14e8b4bd539d2c295582d93fa01b5613345c1758 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/core/runner.py 
> f949f279a071c6464b026749f51afc776102f2aa 
>   src/main/python/apache/thermos/runner/thermos_runner.py 
> bd8cf7f4cda54b6be72dad64f9446eedeb132211 
>   src/test/python/apache/thermos/core/test_process.py 
> 5e6ad2fca616b840299bd9ca1614c82c5c39e992 
> 
> Diff: https://reviews.apache.org/r/40922/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Hrabovcin
> 
>

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-03 Thread Steve Niemitz 


> On Dec. 3, 2015, 12:36 a.m., Maxim Khutornenko wrote:
> > 3rdparty/python/BUILD, line 14
> > 
> >
> > Am I reading this as revving up mesos native version in Aurora? If so, 
> > we should also update build.gradle and possibly update 
> > make-mesos-native-egg script. Previous effort as a reference: 
> > https://reviews.apache.org/r/37379
> 
> Bill Farner wrote:
> You're right, Maxim.  I think it's safe to say this patch is still in PoC 
> stage, as it can't land until some changes go into mesos.  I think Steve is 
> not expecting ship-its just yet.

Correct, I'll ping when I'm ready for more eyes on it.


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40889/#review108758
---


On Dec. 2, 2015, 11:57 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40889/
> ---
> 
> (Updated Dec. 2, 2015, 11:57 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changed mesos native lib to use mesos.executor instead
> 
> Without any context this doesnt really make any sense.
> 
> I've created a seperate mesos native lib that only contains a minimal set of 
> code needed to run the ExecutorDriver.  This library has very few 
> requirements, making it a much better option for running in docker 
> containers, as well as allowing a thermos_executor.pex built on one linux 
> distro to run on most others.
> 
> The mesos side of this is here: 
> https://github.com/tellapart/mesos/commit/46bedd5db73b535a0e4efe94730500b6da2ec7d8
> and I'll be opening a RB request on the mesos side soon.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 
>   src/main/python/apache/aurora/executor/BUILD 
> 0be65fc7c180d15f5a94bef268652ef7b868dcf7 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> b3e8bf1e924999306e0b8a1314273b22c51028e7 
> 
> Diff: https://reviews.apache.org/r/40889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>