Re: Review Request 44607: aurora-cli on Mac OS X

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44607/#review122878
---


Ship it!




Master (fbfeca3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2016, 5 a.m., se choi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44607/
> ---
> 
> (Updated March 10, 2016, 5 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> aurora-cli on Mac OS X
> 
> 
> Diffs
> -
> 
>   docs/installing.md c4e25c579a1b6a567d8d616296fdc2c21c2009f3 
> 
> Diff: https://reviews.apache.org/r/44607/diff/
> 
> 
> Testing
> ---
> 
> aurora-cli on Mac OS X install document.
> 
> 
> Thanks,
> 
> se choi
> 
>

Review Request 44607: aurora-cli on Mac OS X

[se choi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44607/
---

Review request for Aurora.


Repository: aurora


Description
---

aurora-cli on Mac OS X


Diffs
-

  docs/installing.md c4e25c579a1b6a567d8d616296fdc2c21c2009f3 

Diff: https://reviews.apache.org/r/44607/diff/


Testing
---

aurora-cli on Mac OS X install document.


Thanks,

se choi

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122861
---


Ship it!




Master (fbfeca3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> ---
> 
> (Updated March 10, 2016, 12:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ported from 
> https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44493/#review122855
---


Ship it!





src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java (line 
161)


no big deal, but it would be nice if the line break style was consistent 
with above.


- Bill Farner


On March 7, 2016, 6:21 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44493/
> ---
> 
> (Updated March 7, 2016, 6:21 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Bugs: AURORA-1630
> https://issues.apache.org/jira/browse/AURORA-1630
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moved HistoryPruner Runnable handler into AsyncUtil to reuse in updater.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 80dc35ece876d46c8b94540cd6ab19092854867e 
>   src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 
> 22753b4579dfdaa1fceea2e095ba7063143959c6 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  48d7e2afb795a743ca9ca3e125a02195e45f1f67 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
> c0472d732874dba5cd3534b07301432fed04fcca 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> b39e38883a0e57210596d5c71ec5c90234837296 
> 
> Diff: https://reviews.apache.org/r/44493/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122850
---



@ReviewBot retry please...

- Maxim Khutornenko


On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> ---
> 
> (Updated March 10, 2016, 12:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ported from 
> https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122849
---



Master (fbfeca3) is red with this patch.
  ./build-support/jenkins/build.sh

   proxy_driver = ProxyDriver()
   with temporary_dir() as checkpoint_root:
 te = AuroraExecutor(
 >   
runner_provider=make_provider(checkpoint_root),
 
sandbox_provider=DefaultTestSandboxProvider())
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
 pex_location=thermos_runner_path(),
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 build = True
 
 def thermos_runner_path(build=True):
   if not build:
 return getattr(thermos_runner_path, 'value', 
None)
 
   if not hasattr(thermos_runner_path, 'value'):
 pex_dir = safe_mkdtemp()
 >   assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
   
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
 E   assert 1 == 0
 E+  where 1 = (['./pants', '--pants-distdir=/tmp/user/10021/tmpjRfL5e', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
 E+where  = subprocess.call
 
 
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
 -- Captured stderr call --
 Traceback (most recent call last):
   File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", 
line 7, in 
 from pants.bin.pants_exe import main
 ImportError: No module named pants.bin.pants_exe
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  16 failed, 638 passed, 5 skipped, 1 warnings, 8 
error in 211.93 seconds 
 
FAILURE


01:11:52 04:15   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> ---
> 
> (Updated March 10, 2016, 12:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ported from 
> https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122847
---



@ReviewBot retry

- Maxim Khutornenko


On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> ---
> 
> (Updated March 10, 2016, 12:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ported from 
> https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122843
---



Master (fbfeca3) is red with this patch.
  ./build-support/jenkins/build.sh

 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 E0310 00:42:41.608119 27933 thermos_task_runner.py:234] 
Could not quitquitquit runner: Cannot take control of a task in terminal state.
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 661 passed, 5 skipped, 1 warnings in 
341.24 seconds 
 
FAILURE


00:44:02 06:28   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> ---
> 
> (Updated March 10, 2016, 12:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ported from 
> https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Steve Niemitz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/#review122841
---


Ship it!




Oh neat, we're doing this?  We've been running this patch for 6+ months now 
with no issues.

- Steve Niemitz


On March 10, 2016, 12:25 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44602/
> ---
> 
> (Updated March 10, 2016, 12:25 a.m.)
> 
> 
> Review request for Aurora, Steve Niemitz and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ported from 
> https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.
> 
> 
> Diffs
> -
> 
>   NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
>   docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  6300e5f83b039a9798e7093f6b46c84566e507e0 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  d2789d0eaaeba99fcff3412f1abdd29a09d6514d 
> 
> Diff: https://reviews.apache.org/r/44602/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44493/#review122840
---



Ping Bill, John

- Maxim Khutornenko


On March 8, 2016, 2:21 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44493/
> ---
> 
> (Updated March 8, 2016, 2:21 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Bugs: AURORA-1630
> https://issues.apache.org/jira/browse/AURORA-1630
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moved HistoryPruner Runnable handler into AsyncUtil to reuse in updater.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 
> 80dc35ece876d46c8b94540cd6ab19092854867e 
>   src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 
> 22753b4579dfdaa1fceea2e095ba7063143959c6 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  48d7e2afb795a743ca9ca3e125a02195e45f1f67 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
> c0472d732874dba5cd3534b07301432fed04fcca 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> b39e38883a0e57210596d5c71ec5c90234837296 
> 
> Diff: https://reviews.apache.org/r/44493/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 44602: Adding non-role-exclusive dedicated constraint support

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44602/
---

Review request for Aurora, Steve Niemitz and Bill Farner.


Repository: aurora


Description
---

Ported from 
https://github.com/tellapart/aurora/commit/76f978c76cc1377e19e602f7e0d050f7ce353562.


Diffs
-

  NEWS 0aa7f5e192ef17b95471e34a5408491999bcdeeb 
  docs/deploying-aurora-scheduler.md 10952efc2725b031e9a8de35ba9f4e5c20ed99d9 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 6300e5f83b039a9798e7093f6b46c84566e507e0 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 d2789d0eaaeba99fcff3412f1abdd29a09d6514d 

Diff: https://reviews.apache.org/r/44602/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 44589: Add latest design documents

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44589/#review122801
---


Ship it!




Ship It!

- Joshua Cohen


On March 9, 2016, 8:08 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44589/
> ---
> 
> (Updated March 9, 2016, 8:08 p.m.)
> 
> 
> Review request for Aurora, Amol Deshmukh and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add latest design documents
> 
> 
> Diffs
> -
> 
>   docs/design-documents.md 71d6c4c4b90767f47493017c4ac3f263465f9679 
> 
> Diff: https://reviews.apache.org/r/44589/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 43333: Upgrade to zookeeper 3.4.8.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4/#review122799
---



This upgrade was performed in https://reviews.apache.org/r/44519/
Marking as discarded.

- John Sirois


On Feb. 8, 2016, 2:57 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4/
> ---
> 
> (Updated Feb. 8, 2016, 2:57 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Raul Gutierrez Segales, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This corrects a critical deadlock bug in 3.4.7 on shutdown of the server
> which we use in unit tests.
> 
> The full release notes are here:
>   
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12326517
> 
>  build.gradle | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> 
> Diffs
> -
> 
>   build.gradle 5b9e0152bfe3fe1f304fa839cfc4cec646819c2e 
> 
> Diff: https://reviews.apache.org/r/4/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 44589: Add latest design documents

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44589/#review122795
---


Ship it!




Master (bde0daa) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 9, 2016, 8:08 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44589/
> ---
> 
> (Updated March 9, 2016, 8:08 p.m.)
> 
> 
> Review request for Aurora, Amol Deshmukh and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add latest design documents
> 
> 
> Diffs
> -
> 
>   docs/design-documents.md 71d6c4c4b90767f47493017c4ac3f263465f9679 
> 
> Diff: https://reviews.apache.org/r/44589/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Review Request 44589: Add latest design documents

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44589/
---

Review request for Aurora, Amol Deshmukh and Joshua Cohen.


Repository: aurora


Description
---

Add latest design documents


Diffs
-

  docs/design-documents.md 71d6c4c4b90767f47493017c4ac3f263465f9679 

Diff: https://reviews.apache.org/r/44589/diff/


Testing
---


Thanks,

Stephan Erb

Re: Review Request 44517: Upgrade pants to 0.0.75.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122786
---


Ship it!




Ship It!

- Joshua Cohen


On March 8, 2016, 5:45 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44517/
> ---
> 
> (Updated March 8, 2016, 5:45 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only Aurora-impacting change is faster pythonstyle checks.
> See the CHANGELOG here: http://pantsbuild.github.io/changelog.html.
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini 97bc327a794ef383ac2245c869ba32d3160a9a26 
> 
> Diff: https://reviews.apache.org/r/44517/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 44517: Upgrade pants to 0.0.75.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122784
---


Ship it!




Ship It!

- Stephan Erb


On March 8, 2016, 6:45 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44517/
> ---
> 
> (Updated March 8, 2016, 6:45 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The only Aurora-impacting change is faster pythonstyle checks.
> See the CHANGELOG here: http://pantsbuild.github.io/changelog.html.
> 
>  pants.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -
> 
>   pants.ini 97bc327a794ef383ac2245c869ba32d3160a9a26 
> 
> Diff: https://reviews.apache.org/r/44517/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 44527: Fixup rpm builder and tester.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44527/#review122751
---



Jake - I'm going to proceed with this to get out an rpm RC.

- John Sirois


On March 8, 2016, 2:25 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44527/
> ---
> 
> (Updated March 8, 2016, 2:25 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-1568
> https://issues.apache.org/jira/browse/AURORA-1568
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> This updates the mesos version from 0.23.0 to 0.25.0 and fixes
> up the vagrant test environment and instructions.
> 
>  specs/rpm/aurora.spec  |  2 +-
>  test/rpm/centos-7/README.md| 31 ++-
>  test/rpm/centos-7/provision.sh |  4 ++--
>  3 files changed, 21 insertions(+), 16 deletions(-)
> 
> 
> Diffs
> -
> 
>   specs/rpm/aurora.spec 291226da27285bf9f7c225ba4fd337691c6e8181 
>   test/rpm/centos-7/README.md 684a3b56fba90bf679736b75c191b49ca0ded8b3 
>   test/rpm/centos-7/provision.sh 7148979a94edf8c8b07290b612329a41456289b3 
> 
> Diff: https://reviews.apache.org/r/44527/diff/
> 
> 
> Testing
> ---
> 
> Fixed test instructions can be viewed here:
>   
> https://github.com/jsirois/aurora-packaging/tree/AURORA-1568/rpm/fix-deps-and-test/test/rpm/centos-7
>   
> I used these to successfully install and use aurora in the vagrant
> test environment after building a fresh set of rpms with the tweaked
> spec mesos dep.
> 
> NB: This change does attempt to address 
> https://issues.apache.org/jira/browse/AURORA-1394
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 44530: Introduce a helper script for preparing RCs.

[John Sirois]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44530/
---

(Updated March 9, 2016, 10:33 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

A cut at basic release prep instructions.

 README.md   |  37 +
 docs/images/bintray-publish.png | Bin 0 -> 204309 bytes
 docs/images/bintray-upload.png  | Bin 0 -> 145853 bytes
 3 files changed, 37 insertions(+)


Bugs: AURORA-1568
https://issues.apache.org/jira/browse/AURORA-1568


Repository: aurora-packaging


Description
---

This is a bit piecemeal at the moment, but automates preparation of RC
artifacts created with `./build-artifact` for upload to bintray.

Either basic docs or more glue scripting is still needed to make the
process as smooth and automated as the main aurora release.

 build-support/release/release-candidate | 64 
++
 1 file changed, 64 insertions(+)


Diffs (updated)
-

  README.md a31f66cb80234c7af58673c98db7539afd6266a9 
  build-support/release/release-candidate PRE-CREATION 
  docs/images/bintray-publish.png PRE-CREATION 
  docs/images/bintray-upload.png PRE-CREATION 

Diff: https://reviews.apache.org/r/44530/diff/


Testing
---

Used this to prepare the deb RCs that are out for a vote as well as the rpm RC 
not quite out for a vote yet.

Looks like:
```
$ ./build-support/release/release-candidate
Signing artifacts for centos-7...
Created archive for centos-7 artifacts at 
/home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/upload.tar.
Signing artifacts for debian-jessie...
Created archive for debian-jessie artifacts at 
/home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-debian-jessie/upload.tar.
Signing artifacts for ubuntu-trusty...
Created archive for ubuntu-trusty artifacts at 
/home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-ubuntu-trusty/upload.tar.
All artifacts prepared for upload to bintray.

$ tar -tf 
/home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-debian-jessie/upload.tar
 | sort
debian-jessie/
debian-jessie/aurora-doc_0.12.0_all.deb
debian-jessie/aurora-doc_0.12.0_all.deb.asc
debian-jessie/aurora-doc_0.12.0_all.deb.md5
debian-jessie/aurora-doc_0.12.0_all.deb.sha
debian-jessie/aurora-executor_0.12.0_amd64.deb
debian-jessie/aurora-executor_0.12.0_amd64.deb.asc
debian-jessie/aurora-executor_0.12.0_amd64.deb.md5
debian-jessie/aurora-executor_0.12.0_amd64.deb.sha
debian-jessie/aurora-scheduler_0.12.0_amd64.deb
debian-jessie/aurora-scheduler_0.12.0_amd64.deb.asc
debian-jessie/aurora-scheduler_0.12.0_amd64.deb.md5
debian-jessie/aurora-scheduler_0.12.0_amd64.deb.sha
debian-jessie/aurora-tools_0.12.0_amd64.deb
debian-jessie/aurora-tools_0.12.0_amd64.deb.asc
debian-jessie/aurora-tools_0.12.0_amd64.deb.md5
debian-jessie/aurora-tools_0.12.0_amd64.deb.sha

$ tar -tf 
/home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/upload.tar
 | sort
centos-7/
centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm
centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm
centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm
centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm
centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha

$ tar -tf 
/home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-ubuntu-trusty/upload.tar
 | sort
ubuntu-trusty/
ubuntu-trusty/aurora-doc_0.12.0_all.deb
ubuntu-trusty/aurora-doc_0.12.0_all.deb.asc
ubuntu-trusty/aurora-doc_0.12.0_all.deb.md5
ubuntu-trusty/aurora-doc_0.12.0_all.deb.sha
ubuntu-trusty/aurora-executor_0.12.0_amd64.deb
ubuntu-trusty/aurora-executor_0.12.0_amd64.deb.asc
ubuntu-trusty/aurora-executor_0.12.0_amd64.deb.md5
ubuntu-trusty/aurora-executor_0.12.0_amd64.deb.sha
ubuntu-trusty/aurora-scheduler_0.12.0_amd64.deb
ubuntu-trusty/aurora-scheduler_0.12.0_amd64.deb.asc
ubuntu-trusty/aurora-scheduler_0.12.0_amd64.deb.md5
ubuntu-trusty/aurora-scheduler_0.12.0_amd64.deb.sha
ubunt

Re: Review Request 44530: Introduce a helper script for preparing RCs.

[John Sirois]

> On March 8, 2016, 3:09 p.m., Bill Farner wrote:
> > Can you also add a `RELEASE.md` in the root with the commands to run?  
> > That'll at least offer pointers to the appropriate scripts.

Added a section to the README, viewable here: 
https://github.com/jsirois/aurora-packaging/tree/AURORA-1568/bintray-helper#creating-a-release-candidate
I'll circle back to make the release-candidate script more robust and perhaps 
flesh out the process a bit more (email template, automate upload).


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44530/#review122605
---


On March 8, 2016, 2:54 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44530/
> ---
> 
> (Updated March 8, 2016, 2:54 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1568
> https://issues.apache.org/jira/browse/AURORA-1568
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> This is a bit piecemeal at the moment, but automates preparation of RC
> artifacts created with `./build-artifact` for upload to bintray.
> 
> Either basic docs or more glue scripting is still needed to make the
> process as smooth and automated as the main aurora release.
> 
>  build-support/release/release-candidate | 64 
> ++
>  1 file changed, 64 insertions(+)
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44530/diff/
> 
> 
> Testing
> ---
> 
> Used this to prepare the deb RCs that are out for a vote as well as the rpm 
> RC not quite out for a vote yet.
> 
> Looks like:
> ```
> $ ./build-support/release/release-candidate
> Signing artifacts for centos-7...
> Created archive for centos-7 artifacts at 
> /home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/upload.tar.
> Signing artifacts for debian-jessie...
> Created archive for debian-jessie artifacts at 
> /home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-debian-jessie/upload.tar.
> Signing artifacts for ubuntu-trusty...
> Created archive for ubuntu-trusty artifacts at 
> /home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-ubuntu-trusty/upload.tar.
> All artifacts prepared for upload to bintray.
> 
> $ tar -tf 
> /home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-debian-jessie/upload.tar
>  | sort
> debian-jessie/
> debian-jessie/aurora-doc_0.12.0_all.deb
> debian-jessie/aurora-doc_0.12.0_all.deb.asc
> debian-jessie/aurora-doc_0.12.0_all.deb.md5
> debian-jessie/aurora-doc_0.12.0_all.deb.sha
> debian-jessie/aurora-executor_0.12.0_amd64.deb
> debian-jessie/aurora-executor_0.12.0_amd64.deb.asc
> debian-jessie/aurora-executor_0.12.0_amd64.deb.md5
> debian-jessie/aurora-executor_0.12.0_amd64.deb.sha
> debian-jessie/aurora-scheduler_0.12.0_amd64.deb
> debian-jessie/aurora-scheduler_0.12.0_amd64.deb.asc
> debian-jessie/aurora-scheduler_0.12.0_amd64.deb.md5
> debian-jessie/aurora-scheduler_0.12.0_amd64.deb.sha
> debian-jessie/aurora-tools_0.12.0_amd64.deb
> debian-jessie/aurora-tools_0.12.0_amd64.deb.asc
> debian-jessie/aurora-tools_0.12.0_amd64.deb.md5
> debian-jessie/aurora-tools_0.12.0_amd64.deb.sha
> 
> $ tar -tf 
> /home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/upload.tar
>  | sort
> centos-7/
> centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm
> centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
> centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
> centos-7/aurora-executor-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
> centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm
> centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
> centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
> centos-7/aurora-scheduler-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
> centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm
> centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
> centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
> centos-7/aurora-scheduler-debuginfo-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
> centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm
> centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm.asc
> centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm.md5
> centos-7/aurora-tools-0.12.0-1.el7.centos.aurora.x86_64.rpm.sha
> 
> $ tar -tf 
> /home/jsirois/dev/aurora/jsirois-aurora-packaging/artifacts/aurora-ubuntu-trusty/upload.tar
>  | sort
> ubuntu-trusty/
> ubuntu-trusty/aurora-doc_0.12.0

Re: Review Request 43936: Correct url for source0

[John Sirois]

> On March 8, 2016, 3:19 p.m., John Sirois wrote:
> > LGTM - The Source0 and setup do check out with out new rel/[version] 
> > tagging structure.
> > 
> > I'll wait on both your feedback and Jake's before submitting tomorrow.

I'm going to go ahead and move forward with the submit.  Thanks David!


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43936/#review122607
---


On March 8, 2016, 3:08 p.m., David Keijser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43936/
> ---
> 
> (Updated March 8, 2016, 3:08 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Correct url for source0
> 
> Trying to build aurora by running spectool and then rpmbuild fails because 
> the url used does not match the release tags on github.
> 
> 
> Diffs
> -
> 
>   specs/rpm/aurora.spec 291226da27285bf9f7c225ba4fd337691c6e8181 
> 
> Diff: https://reviews.apache.org/r/43936/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Keijser
> 
>