Re: Review Request 66074: Refactor ClusterState to more appropriate package, move binding to StateModule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66074/#review199334 --- Ship it! Ship It! - Stephan Erb On March 14, 2018, 11:07 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66074/ > --- > > (Updated March 14, 2018, 11:07 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Santhosh > Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > Browsing through the code and I noticed that if preemption is turned off, the > `/state` endpoint will not work since `ClusterState` is not bound. > > I moved `ClusterState` and `ClusterStateImpl` to a more suitable package, and > bind `ClusterState` in `StateModule` no matter what. > > > Diffs > - > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 54b6ed9d474065bab1da7512a42fc38264b892bc > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 37374dcf3471d5eadf543d93e5a6a3e07a389dc1 > src/main/java/org/apache/aurora/scheduler/http/State.java > 6d1b400c286a63dffba85fd5c14cb76f6f3a45a4 > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java > ce3bc7e6da3f86625c690e26c28ccef67ed9021a > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java > 5574e9ba916513e8f5dc3ef78ddeb084330c > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 056e4668490accab9b70e0634393580e40514f86 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > 4de5ef8be76ead1970b27d91eee90198858e53c8 > src/main/java/org/apache/aurora/scheduler/state/StateModule.java > 76c327758f88ad23942ea3b388830cb4a31728dd > src/test/java/org/apache/aurora/scheduler/http/StateTest.java > 0685d6ee6148d0a22c07e18a808f2816299b10d3 > > src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java > 881bb20feaa83797831828a3cdd7a2f507621387 > > src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java > 35e9348e6ab0c14e6ae20af4076358d7e12681c7 > > > Diff: https://reviews.apache.org/r/66074/diff/1/ > > > Testing > --- > > Manually tested state endpoint returns jobs when preemptor is both on and off. > > > Thanks, > > Jordan Ly > >
Re: Review Request 65769: Remove unused module in RecoveryTool, move TaskTestUtil to test folder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65769/#review199333 --- Is this RecoveryTool just a prototype or used for real? If it is the preferred backup way now, we have to update https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md. - Stephan Erb On Feb. 23, 2018, 7:04 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65769/ > --- > > (Updated Feb. 23, 2018, 7:04 p.m.) > > > Review request for Aurora, David McLaughlin, Renan DelValle, and Bill Farner. > > > Repository: aurora > > > Description > --- > > Removing an unused `TierModule` from `RecoveryTool`. > > Additionally, resolved an old TODO and moved `TaskTestUtil` to the test > folder. It seems that the old version of JMH could not see test sources but > https://github.com/melix/jmh-gradle-plugin/issues/31 and the upgrade to 0.4.4 > seems to fix that. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2b61c273860a33472890fc22e06b3c53d2086999 > > src/main/java/org/apache/aurora/scheduler/storage/durability/RecoveryTool.java > 7cb4c52bc6e890f48a8bc9fe21c54cea38644808 > > > Diff: https://reviews.apache.org/r/65769/diff/1/ > > > Testing > --- > > `./gradlew test` > `./gradlew jmh` > > end-to-end tests pass. > > > Thanks, > > Jordan Ly > >
Re: Review Request 63685: RFC: Use new scheduler UI as landing page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63685/#review199332 --- I won't be able to work in this in the near future. Closing. - Stephan Erb On Nov. 8, 2017, 11:32 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63685/ > --- > > (Updated Nov. 8, 2017, 11:32 p.m.) > > > Review request for Aurora, David McLaughlin and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > Is this something the community would be interested in? > > Known issues in this minimal viable prototype: > > * I did not manage to convince Jetty to perform the redirecting. Using the > HTML feels hacky but works. > * An operator will have difficulties to navigate to /admin of a non-leading > instance. In particular if there is no leader at all. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 0f8528c3403b5f51f082aa54c16358f7568f439a > src/main/resources/scheduler/assets/index.html > 533091395547a6b067dbf5f53e42a13a560971da > ui/src/main/js/components/Navigation.js > 50881a9914cee2812807624cd28f24fa64207296 > ui/src/main/js/index.js 9f94d4bd6f649d74bdd9c3aa99783e01cae25d93 > ui/src/main/js/pages/Admin.js PRE-CREATION > > > Diff: https://reviews.apache.org/r/63685/diff/1/ > > > Testing > --- > > > File Attachments > > > Screen Shot 2017-11-08 at 23.18.06.png > > https://reviews.apache.org/media/uploaded/files/2017/11/08/80ae2c5f-e431-4f86-8811-13bfe6a8627b__Screen_Shot_2017-11-08_at_23.18.06.png > Screen Shot 2017-11-08 at 23.18.20.png > > https://reviews.apache.org/media/uploaded/files/2017/11/08/9fb0f2e0-49c9-427f-8b84-d3d1fc057a59__Screen_Shot_2017-11-08_at_23.18.20.png > > > Thanks, > > Stephan Erb > >
Re: Review Request 65896: Persist scheduler/observer logs to /var/log/aurora/[FILE].log
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65896/#review199331 --- Ship it! Ship It! - Renan DelValle On March 14, 2018, 3:23 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65896/ > --- > > (Updated March 14, 2018, 3:23 p.m.) > > > Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > Persist scheduler/observer logs to /var/log/aurora/[FILE].log > > `journalctl -u aurora-[executor|scheduler]` still works. > > I also added a TODO to rename the `aurora-executor.service` file to > `aurora-observer.service` since it is not correctly named. I think this might > require a modification to the base image which I may do at a later point in > time. > > > Diffs > - > > docs/getting-started/vagrant.md 73d0affaa6cc9a31781dce54b4c05a1686d35b01 > examples/vagrant/aurorabuild.sh 5eb1822a7940abcf58903d5c60a1f004cf2439c9 > examples/vagrant/provision-dev-cluster.sh > 4a023907b57a6912936533c6d45a25fc929bbab8 > examples/vagrant/systemd/aurora-executor.service > 5a1a9082ecd7b1367ec677d760a5c375b6db9076 > examples/vagrant/systemd/aurora-scheduler-kerberos.service > 1c2cfc4c8edd3f66675d843ef8a6518e2916bc63 > examples/vagrant/systemd/aurora-scheduler.service > 524cbb3b028b45157bcc082756f48a531c52ced3 > > > Diff: https://reviews.apache.org/r/65896/diff/2/ > > > Testing > --- > > Manually tested that logs were created on vagrant. > > ``` > vagrant@aurora:~$ ls /var/log/aurora/ > observer.log scheduler.log > vagrant@aurora:~$ tail -3 /var/log/aurora/scheduler.log > Mar 5 00:44:13 aurora aurora-scheduler[3609]: I0305 00:44:13.441440 3722 > scheduler.cpp:676] Enqueuing event HEARTBEAT received from > http://192.168.33.7:5050/master/api/v1/scheduler > Mar 5 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 > scheduler.cpp:676] Enqueuing event HEARTBEAT received from > http://192.168.33.7:5050/master/api/v1/scheduler > Mar 5 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 > scheduler.cpp:676] Enqueuing event HEARTBEAT received from > http://192.168.33.7:5050/master/api/v1/scheduler > vagrant@aurora:~$ journalctl -u aurora-scheduler | tail -3 > Mar 05 00:44:28 aurora aurora-scheduler[3609]: I0305 00:44:28.442432 3727 > scheduler.cpp:676] Enqueuing event HEARTBEAT received from > http://192.168.33.7:5050/master/api/v1/scheduler > Mar 05 00:44:43 aurora aurora-scheduler[3609]: I0305 00:44:43.444105 3726 > scheduler.cpp:676] Enqueuing event HEARTBEAT received from > http://192.168.33.7:5050/master/api/v1/scheduler > Mar 05 00:44:58 aurora aurora-scheduler[3609]: I0305 00:44:58.444711 3729 > scheduler.cpp:676] Enqueuing event HEARTBEAT received from > http://192.168.33.7:5050/master/api/v1/scheduler > vagrant@aurora:~$ tail -3 /var/log/aurora/observer.log > Mar 5 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting > up (using CherryPyServer())... > Mar 5 00:36:18 aurora aurora-observer[3129]: Listening on > http://192.168.33.7:1338/ > Mar 5 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit. > vagrant@aurora:~$ journalctl -u aurora-executor | tail -3 > Mar 05 00:36:18 aurora aurora-observer[3129]: Bottle v0.11.6 server starting > up (using CherryPyServer())... > Mar 05 00:36:18 aurora aurora-observer[3129]: Listening on > http://192.168.33.7:1338/ > Mar 05 00:36:18 aurora aurora-observer[3129]: Hit Ctrl-C to quit. > ``` > > > Thanks, > > Jordan Ly > >
