Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Renan DelValle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/
---

(Updated May 4, 2018, 10:46 a.m.)


Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.


Changes
---

Removing comments from Vagrantfile.


Repository: aurora


Description
---

Changing Vagrant requirements to latest version for launching our local dev box.

Needed since we depend on the Vagrant Cloud instead of Atlas now.


Diffs (updated)
-

  Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 


Diff: https://reviews.apache.org/r/66922/diff/2/

Changes: https://reviews.apache.org/r/66922/diff/1-2/


Testing
---

Ran vagrant box with latest Vagrant version (2.0.4).


Thanks,

Renan DelValle



Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Renan DelValle


> On May 2, 2018, 11:41 p.m., Jordan Ly wrote:
> > Vagrantfile
> > Lines 20-21 (original), 20-21 (patched)
> > 
> >
> > Should we need to update (or remove) this comment?

Good catch, I'll get rid of this.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202343
---


On May 2, 2018, 3:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 3:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>



Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Santhosh Kumar Shanmugham

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202453
---


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On May 2, 2018, 3:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 3:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>