Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-07-01 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/
---

(Updated July 1, 2015, 6:03 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

Rebase again.


Repository: aurora


Description
---

Note that this does not remove _all_ type witnesses, as the compiler still 
relies on them in several cases.  For example, chained method calls cannot 
compile without them:

```
ImmutableSet.Stringbuilder()
  .add('a')
  .add('b')
  .build()
```


Diffs (updated)
-

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
308bbd92943e331179bc5fad1f3fa0febba5ed1c 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
d3e1295db9b933b5ab60d6446dfea453c6051795 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
3413b0a480073f39bc01a60bc93b211660d9e278 
  src/main/java/org/apache/aurora/GuiceUtils.java 
5d0af1ebdccd0d0782f0fbc53d046a338c450167 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
9e1f35a12205065f2f0cc783a49e14384bc4d50a 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
26093ef35f18eda5b05fe2a9351ac80fbeca3dc8 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
538cb755a5f80b9e70e3069205f219558053da9b 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
968aca6053a722dbaec6c5832c09e0816ae069ae 
  src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
f0dea48b3df69dedf620a55573731ed9451369c3 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
f5a18338748da7c443b2fd2ec3a72adf75e7387f 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java 
cd016af5621be76190ead81921096aae837b59c0 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
 c1114a411c32c25785adc93e594ee8e291025969 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
  src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 a1ca93edc8cb5d24a21ae98deafd13a9751031e5 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
df180a4f9dff75a04ae104462c219444ef605d9a 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
770672c85c06aaf4356b3b3580428b0323edb9d3 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
  src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
bd74f892dde65e957f125a17979ee6c582b3043f 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
ecba276f1882162d9578e0829b2139040876c7d0 
  src/main/java/org/apache/aurora/scheduler/http/Cron.java 
fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
fcf5e4419b9908281858e591c916c586c707c6cd 
  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java 
b224983159c4979800fa384bbb082adc7b330b4c 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
 7425b93f476ca1228a233a56363136f9e586a5e5 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
5bf4d9a659942c65290442fdcd4749bda046bfd8 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
7453680af5a518012f9779f82d0349e897c04994 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
a6d7ab748aeb050f93f817e3b084b03d34a58d9d 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
1b8733bff69aef5a7db6bc7d137932a69717275a 
  src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
48d0ff667cf97002795b97c235b9e9e34f8e5018 
  src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
e5c0322007c8d9424b96016c9075790c69cf2cf5 
  src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
97f9ee81ed18a961e6df4916d9ede1d89f90ded1 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
b87157562045247f8f0aa43f04ae590a6c09a7e1 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
41e144b9c08500867bab8854770f778e6a211b19

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-07-01 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review90078
---


This patch does not apply cleanly on master (1024a85), do you need to rebase?

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On July 1, 2015, 5:51 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35932/
 ---
 
 (Updated July 1, 2015, 5:51 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Note that this does not remove _all_ type witnesses, as the compiler still 
 relies on them in several cases.  For example, chained method calls cannot 
 compile without them:
 
 ```
 ImmutableSet.Stringbuilder()
   .add('a')
   .add('b')
   .build()
 ```
 
 
 Diffs
 -
 
   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
 308bbd92943e331179bc5fad1f3fa0febba5ed1c 
   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
 d3e1295db9b933b5ab60d6446dfea453c6051795 
   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
 3413b0a480073f39bc01a60bc93b211660d9e278 
   src/main/java/org/apache/aurora/GuiceUtils.java 
 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 26093ef35f18eda5b05fe2a9351ac80fbeca3dc8 
   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
 538cb755a5f80b9e70e3069205f219558053da9b 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 968aca6053a722dbaec6c5832c09e0816ae069ae 
   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
 f0dea48b3df69dedf620a55573731ed9451369c3 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
 f5a18338748da7c443b2fd2ec3a72adf75e7387f 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
  cd016af5621be76190ead81921096aae837b59c0 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
  c1114a411c32c25785adc93e594ee8e291025969 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
   
 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
  a1ca93edc8cb5d24a21ae98deafd13a9751031e5 
   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
 df180a4f9dff75a04ae104462c219444ef605d9a 
   
 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
 770672c85c06aaf4356b3b3580428b0323edb9d3 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
 bd74f892dde65e957f125a17979ee6c582b3043f 
   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
 ecba276f1882162d9578e0829b2139040876c7d0 
   src/main/java/org/apache/aurora/scheduler/http/Cron.java 
 fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
 fcf5e4419b9908281858e591c916c586c707c6cd 
   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
 d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
  1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
  b224983159c4979800fa384bbb082adc7b330b4c 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
  7425b93f476ca1228a233a56363136f9e586a5e5 
   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
 e934f570e4a728470408970485abe0809487d312 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
 5bf4d9a659942c65290442fdcd4749bda046bfd8 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 7453680af5a518012f9779f82d0349e897c04994 
   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
 a6d7ab748aeb050f93f817e3b084b03d34a58d9d 
   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
 1b8733bff69aef5a7db6bc7d137932a69717275a 
   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-07-01 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/
---

(Updated July 1, 2015, 5:51 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

Another rebase race on master.


Repository: aurora


Description
---

Note that this does not remove _all_ type witnesses, as the compiler still 
relies on them in several cases.  For example, chained method calls cannot 
compile without them:

```
ImmutableSet.Stringbuilder()
  .add('a')
  .add('b')
  .build()
```


Diffs (updated)
-

  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
308bbd92943e331179bc5fad1f3fa0febba5ed1c 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
d3e1295db9b933b5ab60d6446dfea453c6051795 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
3413b0a480073f39bc01a60bc93b211660d9e278 
  src/main/java/org/apache/aurora/GuiceUtils.java 
5d0af1ebdccd0d0782f0fbc53d046a338c450167 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
9e1f35a12205065f2f0cc783a49e14384bc4d50a 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
26093ef35f18eda5b05fe2a9351ac80fbeca3dc8 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
538cb755a5f80b9e70e3069205f219558053da9b 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
968aca6053a722dbaec6c5832c09e0816ae069ae 
  src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
f0dea48b3df69dedf620a55573731ed9451369c3 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
f5a18338748da7c443b2fd2ec3a72adf75e7387f 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java 
cd016af5621be76190ead81921096aae837b59c0 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
 c1114a411c32c25785adc93e594ee8e291025969 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
  src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 a1ca93edc8cb5d24a21ae98deafd13a9751031e5 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
df180a4f9dff75a04ae104462c219444ef605d9a 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
770672c85c06aaf4356b3b3580428b0323edb9d3 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
  src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
bd74f892dde65e957f125a17979ee6c582b3043f 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
ecba276f1882162d9578e0829b2139040876c7d0 
  src/main/java/org/apache/aurora/scheduler/http/Cron.java 
fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
  src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
fcf5e4419b9908281858e591c916c586c707c6cd 
  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
 1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java 
b224983159c4979800fa384bbb082adc7b330b4c 
  
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
 7425b93f476ca1228a233a56363136f9e586a5e5 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
5bf4d9a659942c65290442fdcd4749bda046bfd8 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
7453680af5a518012f9779f82d0349e897c04994 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
a6d7ab748aeb050f93f817e3b084b03d34a58d9d 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
1b8733bff69aef5a7db6bc7d137932a69717275a 
  src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
48d0ff667cf97002795b97c235b9e9e34f8e5018 
  src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
e5c0322007c8d9424b96016c9075790c69cf2cf5 
  src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
97f9ee81ed18a961e6df4916d9ede1d89f90ded1 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
b87157562045247f8f0aa43f04ae590a6c09a7e1 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
41e144b9c08500867bab8854770f778e6a211b19

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-29 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review89742
---

Ship it!



src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java (lines 71 - 
76)
https://reviews.apache.org/r/35932/#comment142518

These should fit to line now.



src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 
(line 52)
https://reviews.apache.org/r/35932/#comment142519

same here



src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionVictimFilterTest.java
 (line 361)
https://reviews.apache.org/r/35932/#comment142520

Pull to the previous line.



src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
 (line 181)
https://reviews.apache.org/r/35932/#comment142521

same here



src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java (line 
309)
https://reviews.apache.org/r/35932/#comment142522

same



src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java (line 
333)
https://reviews.apache.org/r/35932/#comment142523

same



src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
 (line 76)
https://reviews.apache.org/r/35932/#comment142524

same


- Maxim Khutornenko


On June 26, 2015, 5:50 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35932/
 ---
 
 (Updated June 26, 2015, 5:50 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Note that this does not remove _all_ type witnesses, as the compiler still 
 relies on them in several cases.  For example, chained method calls cannot 
 compile without them:
 
 ```
 ImmutableSet.Stringbuilder()
   .add('a')
   .add('b')
   .build()
 ```
 
 
 Diffs
 -
 
   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
 308bbd92943e331179bc5fad1f3fa0febba5ed1c 
   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
 d3e1295db9b933b5ab60d6446dfea453c6051795 
   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
 3413b0a480073f39bc01a60bc93b211660d9e278 
   src/main/java/org/apache/aurora/GuiceUtils.java 
 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 26093ef35f18eda5b05fe2a9351ac80fbeca3dc8 
   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
 538cb755a5f80b9e70e3069205f219558053da9b 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 968aca6053a722dbaec6c5832c09e0816ae069ae 
   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
 f0dea48b3df69dedf620a55573731ed9451369c3 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
 f5a18338748da7c443b2fd2ec3a72adf75e7387f 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
  cd016af5621be76190ead81921096aae837b59c0 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
  c1114a411c32c25785adc93e594ee8e291025969 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
   
 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
  b77b0ebbf303778e528b16ff3db1aa4e76f1 
   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
 df180a4f9dff75a04ae104462c219444ef605d9a 
   
 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
 770672c85c06aaf4356b3b3580428b0323edb9d3 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
 bd74f892dde65e957f125a17979ee6c582b3043f 
   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
 ecba276f1882162d9578e0829b2139040876c7d0 
   src/main/java/org/apache/aurora/scheduler/http/Cron.java 
 fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
 fcf5e4419b9908281858e591c916c586c707c6cd 
   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
 d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review89531
---

Ship it!


Ship It!

- Kevin Sweeney


On June 26, 2015, 10:50 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35932/
 ---
 
 (Updated June 26, 2015, 10:50 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Note that this does not remove _all_ type witnesses, as the compiler still 
 relies on them in several cases.  For example, chained method calls cannot 
 compile without them:
 
 ```
 ImmutableSet.Stringbuilder()
   .add('a')
   .add('b')
   .build()
 ```
 
 
 Diffs
 -
 
   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
 308bbd92943e331179bc5fad1f3fa0febba5ed1c 
   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
 d3e1295db9b933b5ab60d6446dfea453c6051795 
   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
 3413b0a480073f39bc01a60bc93b211660d9e278 
   src/main/java/org/apache/aurora/GuiceUtils.java 
 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 26093ef35f18eda5b05fe2a9351ac80fbeca3dc8 
   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
 538cb755a5f80b9e70e3069205f219558053da9b 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 968aca6053a722dbaec6c5832c09e0816ae069ae 
   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
 f0dea48b3df69dedf620a55573731ed9451369c3 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
 f5a18338748da7c443b2fd2ec3a72adf75e7387f 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
  cd016af5621be76190ead81921096aae837b59c0 
   
 src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
  c1114a411c32c25785adc93e594ee8e291025969 
   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
   
 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
  b77b0ebbf303778e528b16ff3db1aa4e76f1 
   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
 df180a4f9dff75a04ae104462c219444ef605d9a 
   
 src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
 770672c85c06aaf4356b3b3580428b0323edb9d3 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
 bd74f892dde65e957f125a17979ee6c582b3043f 
   src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
 ecba276f1882162d9578e0829b2139040876c7d0 
   src/main/java/org/apache/aurora/scheduler/http/Cron.java 
 fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java 
 fcf5e4419b9908281858e591c916c586c707c6cd 
   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
 d735cbc4169dbf3f7fb8dd1c13bf683ddcce548c 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
  1e9b1c3b6e256fd994e94ad30d9340d12ce15f99 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
  b224983159c4979800fa384bbb082adc7b330b4c 
   
 src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
  7425b93f476ca1228a233a56363136f9e586a5e5 
   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
 e934f570e4a728470408970485abe0809487d312 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
 5bf4d9a659942c65290442fdcd4749bda046bfd8 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 7453680af5a518012f9779f82d0349e897c04994 
   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
 a6d7ab748aeb050f93f817e3b084b03d34a58d9d 
   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
 1b8733bff69aef5a7db6bc7d137932a69717275a 
   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
 48d0ff667cf97002795b97c235b9e9e34f8e5018 
   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
 e5c0322007c8d9424b96016c9075790c69cf2cf5