Re: Review Request 36329: Add a stat that tracks uncaught exceptions in pubsub event handlers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36329/ --- (Updated July 8, 2015, 8:57 p.m.) Review request for Aurora and Zameer Manji. Changes --- Fixes unexpected brittle tests that surfaced. Sorry for pulling the trigger early on the first draft. Repository: aurora Description --- Prior to this patch, it's relatively easy for exceptions thrown by pubsub handlers to land quietly in the log, and with generic messages (which don't include a stack trace). This gives us a stat to alert on, and improves our ability to hone in on an issue when it arises. This includes some binding cleanup to make plumbing easier, resulting in less code overall. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 82d479e142afe798cd84135b981075035d9ca6dc src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 0faee9279bc39b7e71f3d4cd12f6b21dcc678356 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 9afd7dfd4b283bd35785003983030865e2311731 src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java c6295e58a93966fb126be20bbdc6a18dc2cdca56 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java cd85b80b742af094b0ba0dd4932da29e7487e846 Diff: https://reviews.apache.org/r/36329/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36329: Add a stat that tracks uncaught exceptions in pubsub event handlers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36329/#review90995 --- Ship it! Master (144cf60) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On July 8, 2015, 8:57 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36329/ --- (Updated July 8, 2015, 8:57 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Prior to this patch, it's relatively easy for exceptions thrown by pubsub handlers to land quietly in the log, and with generic messages (which don't include a stack trace). This gives us a stat to alert on, and improves our ability to hone in on an issue when it arises. This includes some binding cleanup to make plumbing easier, resulting in less code overall. Diffs - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 82d479e142afe798cd84135b981075035d9ca6dc src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 0faee9279bc39b7e71f3d4cd12f6b21dcc678356 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 9afd7dfd4b283bd35785003983030865e2311731 src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java c6295e58a93966fb126be20bbdc6a18dc2cdca56 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java cd85b80b742af094b0ba0dd4932da29e7487e846 Diff: https://reviews.apache.org/r/36329/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 36329: Add a stat that tracks uncaught exceptions in pubsub event handlers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36329/#review91039 --- Ship it! Ship It! - Zameer Manji On July 8, 2015, 1:57 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36329/ --- (Updated July 8, 2015, 1:57 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Prior to this patch, it's relatively easy for exceptions thrown by pubsub handlers to land quietly in the log, and with generic messages (which don't include a stack trace). This gives us a stat to alert on, and improves our ability to hone in on an issue when it arises. This includes some binding cleanup to make plumbing easier, resulting in less code overall. Diffs - src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 82d479e142afe798cd84135b981075035d9ca6dc src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 0faee9279bc39b7e71f3d4cd12f6b21dcc678356 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 9afd7dfd4b283bd35785003983030865e2311731 src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java c6295e58a93966fb126be20bbdc6a18dc2cdca56 src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java cd85b80b742af094b0ba0dd4932da29e7487e846 Diff: https://reviews.apache.org/r/36329/diff/ Testing --- Thanks, Bill Farner
