Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39784/#review105958
---
Master (3ea1b26) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.common.test_cluster_option
. SUCCESS[0m[32m
src.test.python.apache.aurora.common.test_clusters
. SUCCESS[0m[32m
src.test.python.apache.aurora.common.test_http_signaler
. SUCCESS[0m[32m
src.test.python.apache.aurora.common.test_pex_version
. SUCCESS[0m[32m
src.test.python.apache.aurora.common.test_shellify
. SUCCESS[0m[32m
src.test.python.apache.aurora.common.test_transport
. SUCCESS[0m[32m
src.test.python.apache.aurora.executor.common.path_detector
. SUCCESS[0m[32m
src.test.python.apache.aurora.executor.common.task_info
. SUCCESS[0m[32m
src.test.python.apache.thermos.cli.common
. SUCCESS[0m[32m
src.test.python.apache.thermos.cli.main
. SUCCESS[0m[32m
src.test.python.apache.thermos.cli.commands.commands
. SUCCESS[0m[32m
src.test.python.apache.thermos.common.test_pathspec
. SUCCESS[0m[32m
src.test.python.apache.thermos.core.test_runner_integration
. SUCCESS[0m[32m
src.test.python.apache.thermos.monitoring.test_disk
. SUCCESS[0m[1m
collecting 1 items[0m[1m
collecting 1 items[0m[1m
collecting 1 items[0m[1m
collected 1 items
[0m
src/test/python/apache/aurora/client/cli/test_version.py::TestClientVersionFlag::test_version_flag
[31mFAILED[0m
FAILURES
TestClientVersionFlag.test_version_flag _
self =
[1mdef test_version_flag(self):[0m
[1m with patch('sys.stderr', new_callable=StringIO)
as mock_stderr:[0m
[1mwith pytest.raises(SystemExit):[0m
[1m
AuroraCommandLine().execute(['--version'])[0m
[1m[0m
[1m> assert mock_stderr.getvalue() ==
cli_version[0m
[1m[31mE AssertionError: assert 'Unknown\n' ==
'Unknown'[0m
[1m[31mE Unknown[0m
src/test/python/apache/aurora/client/cli/test_version.py:32: AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.cli.version.xml
[1m[31m 1 failed in 0.63 seconds
[0m
FAILURE
21:25:11 02:39 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 10, 2015, 9:10 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39784/
> ---
>
> (Updated Nov. 10, 2015, 9:10 p.m.)
>
>
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-1499
> https://issues.apache.org/jira/browse/AURORA-1499
>
>
> Repository: aurora
>
>
> Description
> ---
>
> See the changelog here:
> https://pypi.python.org/pypi/pantsbuild.pants/0.0.57
>
> This also brings Aurora up to pex 1.1.0 and switches to the pants
> setup script; an equivalent to gradlew. Of note, the script is checked
> in with chmod 555, its not intended to be edited.
>
> Although pants now includes checkstyle built in, conversion to use it is
> left for follow-on work.
>
> Also adapt make-pycharm-virtualenv which previously relied on the local
> bootstrapping of pants - now hidden away by the pants setup script.
>
> .pantsversion | 1 -
> 3rdparty/python/requirements.txt
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- (Updated Nov. 10, 2015, 2:50 p.m.) Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Changes --- Fall back to old-style resources for now. src/main/python/apache/aurora/client/cli/BUILD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Bugs: AURORA-1499 https://issues.apache.org/jira/browse/AURORA-1499 Repository: aurora Description --- See the changelog here: https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 This also brings Aurora up to pex 1.1.0 and switches to the pants setup script; an equivalent to gradlew. Of note, the script is checked in with chmod 555, its not intended to be edited. Although pants now includes checkstyle built in, conversion to use it is left for follow-on work. Also adapt make-pycharm-virtualenv which previously relied on the local bootstrapping of pants - now hidden away by the pants setup script. .pantsversion | 1 - 3rdparty/python/requirements.txt | 2 +- BUILD | 25 - BUILD.tools| 19 -- build-support/jenkins/build.sh | 2 +- build-support/pants_requirements.txt | 30 --- build-support/python/make-pycharm-virtualenv | 11 +- build-support/python/update-pants-requirements | 34 - pants | 102 +++--- pants.ini | 63 ++- src/main/python/apache/aurora/tools/BUILD | 2 +- src/main/python/apache/thermos/observer/BUILD | 2 +- 12 files changed, 114 insertions(+), 179 deletions(-) Diffs (updated) - .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 api/src/main/thrift/org/apache/aurora/gen/BUILD 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 api/src/main/thrift/org/apache/thermos/BUILD 6b13949aceb830b962a7098ae65462151119d752 build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 build-support/pants_requirements.txt 6eefa7175f7bda7bea23466936e451113a2d86f7 build-support/python/make-pycharm-virtualenv d7bd41835bcd9a8fe62ea522a177bfa7830a897b build-support/python/update-pants-requirements 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 src/main/python/apache/aurora/client/BUILD 8424237eb56abe38c4d0871557dc929250de1ba4 src/main/python/apache/aurora/tools/BUILD e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 src/main/python/apache/thermos/observer/BUILD d7eedabc0930711530b45ac98a1159e69d1a0c00 src/main/resources/apache/aurora/client/cli/.auroraversion src/main/resources/apache/aurora/client/cli/BUILD 7c77d10823753af56db01a3b0db49868451d6435 Diff: https://reviews.apache.org/r/39784/diff/ Testing --- Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` Also generated a pycharm project via: `./build-support/python/make-pycharm-virtualenv` Confirmed library source linking worked as did running unit tests via the IDE. Also grepped for pants commands in the repo, found `binary` and `setup-py` and confirmed these worked. Thanks, John Sirois
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105969 --- Master (3ea1b26) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 10, 2015, 9:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 9:50 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105973 --- Ship it! Thanks again John! - Joe Smith On Nov. 10, 2015, 1:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 1:50 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105990 --- Ship it! Thanks John! - Zameer Manji On Nov. 10, 2015, 2:58 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 2:58 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .auroraversion PRE-CREATION > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > build-support/release/release 209045767a18d263814700dfb5f9912447cc1205 > build-support/release/release-candidate > 1caa56bfaee67dec6c70b50923b18900f88ced75 > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/client/cli/.auroraversion PRE-CREATION > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > 67ff1ac747879c27d7db8a84994ffd254e830a24 > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105977 --- Moving the `.auroraversion` file breaks the `build-support/release/release` and `build-support/release/release-candidate` scripts. John, I think updating those scripts to point to the new location is fine, but I am unsure on the side effects. Bill can you comment if there be any ill side effects from doing that? Overall this change LGTM, but I am holding back a ship because as it stands it will break the release scripts we have. - Zameer Manji On Nov. 10, 2015, 1:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 1:50 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105991 --- Master (3ea1b26) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 10, 2015, 10:58 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 10:58 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .auroraversion PRE-CREATION > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > build-support/release/release 209045767a18d263814700dfb5f9912447cc1205 > build-support/release/release-candidate > 1caa56bfaee67dec6c70b50923b18900f88ced75 > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/client/cli/.auroraversion PRE-CREATION > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > 67ff1ac747879c27d7db8a84994ffd254e830a24 > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/ --- (Updated Nov. 10, 2015, 3:58 p.m.) Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Changes --- Fixup `.auroraversion` location in release scripts. Make the root `.auroraversion` the canonical home to simplify the release scripts and isolate the knowledge of the secondary path to the aurora cli. .auroraversion | 2 +- build-support/release/release | 3 +-- build-support/release/release-candidate | 5 ++--- src/main/python/apache/aurora/client/cli/.auroraversion | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) Bugs: AURORA-1499 https://issues.apache.org/jira/browse/AURORA-1499 Repository: aurora Description --- See the changelog here: https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 This also brings Aurora up to pex 1.1.0 and switches to the pants setup script; an equivalent to gradlew. Of note, the script is checked in with chmod 555, its not intended to be edited. Although pants now includes checkstyle built in, conversion to use it is left for follow-on work. Also adapt make-pycharm-virtualenv which previously relied on the local bootstrapping of pants - now hidden away by the pants setup script. .pantsversion | 1 - 3rdparty/python/requirements.txt | 2 +- BUILD | 25 - BUILD.tools| 19 -- build-support/jenkins/build.sh | 2 +- build-support/pants_requirements.txt | 30 --- build-support/python/make-pycharm-virtualenv | 11 +- build-support/python/update-pants-requirements | 34 - pants | 102 +++--- pants.ini | 63 ++- src/main/python/apache/aurora/tools/BUILD | 2 +- src/main/python/apache/thermos/observer/BUILD | 2 +- 12 files changed, 114 insertions(+), 179 deletions(-) Diffs (updated) - .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 .auroraversion PRE-CREATION .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 api/src/main/thrift/org/apache/aurora/gen/BUILD 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 api/src/main/thrift/org/apache/thermos/BUILD 6b13949aceb830b962a7098ae65462151119d752 build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 build-support/pants_requirements.txt 6eefa7175f7bda7bea23466936e451113a2d86f7 build-support/python/make-pycharm-virtualenv d7bd41835bcd9a8fe62ea522a177bfa7830a897b build-support/python/update-pants-requirements 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec build-support/release/release 209045767a18d263814700dfb5f9912447cc1205 build-support/release/release-candidate 1caa56bfaee67dec6c70b50923b18900f88ced75 pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 src/main/python/apache/aurora/client/BUILD 8424237eb56abe38c4d0871557dc929250de1ba4 src/main/python/apache/aurora/client/cli/.auroraversion PRE-CREATION src/main/python/apache/aurora/tools/BUILD e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 src/main/python/apache/thermos/observer/BUILD d7eedabc0930711530b45ac98a1159e69d1a0c00 src/main/resources/apache/aurora/client/cli/.auroraversion 67ff1ac747879c27d7db8a84994ffd254e830a24 src/main/resources/apache/aurora/client/cli/BUILD 7c77d10823753af56db01a3b0db49868451d6435 Diff: https://reviews.apache.org/r/39784/diff/ Testing --- Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` Also generated a pycharm project via: `./build-support/python/make-pycharm-virtualenv` Confirmed library source linking worked as did running unit tests via the IDE. Also grepped for pants commands in the repo, found `binary` and `setup-py` and confirmed these worked. Thanks, John Sirois
Re: Review Request 39784: Upgrade Aurora to pants 0.0.57.
> On Nov. 10, 2015, 3:26 p.m., Zameer Manji wrote: > > Moving the `.auroraversion` file breaks the `build-support/release/release` > > and `build-support/release/release-candidate` scripts. John, I think > > updating those scripts to point to the new location is fine, but I am > > unsure on the side effects. Bill can you comment if there be any ill side > > effects from doing that? > > > > Overall this change LGTM, but I am holding back a ship because as it stands > > it will break the release scripts we have. Those scripts use the root `.auroraversion` symlink IIUC and I updated that to point to the new location. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105977 --- On Nov. 10, 2015, 2:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > --- > > (Updated Nov. 10, 2015, 2:50 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > --- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 - > BUILD.tools| 19 -- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --- > build-support/python/make-pycharm-virtualenv | 11 +- > build-support/python/update-pants-requirements | 34 - > pants | 102 > +++--- > pants.ini | 63 > ++- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > - > > .auroraversion d2cbead89e9c31b9fb31db9a645afb99ff585b10 > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD > 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD > 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt > 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv > d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements > 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/client/BUILD > 8424237eb56abe38c4d0871557dc929250de1ba4 > src/main/python/apache/aurora/tools/BUILD > e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD > d7eedabc0930711530b45ac98a1159e69d1a0c00 > src/main/resources/apache/aurora/client/cli/.auroraversion > src/main/resources/apache/aurora/client/cli/BUILD > 7c77d10823753af56db01a3b0db49868451d6435 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > --- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > >
