Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/#review136831 --- Ship it! Ship It! - Maxim Khutornenko On June 9, 2016, 3:55 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48492/ > --- > > (Updated June 9, 2016, 3:55 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. > > > Bugs: AURORA-1709 > https://issues.apache.org/jira/browse/AURORA-1709 > > > Repository: aurora > > > Description > --- > > Don't require user when initializing a Docker sandbox. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > be1deba6219462c9fdaaf07a583851b85fe974bf > src/test/python/apache/aurora/executor/common/test_sandbox.py > e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9 > > Diff: https://reviews.apache.org/r/48492/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/#review136829 --- Ship it! Master (e89521f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 9, 2016, 3:55 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48492/ > --- > > (Updated June 9, 2016, 3:55 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. > > > Bugs: AURORA-1709 > https://issues.apache.org/jira/browse/AURORA-1709 > > > Repository: aurora > > > Description > --- > > Don't require user when initializing a Docker sandbox. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > be1deba6219462c9fdaaf07a583851b85fe974bf > src/test/python/apache/aurora/executor/common/test_sandbox.py > e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9 > > Diff: https://reviews.apache.org/r/48492/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/#review136824 --- @ReviewBot retry - Joshua Cohen On June 9, 2016, 3:55 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48492/ > --- > > (Updated June 9, 2016, 3:55 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. > > > Bugs: AURORA-1709 > https://issues.apache.org/jira/browse/AURORA-1709 > > > Repository: aurora > > > Description > --- > > Don't require user when initializing a Docker sandbox. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > be1deba6219462c9fdaaf07a583851b85fe974bf > src/test/python/apache/aurora/executor/common/test_sandbox.py > e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9 > > Diff: https://reviews.apache.org/r/48492/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/ --- (Updated June 9, 2016, 3:55 p.m.) Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. Changes --- isort. Bugs: AURORA-1709 https://issues.apache.org/jira/browse/AURORA-1709 Repository: aurora Description --- Don't require user when initializing a Docker sandbox. Diffs (updated) - src/main/python/apache/aurora/executor/common/sandbox.py be1deba6219462c9fdaaf07a583851b85fe974bf src/test/python/apache/aurora/executor/common/test_sandbox.py e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9 Diff: https://reviews.apache.org/r/48492/diff/ Testing --- ./build-support/jenkins/build.sh e2e tests. Thanks, Joshua Cohen
Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/#review136819 --- Master (e89521f) is red with this patch. ./build-support/jenkins/build.sh virtualenv-14.0.6/virtualenv_embedded/activate_this.py virtualenv-14.0.6/virtualenv_embedded/deactivate.bat virtualenv-14.0.6/virtualenv_embedded/distutils-init.py virtualenv-14.0.6/virtualenv_embedded/distutils.cfg virtualenv-14.0.6/virtualenv_embedded/python-config virtualenv-14.0.6/virtualenv_embedded/site.py virtualenv-14.0.6/virtualenv_support/ virtualenv-14.0.6/virtualenv_support/__init__.py virtualenv-14.0.6/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/pip-8.0.2-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/setuptools-20.0-py2.py3-none-any.whl virtualenv-14.0.6/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl + touch virtualenv-14.0.6/BOOTSTRAPPED + popd ~/jenkins-slave/workspace/AuroraBot + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-14.0.6/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7 Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python Installing setuptools, pip, wheel...done. Collecting isort==4.0.0 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning. SNIMissingWarning /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Using cached isort-4.0.0-py2.py3-none-any.whl Installing collected packages: isort Successfully installed isort-4.0.0 ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_sandbox.py Imports are incorrectly sorted. --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_sandbox.py:before 2016-06-09 15:41:44.525059 +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_sandbox.py:after 2016-06-09 15:51:02.061859 @@ -21,7 +21,8 @@ from apache.aurora.executor.common.sandbox import ( DefaultSandboxProvider, DirectorySandbox, -FileSystemImageSandbox) +FileSystemImageSandbox +) from gen.apache.aurora.api.ttypes import AssignedTask, Container, DockerContainer, TaskConfig I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 9, 2016, 3:38 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48492/ > --- > > (Updated June 9, 2016, 3:38 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. > > > Bugs: AURORA-1709 > https://issues.apache.org/jira/browse/AURORA-1709 > > > Repository: aurora > > > Description > --- > > Don't require user when initializing a Docker sandbox. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > be1deba6219462c9fdaaf07a583851b85fe974bf > src/test/python/apache/aurora/executor/common/test_sandbox.py > e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9 > > Diff: https://reviews.apache.org/r/48492/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests. > > > Thanks, > > Joshua Cohen > >
Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/ --- (Updated June 9, 2016, 3:38 p.m.) Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. Changes --- Add tests. Bugs: AURORA-1709 https://issues.apache.org/jira/browse/AURORA-1709 Repository: aurora Description --- Don't require user when initializing a Docker sandbox. Diffs (updated) - src/main/python/apache/aurora/executor/common/sandbox.py be1deba6219462c9fdaaf07a583851b85fe974bf src/test/python/apache/aurora/executor/common/test_sandbox.py e47d9b8822deb36cb9cfa0554ef89d6cda80f3e9 Diff: https://reviews.apache.org/r/48492/diff/ Testing --- ./build-support/jenkins/build.sh e2e tests. Thanks, Joshua Cohen
Re: Review Request 48492: Don't require user when initializing a Docker sandbox.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48492/#review136816 --- Master (e89521f) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 9, 2016, 3:02 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48492/ > --- > > (Updated June 9, 2016, 3:02 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Dmitriy Shirchenko. > > > Bugs: AURORA-1709 > https://issues.apache.org/jira/browse/AURORA-1709 > > > Repository: aurora > > > Description > --- > > Don't require user when initializing a Docker sandbox. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > be1deba6219462c9fdaaf07a583851b85fe974bf > > Diff: https://reviews.apache.org/r/48492/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests. > > > Thanks, > > Joshua Cohen > >
