Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52527/
---

(Updated Oct. 4, 2016, 9:32 p.m.)


Review request for Aurora, Stephan Erb and Zameer Manji.


Changes
---

Address Stephan's feedback.


Repository: aurora


Description
---

This will allow for other consumers of the TaskInfo (e.g. a custom mesos QoS 
controller) to alter their behavior based on a task's tier.


Diffs (updated)
-

  RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
68830ce2afeb6ad67d5e4e2b663b1453a966350d 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
b5575a7808abf4249b282c55e3cead81cfb836e1 

Diff: https://reviews.apache.org/r/52527/diff/


Testing
---

./gradlew build -Pq


Thanks,

Joshua Cohen

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

[Joshua Cohen]

> On Oct. 4, 2016, 9:23 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 99
> > 
> >
> > Should we consider using the `AURORA_LABEL_PREFIX` prefix here as well?

This is maintaining backwards compatability with the source that used to be a 
direct attribute of the executor info, so I think it should stay as is (at the 
time the guidance from the Mesos folks was to use "source" as the label's key). 
I can add a comment explaining that.


> On Oct. 4, 2016, 9:23 p.m., Stephan Erb wrote:
> > RELEASE-NOTES.md, line 8
> > 
> >
> > Please move this to the `New/updated` section.

Whoops, thanks for catching.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52527/#review151404
---


On Oct. 4, 2016, 9:08 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52527/
> ---
> 
> (Updated Oct. 4, 2016, 9:08 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This will allow for other consumers of the TaskInfo (e.g. a custom mesos QoS 
> controller) to alter their behavior based on a task's tier.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 68830ce2afeb6ad67d5e4e2b663b1453a966350d 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> b5575a7808abf4249b282c55e3cead81cfb836e1 
> 
> Diff: https://reviews.apache.org/r/52527/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52527/#review151405
---


Ship it!




Master (ebdaa6b) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 4, 2016, 9:08 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52527/
> ---
> 
> (Updated Oct. 4, 2016, 9:08 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This will allow for other consumers of the TaskInfo (e.g. a custom mesos QoS 
> controller) to alter their behavior based on a task's tier.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 68830ce2afeb6ad67d5e4e2b663b1453a966350d 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> b5575a7808abf4249b282c55e3cead81cfb836e1 
> 
> Diff: https://reviews.apache.org/r/52527/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52527/#review151404
---


Fix it, then Ship it!




LGTM


RELEASE-NOTES.md (line 8)


Please move this to the `New/updated` section.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 95)


Should we consider using the `AURORA_LABEL_PREFIX` prefix here as well?


- Stephan Erb


On Oct. 4, 2016, 11:08 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52527/
> ---
> 
> (Updated Oct. 4, 2016, 11:08 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This will allow for other consumers of the TaskInfo (e.g. a custom mesos QoS 
> controller) to alter their behavior based on a task's tier.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 68830ce2afeb6ad67d5e4e2b663b1453a966350d 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> b5575a7808abf4249b282c55e3cead81cfb836e1 
> 
> Diff: https://reviews.apache.org/r/52527/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 52527: Expose task tier as a label on TaskInfo proto.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52527/#review151402
---


Ship it!




Ship It!

- Zameer Manji


On Oct. 4, 2016, 2:08 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52527/
> ---
> 
> (Updated Oct. 4, 2016, 2:08 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This will allow for other consumers of the TaskInfo (e.g. a custom mesos QoS 
> controller) to alter their behavior based on a task's tier.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 49c03e85ae4c2e3ebc8af89e9ce41df9fd52d6cd 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 68830ce2afeb6ad67d5e4e2b663b1453a966350d 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> b5575a7808abf4249b282c55e3cead81cfb836e1 
> 
> Diff: https://reviews.apache.org/r/52527/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>