Re: Review Request 52609: Manually configure the private network interface in Vagrant

2016-10-06 Thread John Sirois


> On Oct. 6, 2016, 1:10 p.m., John Sirois wrote:
> > I added myself as a reviewer since I'm running Vagrant 1.8.6.  I'll have 
> > time to confirm your issue and fix later today and have some feedback for 
> > you by tomorrow latest.

I can confirm both the failure to autoprovision under 1.8.6 and the old 
Vagrantfile and the fix. Thanks for addressing this Andrew!


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151705
---


On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>



Re: Review Request 52609: Manually configure the private network interface in Vagrant

2016-10-06 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151714
---


Ship it!




Ship It!

- John Sirois


On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>



Re: Review Request 52609: Manually configure the private network interface in Vagrant

2016-10-06 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151705
---



I added myself as a reviewer since I'm running Vagrant 1.8.6.  I'll have time 
to confirm your issue and fix later today and have some feedback for you by 
tomorrow latest.

- John Sirois


On Oct. 6, 2016, 12:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 12:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>



Re: Review Request 52609: Manually configure the private network interface in Vagrant

2016-10-06 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/#review151692
---


Ship it!




Master (b417be3) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 6, 2016, 6:14 p.m., Andrew Jorgensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52609/
> ---
> 
> (Updated Oct. 6, 2016, 6:14 p.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
> network interface does not come up correctly and the private_network is 
> attached to the `eth0` nat interface rather than the host-only interface. I 
> tried a number of different parameters but none of them were able to 
> configure the network appropriately. This change manually configures the 
> static ip so that it is connected to the correct adapter. Without this change 
> I could not access the aurora web interface.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 
> 
> Diff: https://reviews.apache.org/r/52609/diff/
> 
> 
> Testing
> ---
> 
> Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
> steps here: 
> http://aurora.apache.org/documentation/latest/getting-started/vagrant/
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>



Re: Review Request 52609: Manually configure the private network interface in Vagrant

2016-10-06 Thread Andrew Jorgensen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52609/
---

(Updated Oct. 6, 2016, 6:09 p.m.)


Review request for Aurora.


Summary (updated)
-

Manually configure the private network interface in Vagrant


Repository: aurora


Description
---

I am not sure of the specifics of why this happens but on vagrant 1.8.6 the 
network interface does not come up correctly and the private_network is 
attached to the `eth0` nat interface rather than the host-only interface. I 
tried a number of different parameters but none of them were able to configure 
the network appropriately. This change manually configures the static ip so 
that it is connected to the correct adapter. Without this change I could not 
access the aurora web interface.


Diffs
-

  Vagrantfile 5d6e1b29f28a57cb9a06df5f673c4b56697fbfcb 

Diff: https://reviews.apache.org/r/52609/diff/


Testing
---

Ran `vagrant up` and tried to visit http://192.168.33.7:8081 according to the 
steps here: 
http://aurora.apache.org/documentation/latest/getting-started/vagrant/


Thanks,

Andrew Jorgensen