Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/
---

(Updated Sept. 9, 2015, 6:35 p.m.)


Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.


Changes
---

Bill's comment.


Bugs: AURORA-1460
https://issues.apache.org/jira/browse/AURORA-1460


Repository: aurora


Description
---

This change drops quota enforcement for dedicated jobs and adds dedicated 
resource consumption into the thrift API. There is now a shared/dedicated 
consumption split for both prod and non-prod tasks.

NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
tier-based mapping when AURORA-1443 is addressed.


Diffs (updated)
-

  NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
  src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
df796fcc91265c588872051f16bd2f10f73dc718 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
3d89e43659750de63d7588f8574e7a350caea04b 
  src/main/python/apache/aurora/client/api/quota_check.py 
75406ac1d3ec9ba655daf7c6125f208f74290cfb 
  src/main/python/apache/aurora/client/cli/quota.py 
e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
  src/main/resources/scheduler/assets/js/controllers.js 
4acab107e1a4ecf310192c9bb3ad2a3f90f524f1 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
db60cd21d06d636505202bac7277a13dc24d46e6 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 a8df44612b605dff512d1ca686f0789b84ef9012 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
e0110e7ebe631b7b66b2341cedc10490da00a2ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
4d4e752088f7dca99675cc66782ae046bbd516d6 
  src/test/python/apache/aurora/admin/test_admin.py 
d793293acc7f77c0081968334c38b984d865fbc8 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
  src/test/python/apache/aurora/client/cli/test_quota.py 
3573e4c4575577e2232d2b99ca781b06a03d48d7 

Diff: https://reviews.apache.org/r/38081/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-09 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review98238
---

Ship it!


Master (4577de4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 9, 2015, 6:35 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 9, 2015, 6:35 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. There is now a shared/dedicated 
> consumption split for both prod and non-prod tasks.
> 
> NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
> tier-based mapping when AURORA-1443 is addressed.
> 
> 
> Diffs
> -
> 
>   NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
> df796fcc91265c588872051f16bd2f10f73dc718 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 4acab107e1a4ecf310192c9bb3ad2a3f90f524f1 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  a8df44612b605dff512d1ca686f0789b84ef9012 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review98053
---

Ship it!



NEWS (line 16)


s/enforced for/consumed by/


- Bill Farner


On Sept. 8, 2015, 9:53 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 8, 2015, 9:53 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. There is now a shared/dedicated 
> consumption split for both prod and non-prod tasks.
> 
> NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
> tier-based mapping when AURORA-1443 is addressed.
> 
> 
> Diffs
> -
> 
>   NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
> df796fcc91265c588872051f16bd2f10f73dc718 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  a8df44612b605dff512d1ca686f0789b84ef9012 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review98023
---

Ship it!


Master (2773826) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 8, 2015, 4:53 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 8, 2015, 4:53 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. There is now a shared/dedicated 
> consumption split for both prod and non-prod tasks.
> 
> NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
> tier-based mapping when AURORA-1443 is addressed.
> 
> 
> Diffs
> -
> 
>   NEWS 83a1213e2ea4ab6b3706cd70c015ba9f16735520 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
> df796fcc91265c588872051f16bd2f10f73dc718 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  a8df44612b605dff512d1ca686f0789b84ef9012 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-08 Thread Maxim Khutornenko 


> On Sept. 8, 2015, 3:55 p.m., Bill Farner wrote:
> > Looks good!  Holding back the ship until a `NEWS` entry is included in the 
> > patch.

Thanks for reminding! Added.


> On Sept. 8, 2015, 3:55 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java,
> >  line 313
> > 
> >
> > All the fields are checked here, how about a check on the 
> > `GetQuotaResult` itself?
> > 
> > ```
> > assertEquals(expectedResult, actualResult);
> > ```

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review98013
---


On Sept. 7, 2015, 11:51 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 7, 2015, 11:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. There is now a shared/dedicated 
> consumption split for both prod and non-prod tasks.
> 
> NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
> tier-based mapping when AURORA-1443 is addressed.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
> df796fcc91265c588872051f16bd2f10f73dc718 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  a8df44612b605dff512d1ca686f0789b84ef9012 
>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
> e0110e7ebe631b7b66b2341cedc10490da00a2ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-07 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/
---

(Updated Sept. 7, 2015, 11:51 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
---

Adding nonprod shared/dedicated consumption.


Bugs: AURORA-1460
https://issues.apache.org/jira/browse/AURORA-1460


Repository: aurora


Description (updated)
---

This change drops quota enforcement for dedicated jobs and adds dedicated 
resource consumption into the thrift API. There is now a shared/dedicated 
consumption split for both prod and non-prod tasks.

NOTE: the GetQuotaResult will have to be deprecated and/or replaced with a 
tier-based mapping when AURORA-1443 is addressed.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
  src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java 
df796fcc91265c588872051f16bd2f10f73dc718 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
3d89e43659750de63d7588f8574e7a350caea04b 
  src/main/python/apache/aurora/client/api/quota_check.py 
75406ac1d3ec9ba655daf7c6125f208f74290cfb 
  src/main/python/apache/aurora/client/cli/quota.py 
e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
  src/main/resources/scheduler/assets/js/controllers.js 
98920196db34f2eb4dcad93429274517e7383efe 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
db60cd21d06d636505202bac7277a13dc24d46e6 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 a8df44612b605dff512d1ca686f0789b84ef9012 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
e0110e7ebe631b7b66b2341cedc10490da00a2ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
4d4e752088f7dca99675cc66782ae046bbd516d6 
  src/test/python/apache/aurora/admin/test_admin.py 
d793293acc7f77c0081968334c38b984d865fbc8 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
  src/test/python/apache/aurora/client/cli/test_quota.py 
3573e4c4575577e2232d2b99ca781b06a03d48d7 

Diff: https://reviews.apache.org/r/38081/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-04 Thread Maxim Khutornenko 


> On Sept. 3, 2015, 6:36 p.m., Zameer Manji wrote:
> > I think there should be a `NEWS` file entry about this change and 
> > documentation updates. I'm comfortable with documentation changes being in 
> > another review but I think this commit should also update the `NEWS` file.

Sure.


> On Sept. 3, 2015, 6:36 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java, line 97
> > 
> >
> > I think you need to `prodDedicatedConsumption` to the set of hashed 
> > fields.

Good catch, done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97664
---


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Maxim Khutornenko 


> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369
> > 
> >
> > I think it will be better if we split this into 
> > nonProdSharedConsumption and nonProdDedicatedConsumption.
> 
> Maxim Khutornenko wrote:
> This may be an option to consider in future but it does not fit the scope 
> of this change.
> 
> Suman Karumuri wrote:
> Is there a strong reason, not to split the non prod consumption into 
> shared and dedicated pools since we already do it for prod jobs? I think we 
> should expose this info now when we are making the split between dedicated 
> and shared pool. Delaying it will involve a lot more effort later. If we 
> choose not to expose this infortion separately in the UI, the UI can add up 
> nonProdDedicatedConsumption and nonProdSharedPoolConsumption into the same 
> field. But going the other way around would be a lot more work. 
> 
> I also feel we should decide on the UI design now and implement the API 
> accordingly.

| Is there a strong reason, not to split the non prod consumption into shared 
and dedicated pools since we already do it for prod jobs?

I just don't want to increase the size of this diff and add changes irrelevant 
to the subject matter. I am open to consider adding it separately.

Also, the approach of adding prod/non-prod dedicated consumption does not scale 
given our upcoming migration to task tiers. There is a good chance this 
structure will have to be dropped entirely in favor of something like this 
(just to illustrate the direction):
```
struct TierResources {
  1: string taskTier
  2: ResourceAggregate quota
  3: ResourceAggregate consumption
}

struct GetQuotaResultNew {
  1: map resourcesByTier
}
```

In the above example, a "non-prod dedicated" could be a completely separate 
tier (though does not have to be). This is the reason I was hesistant adding 
prod/nonprod consumption split in the first place, hence my comment in the 
description. I wonder what others think?

| But going the other way around would be a lot more work. I also feel we 
should decide on the UI design now and implement the API accordingly.

I don't buy this argument. There is nothing preventing us from implementing the 
UI the way we want and iterate accordingly.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97593
---


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97664
---

Ship it!


I think there should be a `NEWS` file entry about this change and documentation 
updates. I'm comfortable with documentation changes being in another review but 
I think this commit should also update the `NEWS` file.


src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java (line 97)


I think you need to `prodDedicatedConsumption` to the set of hashed fields.


- Zameer Manji


On Sept. 2, 2015, 5:46 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 2, 2015, 5:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Suman Karumuri 


> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369
> > 
> >
> > I think it will be better if we split this into 
> > nonProdSharedConsumption and nonProdDedicatedConsumption.
> 
> Maxim Khutornenko wrote:
> This may be an option to consider in future but it does not fit the scope 
> of this change.
> 
> Suman Karumuri wrote:
> Is there a strong reason, not to split the non prod consumption into 
> shared and dedicated pools since we already do it for prod jobs? I think we 
> should expose this info now when we are making the split between dedicated 
> and shared pool. Delaying it will involve a lot more effort later. If we 
> choose not to expose this infortion separately in the UI, the UI can add up 
> nonProdDedicatedConsumption and nonProdSharedPoolConsumption into the same 
> field. But going the other way around would be a lot more work. 
> 
> I also feel we should decide on the UI design now and implement the API 
> accordingly.
> 
> Maxim Khutornenko wrote:
> | Is there a strong reason, not to split the non prod consumption into 
> shared and dedicated pools since we already do it for prod jobs?
> 
> I just don't want to increase the size of this diff and add changes 
> irrelevant to the subject matter. I am open to consider adding it separately.
> 
> Also, the approach of adding prod/non-prod dedicated consumption does not 
> scale given our upcoming migration to task tiers. There is a good chance this 
> structure will have to be dropped entirely in favor of something like this 
> (just to illustrate the direction):
> ```
> struct TierResources {
>   1: string taskTier
>   2: ResourceAggregate quota
>   3: ResourceAggregate consumption
> }
> 
> struct GetQuotaResultNew {
>   1: map resourcesByTier
> }
> ```
> 
> In the above example, a "non-prod dedicated" could be a completely 
> separate tier (though does not have to be). This is the reason I was 
> hesistant adding prod/nonprod consumption split in the first place, hence my 
> comment in the description. I wonder what others think?
> 
> | But going the other way around would be a lot more work. I also feel we 
> should decide on the UI design now and implement the API accordingly.
> 
> I don't buy this argument. There is nothing preventing us from 
> implementing the UI the way we want and iterate accordingly.
> 
> Zameer Manji wrote:
> Maxim,
> 
> Is this possible change tracked apart of the tier work? If not, I really 
> think a ticket for this should be created so we don't forget about this.

Thanks for the explanation. I like the TieredResources struct approach. As a 
service owner though, I would like to see non-prod dedicated consumption and 
prod dedicated consumption. That would clearly tell me the amount of resources 
I am using for prod and non-prod.

+1 for tracking this in a ticket as part of task tiers implementation.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97593
---


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Suman Karumuri 


> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369
> > 
> >
> > I think it will be better if we split this into 
> > nonProdSharedConsumption and nonProdDedicatedConsumption.
> 
> Maxim Khutornenko wrote:
> This may be an option to consider in future but it does not fit the scope 
> of this change.

Is there a strong reason, not to split the non prod consumption into shared and 
dedicated pools since we already do it for prod jobs? I think we should expose 
this info now when we are making the split between dedicated and shared pool. 
Delaying it will involve a lot more effort later. If we choose not to expose 
this infortion separately in the UI, the UI can add up 
nonProdDedicatedConsumption and nonProdSharedPoolConsumption into the same 
field. But going the other way around would be a lot more work. 

I also feel we should decide on the UI design now and implement the API 
accordingly.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97593
---


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Maxim Khutornenko 


> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369
> > 
> >
> > I think it will be better if we split this into 
> > nonProdSharedConsumption and nonProdDedicatedConsumption.

This may be an option to consider in future but it does not fit the scope of 
this change.


> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote:
> > src/main/resources/scheduler/assets/js/controllers.js, line 161
> > 
> >
> > I think we should see if the role has jobs running on dedicated boxes. 
> > If it does, show nonProdDedicatedConsumption and prodDedicatedConsumption 
> > else hide it.
> > 
> > If we expose prod and non prod dedicated consumption, we also have to 
> > rename the current quota titles to Production shared consumption or 
> > something similar. 
> > 
> > I prefer not exposing the dedicated aspect to jobs running in shared 
> > pool since users may take it as an encouagement to run on dedicated boxes. 
> > For jobs running in shared pool, we don't have to change the terminology.
> > 
> > It may be simpler to just implement as 2 different tables one for 
> > shared pool jobs and one for jobs involving mixed workloads.

I would defer this discussion to AURORA-1461. This touches UI only to reflect 
field renaming.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97593
---


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97675
---

Ship it!


Ship It!

- Joshua Cohen


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-02 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/
---

Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.


Bugs: AURORA-1460
https://issues.apache.org/jira/browse/AURORA-1460


Repository: aurora


Description
---

This change drops quota enforcement for dedicated jobs and adds dedicated 
resource consumption into the thrift API. Feel free to pushback on the latter 
but I think users will find it immediately confusing when we change the "Prod 
consumption" to something like "Prod shared pool consumption" in the UI/client 
and not provide the missing dedicated rollup numbers.


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
3d89e43659750de63d7588f8574e7a350caea04b 
  src/main/python/apache/aurora/client/api/quota_check.py 
75406ac1d3ec9ba655daf7c6125f208f74290cfb 
  src/main/python/apache/aurora/client/cli/quota.py 
e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
  src/main/resources/scheduler/assets/js/controllers.js 
98920196db34f2eb4dcad93429274517e7383efe 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
db60cd21d06d636505202bac7277a13dc24d46e6 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
4d4e752088f7dca99675cc66782ae046bbd516d6 
  src/test/python/apache/aurora/admin/test_admin.py 
d793293acc7f77c0081968334c38b984d865fbc8 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
  src/test/python/apache/aurora/client/cli/test_quota.py 
3573e4c4575577e2232d2b99ca781b06a03d48d7 

Diff: https://reviews.apache.org/r/38081/diff/


Testing
---


Thanks,

Maxim Khutornenko

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97590
---

Ship it!


Master (a459527) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 3, 2015, 12:46 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38081/
> ---
> 
> (Updated Sept. 3, 2015, 12:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1460
> https://issues.apache.org/jira/browse/AURORA-1460
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change drops quota enforcement for dedicated jobs and adds dedicated 
> resource consumption into the thrift API. Feel free to pushback on the latter 
> but I think users will find it immediately confusing when we change the "Prod 
> consumption" to something like "Prod shared pool consumption" in the 
> UI/client and not provide the missing dedicated rollup numbers.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 21137bbbdc3010c6b1e2cc0ebb3b99bfa8490563 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
> b40ecd0af7c1d1bb9372bd89c741622ce4c9040c 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8787aeaa6655cfab1e0a6d5719f9e08a89df7631 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 3d89e43659750de63d7588f8574e7a350caea04b 
>   src/main/python/apache/aurora/client/api/quota_check.py 
> 75406ac1d3ec9ba655daf7c6125f208f74290cfb 
>   src/main/python/apache/aurora/client/cli/quota.py 
> e8aa010f5ecce0464a8ad6b072bccba589fe16d7 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 98920196db34f2eb4dcad93429274517e7383efe 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> db60cd21d06d636505202bac7277a13dc24d46e6 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  4d4e752088f7dca99675cc66782ae046bbd516d6 
>   src/test/python/apache/aurora/admin/test_admin.py 
> d793293acc7f77c0081968334c38b984d865fbc8 
>   src/test/python/apache/aurora/client/api/test_quota_check.py 
> 6c9bc373d1868bd6e0cae2f2218261f39fd7ab8f 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 3573e4c4575577e2232d2b99ca781b06a03d48d7 
> 
> Diff: https://reviews.apache.org/r/38081/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>