Re: Review Request 38086: Add test environments for RPMs and debs.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/
---

(Updated Sept. 9, 2015, 3:19 p.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora-packaging


Description
---

Add test environments for RPMs and debs.


Diffs (updated)
-

  .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
  test/deb/ubuntu-trusty/README.md PRE-CREATION 
  test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
  test/rpm/centos-7/README.md PRE-CREATION 
  test/rpm/centos-7/Vagrantfile PRE-CREATION 
  test/rpm/centos-7/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/38086/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 38086: Add test environments for RPMs and debs.

[Bill Farner]

> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/deb/ubuntu-trusty/Vagrantfile, lines 6-12
> > 
> >
> > mutli-vm boilerplate isn't needed
> > 
> > Can replace this block with
> > 
> > ```ruby
> > config.vm.provider :virtualbox do |vb|
> >   vb.customize [...]
> > end
> > config.vm.provision "shell", path: "provision.sh"
> > ```

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/deb/ubuntu-trusty/provision.sh, line 9
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/README.md, line 8
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/Vagrantfile, lines 6-11
> > 
> >
> > Drop multi-vm boilerplate

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, line 7
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, line 12
> > 
> >
> > https

Done.


> On Sept. 9, 2015, 11 a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, lines 3-5
> > 
> >
> > yum should include these packages when we install the others, can this 
> > line be omitted?

Thanks, done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98233
---


On Sept. 2, 2015, 7:59 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38086/
> ---
> 
> (Updated Sept. 2, 2015, 7:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Add test environments for RPMs and debs.
> 
> 
> Diffs
> -
> 
>   .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
>   test/deb/ubuntu-trusty/README.md PRE-CREATION 
>   test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
>   test/rpm/centos-7/README.md PRE-CREATION 
>   test/rpm/centos-7/Vagrantfile PRE-CREATION 
>   test/rpm/centos-7/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38086: Add test environments for RPMs and debs.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98272
---

Ship it!


LGTM once comments are addressed

- Kevin Sweeney


On Sept. 2, 2015, 7:59 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38086/
> ---
> 
> (Updated Sept. 2, 2015, 7:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Add test environments for RPMs and debs.
> 
> 
> Diffs
> -
> 
>   .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
>   test/deb/ubuntu-trusty/README.md PRE-CREATION 
>   test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
>   test/rpm/centos-7/README.md PRE-CREATION 
>   test/rpm/centos-7/Vagrantfile PRE-CREATION 
>   test/rpm/centos-7/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 38086: Add test environments for RPMs and debs.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98135
---


Ping

- Bill Farner


On Sept. 2, 2015, 7:59 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38086/
> ---
> 
> (Updated Sept. 2, 2015, 7:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Add test environments for RPMs and debs.
> 
> 
> Diffs
> -
> 
>   .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
>   test/deb/ubuntu-trusty/README.md PRE-CREATION 
>   test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
>   test/rpm/centos-7/README.md PRE-CREATION 
>   test/rpm/centos-7/Vagrantfile PRE-CREATION 
>   test/rpm/centos-7/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38086/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 38086: Add test environments for RPMs and debs.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora-packaging


Description
---

Add test environments for RPMs and debs.


Diffs
-

  .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
  test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
  test/rpm/centos-7/README.md PRE-CREATION 
  test/rpm/centos-7/Vagrantfile PRE-CREATION 
  test/rpm/centos-7/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/38086/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 38086: Add test environments for RPMs and debs.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/
---

(Updated Sept. 2, 2015, 7:59 p.m.)


Review request for Aurora and Kevin Sweeney.


Changes
---

Neglected to git-add ubuntu readme.


Repository: aurora-packaging


Description
---

Add test environments for RPMs and debs.


Diffs (updated)
-

  .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
  test/deb/ubuntu-trusty/README.md PRE-CREATION 
  test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
  test/rpm/centos-7/README.md PRE-CREATION 
  test/rpm/centos-7/Vagrantfile PRE-CREATION 
  test/rpm/centos-7/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/38086/diff/


Testing
---


Thanks,

Bill Farner