Re: Review Request 51924: Remove --release-threshold option from aurora job restart.

2016-09-15 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51924/#review149107
---



Master (5069f93) is red with this patch.
  ./build-support/jenkins/build.sh

 # Create file stdout for capturing output. We 
can't use StringIO mock
 # because TestProcess is running fork.
 with open(os.path.join(td, 'sys_stdout'), 
'w+') as stdout:
   with open(os.path.join(td, 'sys_stderr'), 
'w+') as stderr:
 with mutable_sys():
   sys.stdout, sys.stderr = stdout, 
stderr
 
   p = TestProcess('process', 'echo hello 
world; echo >&2 hello stderr', 0,
   taskpath, sandbox, 
logger_destination=LoggerDestination.BOTH)
   p.start()
   rc = 
wait_for_rc(taskpath.getpath('process_checkpoint'))
 
   assert rc == 0
   # Check log files were created in std 
path with correct content
 > assert_log_content(taskpath, 'stdout', 
'hello world\n')
 
 src/test/python/apache/thermos/core/test_process.py:487: 
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
 
 taskpath = 
 log_name = 'stdout'
 expected_content = 'hello world\n'
 
 def assert_log_content(taskpath, log_name, 
expected_content):
   log = 
taskpath.with_filename(log_name).getpath('process_logdir')
   assert os.path.exists(log)
   with open(log, 'r') as fp:
 >   assert fp.read() == expected_content
 E   assert '' == 'hello world\n'
 E + hello world
 
 src/test/python/apache/thermos/core/test_process.py:313: 
AssertionError
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
  1 failed, 708 passed, 6 skipped, 1 warnings in 
342.57 seconds 
 
FAILURE


18:40:10 06:35   [complete]
   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 15, 2016, 6:13 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51924/
> ---
> 
> (Updated Sept. 15, 2016, 6:13 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1681
> https://issues.apache.org/jira/browse/AURORA-1681
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove --release-threshold option from aurora job restart.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md ad2c68a6defe07c94480d7dee5b1496b50dc34e5 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 7b4c2692334acfddb53a52a602a5f07e94b4bd86 
> 
> Diff: https://reviews.apache.org/r/51924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>



Re: Review Request 51924: Remove --release-threshold option from aurora job restart.

2016-09-15 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51924/#review149097
---


Ship it!




Ship It!

- Maxim Khutornenko


On Sept. 15, 2016, 6:13 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51924/
> ---
> 
> (Updated Sept. 15, 2016, 6:13 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1681
> https://issues.apache.org/jira/browse/AURORA-1681
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove --release-threshold option from aurora job restart.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md ad2c68a6defe07c94480d7dee5b1496b50dc34e5 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 7b4c2692334acfddb53a52a602a5f07e94b4bd86 
> 
> Diff: https://reviews.apache.org/r/51924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>



Review Request 51924: Remove --release-threshold option from aurora job restart.

2016-09-15 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51924/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-1681
https://issues.apache.org/jira/browse/AURORA-1681


Repository: aurora


Description
---

Remove --release-threshold option from aurora job restart.


Diffs
-

  RELEASE-NOTES.md ad2c68a6defe07c94480d7dee5b1496b50dc34e5 
  src/main/python/apache/aurora/client/cli/jobs.py 
7b4c2692334acfddb53a52a602a5f07e94b4bd86 

Diff: https://reviews.apache.org/r/51924/diff/


Testing
---


Thanks,

Joshua Cohen