Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155039
---
Ship it!
Master (5410c22) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 5, 2016, 12:53 a.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
>
> (Updated Nov. 5, 2016, 12:53 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/
> and
> wraps the `prcl(2)` call in a try except block.
>
> This also exposed some flakyness in
> `TestRunnerKillProcessGroup.test_pg_is_killed`. Marked the test as flaky and
> filed AURORA-1809.
>
>
> Diffs
> -
>
> RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
> src/main/python/apache/thermos/common/process_util.py
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40
> src/main/python/apache/thermos/core/process.py
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802
> src/test/python/apache/thermos/core/test_staged_kill.py
> 9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8
>
> Diff: https://reviews.apache.org/r/53508/diff/
>
>
> Testing
> ---
>
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/
---
(Updated Nov. 4, 2016, 5:53 p.m.)
Review request for Aurora, Joshua Cohen and Stephan Erb.
Repository: aurora
Description (updated)
---
The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
wraps the `prcl(2)` call in a try except block.
This also exposed some flakyness in
`TestRunnerKillProcessGroup.test_pg_is_killed`. Marked the test as flaky and
filed AURORA-1809.
Diffs
-
RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
src/main/python/apache/thermos/common/process_util.py
c63b9aff2a9a453ca921308baa4d1d1762ae3a40
src/main/python/apache/thermos/core/process.py
13f9ad5711edde3a0a0d47ba6db1c199434e6802
src/test/python/apache/thermos/core/test_staged_kill.py
9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8
Diff: https://reviews.apache.org/r/53508/diff/
Testing
---
./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/
---
(Updated Nov. 4, 2016, 5:53 p.m.)
Review request for Aurora, Joshua Cohen and Stephan Erb.
Changes
---
Skip flaky test.
Repository: aurora
Description
---
The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
wraps the `prcl(2)` call in a try except block.
Diffs (updated)
-
RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
src/main/python/apache/thermos/common/process_util.py
c63b9aff2a9a453ca921308baa4d1d1762ae3a40
src/main/python/apache/thermos/core/process.py
13f9ad5711edde3a0a0d47ba6db1c199434e6802
src/test/python/apache/thermos/core/test_staged_kill.py
9167e6082d72aed9aa6aa4bb209c83f9d53c8ae8
Diff: https://reviews.apache.org/r/53508/diff/
Testing
---
./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155032
---
Master (5410c22) is red with this patch.
./build-support/jenkins/build.sh
[1m[0m
[1m ps = ProcessProviderFactory.get()[0m
[1m ps.collect_all()[0m
[1m assert parent_pid in ps.pids()[0m
[1m assert child_pid in ps.pids()[0m
[1m assert child_pid in
ps.children_of(parent_pid)[0m
[1m[0m
[1m with open(os.path.join(runner.sandbox,
runner.task_id, 'exit.txt'), 'w') as fp:[0m
[1mfp.write('go away!')[0m
[1m[0m
[1m while tm.task_state() is not
TaskState.SUCCESS:[0m
[1mtime.sleep(0.1)[0m
[1m[0m
[1m state = tm.get_state()[0m
[1m assert state.processes['process'][0].state ==
ProcessState.SUCCESS[0m
[1m[0m
[1m ps.collect_all()[0m
[1m assert parent_pid not in ps.pids()[0m
[1m> assert child_pid not in ps.pids()[0m
[1m[31mE assert 30475 not in set([1, 2, 3, 5, 7, 8,
...])[0m
[1m[31mE + where set([1, 2, 3, 5, 7, 8, ...]) =
>()[0m
[1m[31mE +where > =
.pids[0m
src/test/python/apache/thermos/core/test_staged_kill.py:287: AssertionError
-- Captured stderr call --
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
WARNING:root:Could not read from checkpoint
/tmp/tmp9WSRnw/checkpoints/1478305991773556-runner-base/runner
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 719 passed, 6 skipped, 1 warnings in
206.00 seconds [0m
FAILURE
00:35:12 03:45 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 4, 2016, 11:54 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
>
> (Updated Nov. 4, 2016, 11:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/
> and
> wraps the `prcl(2)` call in a try except block.
>
>
> Diffs
> -
>
> RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
> src/main/python/apache/thermos/common/process_util.py
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40
> src/main/python/apache/thermos/core/process.py
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802
>
> Diff: https://reviews.apache.org/r/53508/diff/
>
>
> Testing
> ---
>
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155027
---
@ReviewBot retry
- Zameer Manji
On Nov. 4, 2016, 4:54 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
>
> (Updated Nov. 4, 2016, 4:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/
> and
> wraps the `prcl(2)` call in a try except block.
>
>
> Diffs
> -
>
> RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
> src/main/python/apache/thermos/common/process_util.py
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40
> src/main/python/apache/thermos/core/process.py
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802
>
> Diff: https://reviews.apache.org/r/53508/diff/
>
>
> Testing
> ---
>
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/
---
(Updated Nov. 4, 2016, 4:54 p.m.)
Review request for Aurora, Joshua Cohen and Stephan Erb.
Repository: aurora
Description (updated)
---
The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/ and
wraps the `prcl(2)` call in a try except block.
Diffs
-
RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
src/main/python/apache/thermos/common/process_util.py
c63b9aff2a9a453ca921308baa4d1d1762ae3a40
src/main/python/apache/thermos/core/process.py
13f9ad5711edde3a0a0d47ba6db1c199434e6802
Diff: https://reviews.apache.org/r/53508/diff/
Testing
---
./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
Re: Review Request 53508: Fix regression in 5410c22.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155021
---
Master (5410c22) is red with this patch.
./build-support/jenkins/build.sh
---
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/http/Offers
Test coverage missing for org/apache/aurora/scheduler/http/Mname
Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback
Test coverage missing for org/apache/aurora/scheduler/http/Cron
Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser
Test coverage missing for
org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema
Test coverage missing for
org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader
Test coverage missing for
org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
Test coverage missing for org/apache/aurora/scheduler/filter/AttributeFilter
Test coverage missing for org/apache/aurora/scheduler/filter/ConstraintMatcher
Test coverage missing for
org/apache/aurora/scheduler/filter/SchedulingFilterImpl$1
Test coverage missing for
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
Test coverage missing for
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
Test coverage missing for
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
Test coverage missing for
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
Test coverage missing for
org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
Test coverage missing for org/apache/aurora/scheduler/storage/db/PruneVictim
Test coverage missing for
org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
Test coverage missing for
org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
Test coverage missing for org/apache/aurora/scheduler/events/Webhook
Test coverage missing for
org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
Test coverage missing for
org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for
org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
Test coverage missing for
org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for
org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
==
BUILD FAILED
Total time: 6 mins 21.609 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 4, 2016, 11:43 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53508/
> ---
>
> (Updated Nov. 4, 2016, 11:43 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> The hard dependency on `prctl` broke thermos unit tests both on Apache Jenkins
> and OS X. This adopts serb's suggestion https://reviews.apache.org/r/53418/
> and
> wraps the `prcl(2)` call in a try except box.
>
>
> Diffs
> -
>
> RELEASE-NOTES.md 94224be892c84170177d7711402268cd40ee4f87
> src/main/python/apache/thermos/common/process_util.py
> c63b9aff2a9a453ca921308baa4d1d1762ae3a40
> src/main/python/apache/thermos/core/process.py
> 13f9ad5711edde3a0a0d47ba6db1c199434e6802
>
> Diff: https://reviews.apache.org/r/53508/diff/
>
>
> Testing
> ---
>
> ./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
> src/{main,test}/python:: -- -v
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Zameer Manji
>
>
