Re: Review Request 54567: Fixup prepare_binary.sh to work under modern bash.

2016-12-08 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54567/#review158638
---


Ship it!




Ship It!

- Joshua Cohen


On Dec. 9, 2016, 3:58 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54567/
> ---
> 
> (Updated Dec. 9, 2016, 3:58 a.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Previously pushd/popd were used and these emit data to stdout muddying
> pants output and breaking setup of the thrift serve dir structure.
> 
>  build-support/thrift/prepare_binary.sh | 7 ---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> 
> Diffs
> -
> 
>   build-support/thrift/prepare_binary.sh 
> e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c 
> 
> Diff: https://reviews.apache.org/r/54567/diff/
> 
> 
> Testing
> ---
> 
> Reproduced the current master CI failure before this change on my linux 
> machine.
> Fixed with this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Review Request 54567: Fixup prepare_binary.sh to work under modern bash.

2016-12-08 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54567/
---

Review request for Aurora and Joshua Cohen.


Repository: aurora


Description
---

Previously pushd/popd were used and these emit data to stdout muddying
pants output and breaking setup of the thrift serve dir structure.

 build-support/thrift/prepare_binary.sh | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)


Diffs
-

  build-support/thrift/prepare_binary.sh 
e3b46aa1f36ed3eecc9bb7794073d18dd950eb1c 

Diff: https://reviews.apache.org/r/54567/diff/


Testing
---

Reproduced the current master CI failure before this change on my linux machine.
Fixed with this change.


Thanks,

John Sirois