Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Reza Motamedi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63375/#review189483
---


Ship it!




Ship It!

- Reza Motamedi


On Oct. 27, 2017, 7:58 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63375/
> ---
> 
> (Updated Oct. 27, 2017, 7:58 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add resource units to config summary
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/RoleQuota.js 
> bb1b6e7e5dbedf875f27caf9bc9ca28319b82c5b 
>   ui/src/main/js/components/TaskConfigSummary.js 
> b1cf5a956e0230932944f76ad8d25b356b9d8f23 
>   ui/src/main/js/utils/Quota.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63375/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2017-10-27 at 12.55.52 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/27/be64586c-3ab8-4e17-bec2-b166719da2e7__Screen_Shot_2017-10-27_at_12.55.52_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Kai Huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63375/#review189480
---


Ship it!




Ship It!

- Kai Huang


On Oct. 27, 2017, 7:58 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63375/
> ---
> 
> (Updated Oct. 27, 2017, 7:58 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add resource units to config summary
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/RoleQuota.js 
> bb1b6e7e5dbedf875f27caf9bc9ca28319b82c5b 
>   ui/src/main/js/components/TaskConfigSummary.js 
> b1cf5a956e0230932944f76ad8d25b356b9d8f23 
>   ui/src/main/js/utils/Quota.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63375/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2017-10-27 at 12.55.52 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/27/be64586c-3ab8-4e17-bec2-b166719da2e7__Screen_Shot_2017-10-27_at_12.55.52_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Re: Review Request 63375: Add resource units to config summary

2017-10-27 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63375/#review189473
---



Master (d6bc8eb) is red with this patch.
  ./build-support/jenkins/build.sh

thrift-0.9.1/tutorial/py/PythonClient.py
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
Makefile:49: recipe for target 'thrift-0.9.1/compiler/cpp/thrift' failed
make: Leaving directory 
'/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command 
> '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw''
>  finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 39s
7 actionable tasks: 1 executed, 6 up-to-date


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Oct. 27, 2017, 7:58 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63375/
> ---
> 
> (Updated Oct. 27, 2017, 7:58 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add resource units to config summary
> 
> 
> Diffs
> -
> 
>   ui/src/main/js/components/RoleQuota.js 
> bb1b6e7e5dbedf875f27caf9bc9ca28319b82c5b 
>   ui/src/main/js/components/TaskConfigSummary.js 
> b1cf5a956e0230932944f76ad8d25b356b9d8f23 
>   ui/src/main/js/utils/Quota.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63375/diff/1/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> Screen Shot 2017-10-27 at 12.55.52 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2017/10/27/be64586c-3ab8-4e17-bec2-b166719da2e7__Screen_Shot_2017-10-27_at_12.55.52_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>



Review Request 63375: Add resource units to config summary

2017-10-27 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63375/
---

Review request for Aurora, Kai Huang and Reza Motamedi.


Repository: aurora


Description
---

Add resource units to config summary


Diffs
-

  ui/src/main/js/components/RoleQuota.js 
bb1b6e7e5dbedf875f27caf9bc9ca28319b82c5b 
  ui/src/main/js/components/TaskConfigSummary.js 
b1cf5a956e0230932944f76ad8d25b356b9d8f23 
  ui/src/main/js/utils/Quota.js PRE-CREATION 


Diff: https://reviews.apache.org/r/63375/diff/1/


Testing
---

See screenshot.


File Attachments


Screen Shot 2017-10-27 at 12.55.52 PM.png
  
https://reviews.apache.org/media/uploaded/files/2017/10/27/be64586c-3ab8-4e17-bec2-b166719da2e7__Screen_Shot_2017-10-27_at_12.55.52_PM.png


Thanks,

David McLaughlin