Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review204008
---


Ship it!




Master (34be631) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 29, 2018, 7:49 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 29, 2018, 7:49 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 5e1f9940a7974e212140b7e5304695afa7f96e78 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ff48000d613ceef3e03586b94944d13275fb127c 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  fcca9a5ab36e067002f8257fc3e864cc02160207 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/3/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-29 Thread Jing Chen 


> On May 24, 2018, 9:46 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
> > Lines 171-172 (original), 172-176 (patched)
> > 
> >
> > The previous check ensured _all_ resources were non-negative. The new 
> > check only ensures that no negative value is in the list. It could however 
> > be the case that one is missing entirely.
> > 
> > Thinking about it, this is probably prevented by the validation in the 
> > ThriftBackfill class.

I believe it can be avoided by _ThriftBackfill_ from line 120 to line 125 after 
the change.


- Jing


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203818
---


On May 29, 2018, 7:49 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 29, 2018, 7:49 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 5e1f9940a7974e212140b7e5304695afa7f96e78 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ff48000d613ceef3e03586b94944d13275fb127c 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  fcca9a5ab36e067002f8257fc3e864cc02160207 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/3/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-29 Thread Jing Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/
---

(Updated May 29, 2018, 7:49 p.m.)


Review request for Aurora, Renan DelValle and Stephan Erb.


Bugs: AURORA-1975
https://issues.apache.org/jira/browse/AURORA-1975


Repository: aurora


Description
---

Remove resource properties from ResourceAggregate


Diffs (updated)
-

  RELEASE-NOTES.md 5e1f9940a7974e212140b7e5304695afa7f96e78 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
ff48000d613ceef3e03586b94944d13275fb127c 
  src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
aa68c446af7cf52f37cb72d0f115b1be39457988 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
  
src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
 4425d025b92425b19eead30ceac0bc2466bc606a 
  src/main/python/apache/aurora/client/api/__init__.py 
f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
  src/main/python/apache/aurora/config/resource.py 
b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
  
src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
 fcca9a5ab36e067002f8257fc3e864cc02160207 
  
src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
 219576baf331c44535a4e2f95fde5c906bdabe4f 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 2cf66d8154ad3795989ee9026e45af1be509f244 
  src/test/python/apache/aurora/admin/test_admin.py 
ebe89b504be57a4258eeea7e3edd053daaa30ce9 
  src/test/python/apache/aurora/client/cli/test_quota.py 
b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
  src/test/python/apache/aurora/config/test_resources.py 
3ac54909991a123b73e00c59d7269431036cda06 
  
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
 6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 


Diff: https://reviews.apache.org/r/67077/diff/3/

Changes: https://reviews.apache.org/r/67077/diff/2-3/


Testing
---

./pants test src/test/python/apache/aurora/config
./pants test src/test/python/apache/aurora/client/cli:cli
./build-support/jenkins/build.sh


Thanks,

Jing Chen

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-25 Thread Renan DelValle 


> On May 24, 2018, 2:46 p.m., Stephan Erb wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift
> > Lines 290-298 (original)
> > 
> >
> > Please add a changelog entry that explains which fields were removed 
> > from the public API.
> 
> Jing Chen wrote:
> hey Stephan, I am not sure which file exactly you are referring to. If 
> you mean RELEASE-NOTES, shall we create a new subversion? 0.20.1 or 0.21.0?

Yes, feel free to add a 0.21.0 section


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203818
---


On May 10, 2018, 8:18 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 10, 2018, 8:18 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-25 Thread Jing Chen 


> On May 24, 2018, 9:46 p.m., Stephan Erb wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift
> > Lines 290-298 (original)
> > 
> >
> > Please add a changelog entry that explains which fields were removed 
> > from the public API.

hey Stephan, I am not sure which file exactly you are referring to. If you mean 
RELEASE-NOTES, shall we create a new subversion? 0.20.1 or 0.21.0?


- Jing


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203818
---


On May 11, 2018, 3:18 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 11, 2018, 3:18 a.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-24 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203818
---


Fix it, then Ship it!




Thanks! Looks good to me overall.

I raise a concern about the place of the validation logic below. I don't feel 
super strongly about this, so I leave this decision up to you.


api/src/main/thrift/org/apache/aurora/gen/api.thrift
Lines 290-298 (original)


Please add a changelog entry that explains which fields were removed from 
the public API.



src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
Lines 171-172 (original), 172-176 (patched)


The previous check ensured _all_ resources were non-negative. The new check 
only ensures that no negative value is in the list. It could however be the 
case that one is missing entirely.

Thinking about it, this is probably prevented by the validation in the 
ThriftBackfill class.



src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
Lines 127-152 (original), 114-127 (patched)


Technically we are no longer doing a backfill of deprecated fields. Ideally 
we would move the validation to somwhere else now (e.g. 
`QuotaManagerImpl.saveQuota`).

I am happy about the refactoring overall. It is therefore fine with me to 
let this one slide.


- Stephan Erb


On May 11, 2018, 5:18 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 11, 2018, 5:18 a.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-22 Thread Renan DelValle 


> On May 22, 2018, 3:32 p.m., Renan DelValle wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
> > Lines 174 (patched)
> > 
> >
> > nit: can you put these in parentheses so that it's clearer? I.e.
> > 
> > `((resource.isSetNumCpus() && resource.getNumCpus()) 
> > ||(resource.isSetRamMb() && resource.getRamMb() < 0) || 
> > (resource.isSetDiskMb() && resource.getDiskMb() < 0))`
> 
> Jing Chen wrote:
> Hi Renan, I agree that it makes code clearer, I don't put parentheses 
> here as it breaks checkstyle which tells `Useless parentheses`.

In that case I'll drop the issue and fall back to a full ship it :)


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203607
---


On May 10, 2018, 8:18 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 10, 2018, 8:18 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-22 Thread Jing Chen 


> On May 22, 2018, 10:32 p.m., Renan DelValle wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
> > Lines 174 (patched)
> > 
> >
> > nit: can you put these in parentheses so that it's clearer? I.e.
> > 
> > `((resource.isSetNumCpus() && resource.getNumCpus()) 
> > ||(resource.isSetRamMb() && resource.getRamMb() < 0) || 
> > (resource.isSetDiskMb() && resource.getDiskMb() < 0))`

Hi Renan, I agree that it makes code clearer, I don't put parentheses here as 
it breaks checkstyle which tells `Useless parentheses`.


- Jing


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203607
---


On May 11, 2018, 3:18 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 11, 2018, 3:18 a.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-22 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review203607
---


Fix it, then Ship it!




Sorry for the radio silence on this. Looks good to me minus one nit. Thanks for 
the patch!


src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
Lines 174 (patched)


nit: can you put these in parentheses so that it's clearer? I.e.

`((resource.isSetNumCpus() && resource.getNumCpus()) 
||(resource.isSetRamMb() && resource.getRamMb() < 0) || (resource.isSetDiskMb() 
&& resource.getDiskMb() < 0))`


- Renan DelValle


On May 10, 2018, 8:18 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 10, 2018, 8:18 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-10 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review202887
---


Ship it!




Master (805a53f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 11, 2018, 3:18 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 11, 2018, 3:18 a.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/admin/test_admin.py 
> ebe89b504be57a4258eeea7e3edd053daaa30ce9 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/2/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-10 Thread Jing Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/
---

(Updated May 11, 2018, 3:18 a.m.)


Review request for Aurora, Renan DelValle and Stephan Erb.


Bugs: AURORA-1975
https://issues.apache.org/jira/browse/AURORA-1975


Repository: aurora


Description
---

Remove resource properties from ResourceAggregate


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
ef754e32172e7490a47a13e7b526f243ffa3efeb 
  src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
aa68c446af7cf52f37cb72d0f115b1be39457988 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
  
src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
 4425d025b92425b19eead30ceac0bc2466bc606a 
  src/main/python/apache/aurora/client/api/__init__.py 
f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
  src/main/python/apache/aurora/config/resource.py 
b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
  
src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
 3dd9ce4039b223cb6156462d089f7062a1cde772 
  
src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
 219576baf331c44535a4e2f95fde5c906bdabe4f 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 2cf66d8154ad3795989ee9026e45af1be509f244 
  src/test/python/apache/aurora/admin/test_admin.py 
ebe89b504be57a4258eeea7e3edd053daaa30ce9 
  src/test/python/apache/aurora/client/cli/test_quota.py 
b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
  src/test/python/apache/aurora/config/test_resources.py 
3ac54909991a123b73e00c59d7269431036cda06 
  
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
 6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 


Diff: https://reviews.apache.org/r/67077/diff/2/

Changes: https://reviews.apache.org/r/67077/diff/1-2/


Testing
---

./pants test src/test/python/apache/aurora/config
./pants test src/test/python/apache/aurora/client/cli:cli
./build-support/jenkins/build.sh


Thanks,

Jing Chen

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-10 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review202884
---



Master (805a53f) is red with this patch.
  ./build-support/jenkins/build.sh

 
src/test/python/apache/aurora/client/hooks/test_hooked_api.py::test_api_methods_params[add_instances]
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_hooked_api.py
 PASSED [ 46%]
 
src/test/python/apache/aurora/client/hooks/test_hooked_api.py::test_api_methods_params[create_job]
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_hooked_api.py
 PASSED [ 53%]
 
src/test/python/apache/aurora/client/hooks/test_hooked_api.py::test_api_methods_params[kill_job]
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_hooked_api.py
 PASSED [ 60%]
 
src/test/python/apache/aurora/client/hooks/test_hooked_api.py::test_api_methods_params[restart]
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_hooked_api.py
 PASSED [ 66%]
 
src/test/python/apache/aurora/client/hooks/test_hooked_api.py::test_api_methods_params[start_cronjob]
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_hooked_api.py
 PASSED [ 73%]
 
src/test/python/apache/aurora/client/hooks/test_hooked_api.py::test_api_methods_params[start_job_update]
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_hooked_api.py
 PASSED [ 80%]
 
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py::TestNonHookedAuroraClientAPI::test_kill_job_discards_config
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_non_hooked_api.py
 PASSED [ 86%]
 
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py::TestNonHookedAuroraClientAPI::test_restart_discards_config
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_non_hooked_api.py
 PASSED [ 93%]
 
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py::TestNonHookedAuroraClientAPI::test_start_cronjob_discards_config
 <- 
.pants.d/pyprep/sources/fc64aad6949e2d51aeb438946e8823ea4434454b/apache/aurora/client/hooks/test_non_hooked_api.py
 PASSED [100%]
 
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/test/pytest/src.test.python.apache.aurora.client.hooks.hooks/junitxml/TEST-src.test.python.apache.aurora.client.hooks.hooks.xml
 
 === 15 passed in 0.32 seconds 
 
   src.test.python.apache.aurora.admin.admin
   .   FAILURE
   src.test.python.apache.aurora.client.client  
   .   SUCCESS
   src.test.python.apache.aurora.client.api.api 
   .   SUCCESS
   src.test.python.apache.aurora.client.cli.cli 
   .   SUCCESS
   src.test.python.apache.aurora.client.docker.docker   
   .   SUCCESS
   src.test.python.apache.aurora.client.hooks.hooks 
   .   SUCCESS
   src.test.python.apache.aurora.common.common  
   .   SUCCESS
   
src.test.python.apache.aurora.common.health_check.health_check  
.   SUCCESS
   src.test.python.apache.aurora.config.config  
   .   SUCCESS
   src.test.python.apache.aurora.executor.executor  
   .   SUCCESS
   src.test.python.apache.aurora.executor.bin.bin   
   .   SUCCESS
   src.test.python.apache.aurora.executor.common.common 
   .   SUCCESS
   src.test.python.apache.aurora.tools.tools
   .   SUCCESS
   src.test.python.apache.thermos.cli.cli   
   .   SUCCESS
   src.test.python.apache.thermos.cli.commands.commands 
   .   SUCCESS
   src.test.python.apache.thermos.common.common 
   .   SUCCESS
   src.test.python.apache.thermos.config.config 
   .   SUC

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-10 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review202882
---



@ReviewBot retry

- Renan DelValle


On May 10, 2018, 5:14 p.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 10, 2018, 5:14 p.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/1/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Re: Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-10 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/#review202881
---



Master (805a53f) is red with this patch.
  ./build-support/jenkins/build.sh

Pass 2: Analyzing classes (320 / 333) - 96% complete
Pass 2: Analyzing classes (321 / 333) - 96% complete
Pass 2: Analyzing classes (322 / 333) - 96% complete
Pass 2: Analyzing classes (323 / 333) - 96% complete
Pass 2: Analyzing classes (324 / 333) - 97% complete
Pass 2: Analyzing classes (325 / 333) - 97% complete
Pass 2: Analyzing classes (326 / 333) - 97% complete
Pass 2: Analyzing classes (327 / 333) - 98% complete
Pass 2: Analyzing classes (328 / 333) - 98% complete
Pass 2: Analyzing classes (329 / 333) - 98% complete
Pass 2: Analyzing classes (330 / 333) - 99% complete
Pass 2: Analyzing classes (331 / 333) - 99% complete
Pass 2: Analyzing classes (332 / 333) - 99% complete
Pass 2: Analyzing classes (333 / 333) - 100% complete
Done with analysis
:test

org.apache.aurora.scheduler.events.WebhookTest > 
testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:251
I0511 00:38:02.073 [ShutdownHook, SchedulerMain] Stopping scheduler services. 

1080 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 8m 18s
45 actionable tasks: 36 executed, 9 up-to-date


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 11, 2018, 12:14 a.m., Jing Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67077/
> ---
> 
> (Updated May 11, 2018, 12:14 a.m.)
> 
> 
> Review request for Aurora, Renan DelValle and Stephan Erb.
> 
> 
> Bugs: AURORA-1975
> https://issues.apache.org/jira/browse/AURORA-1975
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove resource properties from ResourceAggregate
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ef754e32172e7490a47a13e7b526f243ffa3efeb 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> aa68c446af7cf52f37cb72d0f115b1be39457988 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
>   
> src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
>  4425d025b92425b19eead30ceac0bc2466bc606a 
>   src/main/python/apache/aurora/client/api/__init__.py 
> f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
>   src/main/python/apache/aurora/config/resource.py 
> b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
>  3dd9ce4039b223cb6156462d089f7062a1cde772 
>   
> src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
>  219576baf331c44535a4e2f95fde5c906bdabe4f 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2cf66d8154ad3795989ee9026e45af1be509f244 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
>   src/test/python/apache/aurora/config/test_resources.py 
> 3ac54909991a123b73e00c59d7269431036cda06 
>   
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
>  6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 
> 
> 
> Diff: https://reviews.apache.org/r/67077/diff/1/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/aurora/config
> ./pants test src/test/python/apache/aurora/client/cli:cli
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Jing Chen
> 
>

Review Request 67077: Remove resource properties from ResourceAggregate

2018-05-10 Thread Jing Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67077/
---

Review request for Aurora, Renan DelValle and Stephan Erb.


Bugs: AURORA-1975
https://issues.apache.org/jira/browse/AURORA-1975


Repository: aurora


Description
---

Remove resource properties from ResourceAggregate


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
ef754e32172e7490a47a13e7b526f243ffa3efeb 
  src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
aa68c446af7cf52f37cb72d0f115b1be39457988 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
e2750d7343a1ed83feb9f96014e9e61dc6dda1f0 
  
src/main/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfill.java
 4425d025b92425b19eead30ceac0bc2466bc606a 
  src/main/python/apache/aurora/client/api/__init__.py 
f6fd1dd6d7c2bdd5bca3037f501b36badab78c75 
  src/main/python/apache/aurora/config/resource.py 
b2ebd399ccf069b9914ac4bc624685b2cc3679b0 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
567586fcfb4dda58dc6308fe3d7fe2b7b433db98 
  
src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java
 3dd9ce4039b223cb6156462d089f7062a1cde772 
  
src/test/java/org/apache/aurora/scheduler/storage/durability/ThriftBackfillTest.java
 219576baf331c44535a4e2f95fde5c906bdabe4f 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 2cf66d8154ad3795989ee9026e45af1be509f244 
  src/test/python/apache/aurora/client/cli/test_quota.py 
b56629671035ce6bf1c3bf45c9adeb2c4f108ee8 
  src/test/python/apache/aurora/config/test_resources.py 
3ac54909991a123b73e00c59d7269431036cda06 
  
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveQuota
 6b0d8003a23b9a0e9de78eed42aed14c6b7dd492 


Diff: https://reviews.apache.org/r/67077/diff/1/


Testing
---

./pants test src/test/python/apache/aurora/config
./pants test src/test/python/apache/aurora/client/cli:cli
./build-support/jenkins/build.sh


Thanks,

Jing Chen