Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
> On Nov. 28, 2016, 4:03 p.m., Joshua Cohen wrote: > > Sorry for the delay on this, everything looks good to me, just a few > > style/maintainability nits, then it's good to go! @jcohen. I have made the necessary changes and have posted the patch for review. Thank you. - Pradyumna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review157037 --- On Nov. 28, 2016, 8:34 p.m., Pradyumna Kaushik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51993/ > --- > > (Updated Nov. 28, 2016, 8:34 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Bugs: AURORA-1762 > https://issues.apache.org/jira/browse/AURORA-1762 > > > Repository: aurora > > > Description > --- > > Added the 'reason' to the /pendingTasks endpoint > > > Diffs > - > > config/legacy_untested_classes.txt 84265066001dee79df6bc16de6de9a165e912b9b > src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java > c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > f783e7ff220573915524a1efc27141193d19fa6c > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java > b521620badff76e8fab0bdf31f8a73c4019b2121 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java > 77187bc19fb1f783d1b820d324c7fe18e509365f > src/test/java/org/apache/aurora/scheduler/http/OffersTest.java > 9e3573252cf37153180b1fc5ab9150bab0299c99 > src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/TestUtils.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > d9b3cc672f42c50b2a2a142733d26c0725bbc864 > > Diff: https://reviews.apache.org/r/51993/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Pradyumna Kaushik > >
Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review157132 --- Ship it! Master (d56f8c6) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 28, 2016, 8:34 p.m., Pradyumna Kaushik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51993/ > --- > > (Updated Nov. 28, 2016, 8:34 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Bugs: AURORA-1762 > https://issues.apache.org/jira/browse/AURORA-1762 > > > Repository: aurora > > > Description > --- > > Added the 'reason' to the /pendingTasks endpoint > > > Diffs > - > > config/legacy_untested_classes.txt 84265066001dee79df6bc16de6de9a165e912b9b > src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java > c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > f783e7ff220573915524a1efc27141193d19fa6c > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java > b521620badff76e8fab0bdf31f8a73c4019b2121 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java > 77187bc19fb1f783d1b820d324c7fe18e509365f > src/test/java/org/apache/aurora/scheduler/http/OffersTest.java > 9e3573252cf37153180b1fc5ab9150bab0299c99 > src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/TestUtils.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > d9b3cc672f42c50b2a2a142733d26c0725bbc864 > > Diff: https://reviews.apache.org/r/51993/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Pradyumna Kaushik > >
Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review157136 --- Ship it! Ship It! - Joshua Cohen On Nov. 28, 2016, 8:34 p.m., Pradyumna Kaushik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51993/ > --- > > (Updated Nov. 28, 2016, 8:34 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Bugs: AURORA-1762 > https://issues.apache.org/jira/browse/AURORA-1762 > > > Repository: aurora > > > Description > --- > > Added the 'reason' to the /pendingTasks endpoint > > > Diffs > - > > config/legacy_untested_classes.txt 84265066001dee79df6bc16de6de9a165e912b9b > src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java > c80e0c8adf80e12082a6952ae79b7d9cc960c5b6 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > f783e7ff220573915524a1efc27141193d19fa6c > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java > b521620badff76e8fab0bdf31f8a73c4019b2121 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java > 77187bc19fb1f783d1b820d324c7fe18e509365f > src/test/java/org/apache/aurora/scheduler/http/OffersTest.java > 9e3573252cf37153180b1fc5ab9150bab0299c99 > src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/TestUtils.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > d9b3cc672f42c50b2a2a142733d26c0725bbc864 > > Diff: https://reviews.apache.org/r/51993/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Pradyumna Kaushik > >
Re: Review Request 54106: SlaUtil::percentile percentiles interpolation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54106/
---
(Updated Nov. 28, 2016, 7:22 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar
Shanmugham.
Changes
---
I had two commits related to different issues mixed up. I decoupled them.
Summary (updated)
-
SlaUtil::percentile percentiles interpolation
Repository: aurora
Description
---
__Modification to SlaUtil::percentile to compute percentiles by interpolation__
The calculation of mttX (median-time-to-X) depends on the computation of
percentile values. The current implementation does not behave nicely with a
small sample size. For instance, for a given sample set of {50, 150},
50-percentile is reported to be 50. Although, 100 seems a more appropriate
return value.
This patch uses Guava's Quantile for interpolation.
Diffs (updated)
-
src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java
263647e802b664fd3ea21cef8109fb7a9252356f
src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6
src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java
eca1beebc906d3354d8c294ba466bc904bde98fa
Diff: https://reviews.apache.org/r/54106/diff/
Testing
---
Tests added and modified to match the continuous distribution.
I also exported the tests into excel and check the reports percentiles.
Thanks,
Reza Motamedi
Re: Review Request 54106: SlaUtil::percentile percentiles interpolation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54106/#review157123
---
Master (d56f8c6) is red with this patch.
./build-support/jenkins/build.sh
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
Note: Wrote forwarder
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java:179:14:
error: Unnecessary parentheses around return value.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java:17:
error: Wrong order for 'java.util.List' import. Order should be: java, javax,
scala, com, net, org. Each group should be separated by a single blank
line.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java:48:53:
error: ')' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java:50:18:
error: Assignment of parameter 'percentile' is not allowed.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 1 mins 11.587 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Nov. 28, 2016, 7:22 p.m., Reza Motamedi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54106/
> ---
>
> (Updated Nov. 28, 2016, 7:22 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar
> Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> __Modification to SlaUtil::percentile to compute percentiles by
> interpolation__
>
> The calculation of mttX (median-time-to-X) depends on the computation of
> percentile values. The current implementation does not behave nicely with a
> small sample size. For instance, for a given sample set of {50, 150},
> 50-percentile is reported to be 50. Although, 100 seems a more appropriate
> return value.
>
> This patch uses Guava's Quantile for interpolation.
>
>
> Diffs
> -
>
> src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java
> 263647e802b664fd3ea21cef8109fb7a9252356f
> src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java
> 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6
> src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java
> eca1beebc906d3354d8c294ba466bc904bde98fa
>
> Diff: https://reviews.apache.org/r/54106/diff/
>
>
> Testing
> ---
>
> Tests added and modified to match the continuous distribution.
> I also exported the tests into excel and check the reports percentiles.
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 54107: changes to intercept and time mybatis invocations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157154 --- Ship it! Master (8e07b04) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 28, 2016, 10:10 p.m., Reza Motamedi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54107/ > --- > > (Updated Nov. 28, 2016, 10:10 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad > Nurolahzade, and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > MyBatis allows us to intercept calls within the execution of a mapped > statement. This allows us to time various mapped statements and ultimately > gain more insight on the performance of the database module. > > This patch introduces an interceptor on MyBatis on `updates` and `query` > mapped statements. I used the following convention to create name for the > newly collected stats: > mybatis.<> > > After interception the process is very similar to the one in > @Timed-interceptor. SlidingStats can be used to export interval averages, > total milliseconds and the event counts. > > __example stats (from ./vars.json)__ > mybatis.create_tables_events 1 > mybatis.create_tables_events_per_sec 0.0 > mybatis.create_tables_nanos_per_event 0.0 > mybatis.create_tables_nanos_total 592633784 > mybatis.create_tables_nanos_total_per_sec 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events > 3 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events_per_sec > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_per_event > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total > 2858362 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total_per_sec > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events > 333 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events_per_sec > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_per_event > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total > 85745680 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total_per_sec > 0.0 > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > e7287cec28e7b8ca978c506bfe821f261bc0ac26 > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > 2e560c0d565689703b282391fe49dbf213ee25dc > > src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java > 7e19454568540c14f91808635bf8dff82bb3 > > Diff: https://reviews.apache.org/r/54107/diff/ > > > Testing > --- > > Tests are covered in InstrumentingInterceptorTest. > > - testStatIsCreatedOnce > Tests that each stat is created one time only. > > - testInterceptMarksMetrics > Tests that invocation is correctly intercepted and then proceeds. > > > Thanks, > > Reza Motamedi > >
Re: Review Request 54107: changes to intercept and time mybatis invocations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/ --- (Updated Nov. 28, 2016, 10:10 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad Nurolahzade, and Santhosh Kumar Shanmugham. Changes --- fixed styling issues. all checks pass now. Repository: aurora Description --- MyBatis allows us to intercept calls within the execution of a mapped statement. This allows us to time various mapped statements and ultimately gain more insight on the performance of the database module. This patch introduces an interceptor on MyBatis on `updates` and `query` mapped statements. I used the following convention to create name for the newly collected stats: mybatis.<> After interception the process is very similar to the one in @Timed-interceptor. SlidingStats can be used to export interval averages, total milliseconds and the event counts. __example stats (from ./vars.json)__ mybatis.create_tables_events 1 mybatis.create_tables_events_per_sec 0.0 mybatis.create_tables_nanos_per_event 0.0 mybatis.create_tables_nanos_total 592633784 mybatis.create_tables_nanos_total_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events 3 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_per_event 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total 2858362 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events 333 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_per_event 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total 85745680 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total_per_sec 0.0 Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e7287cec28e7b8ca978c506bfe821f261bc0ac26 src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2e560c0d565689703b282391fe49dbf213ee25dc src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java 7e19454568540c14f91808635bf8dff82bb3 Diff: https://reviews.apache.org/r/54107/diff/ Testing --- Tests are covered in InstrumentingInterceptorTest. - testStatIsCreatedOnce Tests that each stat is created one time only. - testInterceptMarksMetrics Tests that invocation is correctly intercepted and then proceeds. Thanks, Reza Motamedi
Re: Review Request 54107: changes to intercept and time mybatis invocations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/ --- (Updated Nov. 29, 2016, 2:36 a.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad Nurolahzade, and Santhosh Kumar Shanmugham. Changes --- - docs added. - now using easymock when not mocking a final class. Repository: aurora Description --- MyBatis allows us to intercept calls within the execution of a mapped statement. This allows us to time various mapped statements and ultimately gain more insight on the performance of the database module. This patch introduces an interceptor on MyBatis on `updates` and `query` mapped statements. I used the following convention to create name for the newly collected stats: mybatis.<> After interception the process is very similar to the one in @Timed-interceptor. SlidingStats can be used to export interval averages, total milliseconds and the event counts. __example stats (from ./vars.json)__ mybatis.create_tables_events 1 mybatis.create_tables_events_per_sec 0.0 mybatis.create_tables_nanos_per_event 0.0 mybatis.create_tables_nanos_total 592633784 mybatis.create_tables_nanos_total_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events 3 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_per_event 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total 2858362 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events 333 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events_per_sec 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_per_event 0.0 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total 85745680 mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total_per_sec 0.0 Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e7287cec28e7b8ca978c506bfe821f261bc0ac26 src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2e560c0d565689703b282391fe49dbf213ee25dc src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java 7e19454568540c14f91808635bf8dff82bb3 Diff: https://reviews.apache.org/r/54107/diff/ Testing --- Tests are covered in InstrumentingInterceptorTest. - testStatIsCreatedOnce Tests that each stat is created one time only. - testInterceptMarksMetrics Tests that invocation is correctly intercepted and then proceeds. Thanks, Reza Motamedi
Re: Review Request 54107: changes to intercept and time mybatis invocations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157195 --- Ship it! Master (8e07b04) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 29, 2016, 2:36 a.m., Reza Motamedi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54107/ > --- > > (Updated Nov. 29, 2016, 2:36 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, Mehrdad > Nurolahzade, and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > --- > > MyBatis allows us to intercept calls within the execution of a mapped > statement. This allows us to time various mapped statements and ultimately > gain more insight on the performance of the database module. > > This patch introduces an interceptor on MyBatis on `updates` and `query` > mapped statements. I used the following convention to create name for the > newly collected stats: > mybatis.<> > > After interception the process is very similar to the one in > @Timed-interceptor. SlidingStats can be used to export interval averages, > total milliseconds and the event counts. > > __example stats (from ./vars.json)__ > mybatis.create_tables_events 1 > mybatis.create_tables_events_per_sec 0.0 > mybatis.create_tables_nanos_per_event 0.0 > mybatis.create_tables_nanos_total 592633784 > mybatis.create_tables_nanos_total_per_sec 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events > 3 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_events_per_sec > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_per_event > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total > 2858362 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.selectAll_nanos_total_per_sec > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events > 333 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_events_per_sec > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_per_event > 0.0 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total > 85745680 > mybatis.org.apache.aurora.scheduler.storage.db.AttributeMapper.select_nanos_total_per_sec > 0.0 > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > e7287cec28e7b8ca978c506bfe821f261bc0ac26 > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java > 2e560c0d565689703b282391fe49dbf213ee25dc > > src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java > 7e19454568540c14f91808635bf8dff82bb3 > > Diff: https://reviews.apache.org/r/54107/diff/ > > > Testing > --- > > Tests are covered in InstrumentingInterceptorTest. > > - testStatIsCreatedOnce > Tests that each stat is created one time only. > > - testInterceptMarksMetrics > Tests that invocation is correctly intercepted and then proceeds. > > > Thanks, > > Reza Motamedi > >
