Re: Review Request 17332: Add a noun supporting operations on roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Changes --- I concede on the debate about whether quota or role should be the noun for the get_quota operation! Bugs: aurora-107 https://issues.apache.org/jira/browse/aurora-107 Repository: aurora Description --- Add a role noun. Currently, the only operation on roles is getting the quota associated with a role, but there are definitely others that can be added later: what packages has a role created? How many jobs is a role running? What privileges are associated with a role? How much system storage is being used by a role? Etc. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD 1019e006998b84ff5757778c05ec39881e44d7ba src/main/python/apache/aurora/client/cli/__init__.py 20ecbcf5d3a868f91922244162b516a66d24d32b src/main/python/apache/aurora/client/cli/options.py b45af3218e45150a55a4db8d41ae33c320a2c7f6 src/main/python/apache/aurora/client/cli/quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 5ba08ad95964ad609e6611d601c765c5c17dae69 src/test/python/apache/aurora/client/cli/test_quota.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py cbd544d1e5d0e68bcb94e46e827868e259099d0b Diff: https://reviews.apache.org/r/17332/diff/ Testing --- [sun-wukong incubator-aurora (user)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) test session starts platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 20 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_get_quota.py ... = 20 passed in 0.71 seconds = src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17645: added rollback_on_failure to UpdateConfig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33723 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17645/#comment63329 I would prefer for the help to make it clear what adding the parameter would do. If false, prevent update from performing a rollback. - Mark Chu-Carroll On Feb. 3, 2014, 4 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 3, 2014, 4 p.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-148 https://issues.apache.org/jira/browse/AURORA-148 Repository: aurora Description --- added rollback_on_failure to UpdateConfig Diffs - src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/python/apache/aurora/client/api/updater_util.py 623b0c0ae53d32f0af20c98aa4c9c1ff73720ecb src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/config/schema/base.py 1d9f3019d2379e25ab311b45f2851de3b60e263a src/test/python/apache/aurora/client/api/test_restarter.py c53824236895d60a61935a0706ad397900aa1148 src/test/python/apache/aurora/client/api/test_updater.py eabb938ead5b3bab067339ae085dbe2fd262d6a7 Diff: https://reviews.apache.org/r/17645/diff/ Testing --- [drobinson@x1 incubator-aurora (drobinson/rollback_on_failure)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. 2 passed in 0.23 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. 6 passed in 0.29 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. 6 passed in 0.12 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . 1 passed in 0.09 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. 6 passed in 0.11 seconds = === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... == 47 passed, 1 skipped in 0.44 seconds === === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py 20 passed in 0.13 seconds === test session starts === platform linux2 -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py
Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/ --- (Updated Feb. 5, 2014, 8:42 p.m.) Review request for Aurora and Brian Wickman. Changes --- Move thrift imports back to being with the third party imports. Bugs: AURORA-157 https://issues.apache.org/jira/browse/AURORA-157 Repository: aurora Description --- AURORA-157: Reorder python imports to be consistent Move python imports to adhere to the following order: - standard library deps - apache.* deps - gen.* (code generated) deps - within-package (.-prefixed) deps - third party deps Diffs (updated) - src/main/python/apache/aurora/admin/mesos_maintenance.py ab5e912f8878ad97ecc42cfcc27d13cd2336b390 src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727 src/main/python/apache/aurora/client/api/disambiguator.py d163a180610de069615cc3df8343365a5cf895d0 src/main/python/apache/aurora/client/api/health_check.py bd2bcaadb43a34ba4c3b860ab2d42b764feec008 src/main/python/apache/aurora/client/api/instance_watcher.py dcfae5a8f5921e1c2227c2275ef7b0f3cac678fb src/main/python/apache/aurora/client/api/job_monitor.py 2ca417b4fecac2a352113c606141b71d98d90d4b src/main/python/apache/aurora/client/api/quota_check.py 46701f21a6f95022755f89656dc0a72264a5800f src/main/python/apache/aurora/client/api/restarter.py 9a1fcdc14af0f2e0e3300e8128caa0553726e878 src/main/python/apache/aurora/client/api/scheduler_client.py 18f9790714b02ba1aedb2bbe3dff9d49773dda6a src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/python/apache/aurora/client/base.py 3ccbcf32cf4a8fcbcb6bce5440fc40295db57aa0 src/main/python/apache/aurora/client/bin/aurora_admin.py efbbb6f0fd65971756c20eedab8a1b5e8eba14ba src/main/python/apache/aurora/client/bin/aurora_client.py fa8b51459935d8678567eb1e69b6a31897a358e0 src/main/python/apache/aurora/client/cli/context.py b54c5a0693546f6c5a37797c2ca993c17bc597ec src/main/python/apache/aurora/client/commands/admin.py 96f7f7088261eb1b876f4b7214fb808696fb624a src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/client/commands/help.py 29002c682959033463145368221762ca538fd133 src/main/python/apache/aurora/client/commands/run.py 0725999cfd2216774478d85ff476634e76bef9cd src/main/python/apache/aurora/client/commands/ssh.py 4ccf7f528ad89a3482a1282e7f56befab74e465c src/main/python/apache/aurora/client/config.py d96376a02c1e027cce364891f40ef4c41ffba007 src/main/python/apache/aurora/client/factory.py 6635ec090d03da4c373bf2e7fdfe7c4dc82c8c08 src/main/python/apache/aurora/client/hooks/hooked_api.py 532f385bd66fba2993c02fe94ebad19e742cb7d2 src/main/python/apache/aurora/common/aurora_job_key.py 4ab6b39175ac7e1914035bdf180c47e84b035748 src/main/python/apache/aurora/common/clusters.py aab7fb6b15ab5aebf61dabd67f06034137fa442c src/main/python/apache/aurora/config/repl.py d3d239860364745e4de6569a2e50499bd64a42d2 src/main/python/apache/aurora/config/thrift.py 5546a1e91263fb69aa9da62b98083f3b4934d27a src/main/python/apache/aurora/executor/bin/gc_executor_main.py 1a24b9fdba85bb7e303ff7878e1a239f627c2c8e src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 1f3f8309a28584a5457c85840aec6e3db1c86354 src/main/python/apache/aurora/executor/bin/thermos_runner_main.py f35034769ceddfd5eceb85d8f196069c0e40ace9 src/main/python/apache/aurora/executor/common/health_checker.py 84cfe99e6523203821fb0f59c9b721c84b18c771 src/main/python/apache/aurora/executor/common/task_info.py 544c1c10d74f4e06129490b19973d3132b5081fe src/main/python/apache/aurora/executor/executor_base.py 2b0b5f48db99e176e0ba9186f139428c828ec63d src/main/python/apache/aurora/executor/executor_vars.py a5294aaaf15fcef51e73f59050c4a4f4e8fcfa31 src/main/python/apache/aurora/executor/gc_executor.py 709d8c6997538cf4c0491de3fb18e329b4b82992 src/main/python/apache/aurora/executor/status_manager.py 54b6053f508bd196accdd3c132c29f324920b5cb src/main/python/apache/aurora/executor/thermos_executor.py edb09a83f5fb69d037b41091757746c55ddd2d2c src/main/python/apache/aurora/executor/thermos_runner.py 4749e5e1e8913db9433978b8024a588d2ca39858 src/main/python/apache/aurora/executor/thermos_task_runner.py 4fee8631f0c6be18f1721d0c1ace622f502b1de9 src/main/python/apache/thermos/bin/thermos.py a80bf1d38c6c929b2cffb56375026c906997a2a7 src/main/python/apache/thermos/bin/thermos_ckpt.py 515abb5d0a618d1d029b5a7b2bf25bec18392e5e src/main/python/apache/thermos/common/ckpt.py 7dcb07e1f10159b1beed62ff3f7c34fa37a10cac src/main/python/apache/thermos/config/bin/config_load.py d7728ab6e991e0ef32be81ebef35809df279ce89
Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33742 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 5:59 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/ --- (Updated Feb. 4, 2014, 5:59 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-192 https://issues.apache.org/jira/browse/AURORA-192 Repository: aurora Description --- Removing JobConfigValidation from populateJobConfig RPC to finalize migration to client quota checks. Diffs - src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 15ff590ecebe8d87ba66a55ed176fb22122b354a src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 8ad24f9762854fa8f1ed19dfd95ca4a50640cbf3 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 479c2d9b3ee522d7feb125f5dea0973abb5b18b6 src/main/python/apache/aurora/client/api/__init__.py fbdf2b3f98d1b96da72dee98bc0b74ec1b79e243 src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/thrift/org/apache/aurora/gen/api.thrift 77cd09ec91afc98910a867c2632c790a8e0a72ce src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 79f09cd856be28f227fc76fb5a8e3298fb785a3a src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02b7a27e0a9ec5226d9d043de8bf4739fb151b09 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 62fc8045f6a5fda234df73452685bd04e3142aaf src/test/python/apache/aurora/client/api/test_updater.py eabb938ead5b3bab067339ae085dbe2fd262d6a7 src/test/resources/org/apache/aurora/gen/api.thrift.md5 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d Diff: https://reviews.apache.org/r/17729/diff/ Testing --- gradle clean build ./pants src/test/python/apache/aurora:all aurora_client diff/update in vagrant with/without JobConfigValidation in api.thrift Thanks, Maxim Khutornenko
Review Request 17768: AURORA-193: License header cleanup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17768/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-193 https://issues.apache.org/jira/browse/AURORA-193 Repository: aurora Description --- AURORA-193: License header cleanup Reverting the gradle license header plugin from commit b493b91. The sourceSet exludes is modifying the global sourceSet and causing the tests to break. Diffs - build.gradle 5b98659b9cb93a25f0f196285910cf6afb416072 Diff: https://reviews.apache.org/r/17768/diff/ Testing --- $ ./gradlew clean build --stacktrace make: Nothing to be done for `all'. All checksums match. :clean :about :bootstrapThrift UP-TO-DATE :generateSources :compileGeneratedJava Note: Some input files use unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :processGeneratedResources UP-TO-DATE :generatedClasses :compileJava Note: Writing file:/Users/jake.farrell/sandbox/apache/aurora/trunk/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :checkstyleMain :compileTestJava :processTestResources :testClasses :checkstyleTest :test :jacocoTestReport Coverage report generated: file:Users/jcf/sandbox/apache/aurora/trunk/dist/reports/jacoco/test/html/index.html :check :build BUILD SUCCESSFUL Thanks, Jake Farrell
Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/#review33748 --- Committed: commit c18a8e53d16a7d6fe5c16ac0a3713d511d1ea863 Author: Dan Norris protoch...@gmail.com Date: Wed Feb 5 16:43:36 2014 -0800 AURORA-157: Reorder python imports to be consistent Move python imports to adhere to the following order: - standard library deps - apache.* deps - gen.* (code generated) deps - within-package (.-prefixed) deps - third party deps Testing Done: ./gradlew build ./pants src/test/python:all -vxs Bugs closed: AURORA-157 Reviewed at https://reviews.apache.org/r/17734/ - Brian Wickman On Feb. 5, 2014, 8:42 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/ --- (Updated Feb. 5, 2014, 8:42 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-157 https://issues.apache.org/jira/browse/AURORA-157 Repository: aurora Description --- AURORA-157: Reorder python imports to be consistent Move python imports to adhere to the following order: - standard library deps - apache.* deps - gen.* (code generated) deps - within-package (.-prefixed) deps - third party deps Diffs - src/main/python/apache/aurora/admin/mesos_maintenance.py ab5e912f8878ad97ecc42cfcc27d13cd2336b390 src/main/python/apache/aurora/client/api/command_runner.py c645e9556b50b332cc5a298ceee3d9188a68a727 src/main/python/apache/aurora/client/api/disambiguator.py d163a180610de069615cc3df8343365a5cf895d0 src/main/python/apache/aurora/client/api/health_check.py bd2bcaadb43a34ba4c3b860ab2d42b764feec008 src/main/python/apache/aurora/client/api/instance_watcher.py dcfae5a8f5921e1c2227c2275ef7b0f3cac678fb src/main/python/apache/aurora/client/api/job_monitor.py 2ca417b4fecac2a352113c606141b71d98d90d4b src/main/python/apache/aurora/client/api/quota_check.py 46701f21a6f95022755f89656dc0a72264a5800f src/main/python/apache/aurora/client/api/restarter.py 9a1fcdc14af0f2e0e3300e8128caa0553726e878 src/main/python/apache/aurora/client/api/scheduler_client.py 18f9790714b02ba1aedb2bbe3dff9d49773dda6a src/main/python/apache/aurora/client/api/updater.py 61e5737cc3cb4d457348cbc1df1f0fc93143de51 src/main/python/apache/aurora/client/base.py 3ccbcf32cf4a8fcbcb6bce5440fc40295db57aa0 src/main/python/apache/aurora/client/bin/aurora_admin.py efbbb6f0fd65971756c20eedab8a1b5e8eba14ba src/main/python/apache/aurora/client/bin/aurora_client.py fa8b51459935d8678567eb1e69b6a31897a358e0 src/main/python/apache/aurora/client/cli/context.py b54c5a0693546f6c5a37797c2ca993c17bc597ec src/main/python/apache/aurora/client/commands/admin.py 96f7f7088261eb1b876f4b7214fb808696fb624a src/main/python/apache/aurora/client/commands/core.py 8dc4917df7e0d699ee144b4e8fbede6ac05157c2 src/main/python/apache/aurora/client/commands/help.py 29002c682959033463145368221762ca538fd133 src/main/python/apache/aurora/client/commands/run.py 0725999cfd2216774478d85ff476634e76bef9cd src/main/python/apache/aurora/client/commands/ssh.py 4ccf7f528ad89a3482a1282e7f56befab74e465c src/main/python/apache/aurora/client/config.py d96376a02c1e027cce364891f40ef4c41ffba007 src/main/python/apache/aurora/client/factory.py 6635ec090d03da4c373bf2e7fdfe7c4dc82c8c08 src/main/python/apache/aurora/client/hooks/hooked_api.py 532f385bd66fba2993c02fe94ebad19e742cb7d2 src/main/python/apache/aurora/common/aurora_job_key.py 4ab6b39175ac7e1914035bdf180c47e84b035748 src/main/python/apache/aurora/common/clusters.py aab7fb6b15ab5aebf61dabd67f06034137fa442c src/main/python/apache/aurora/config/repl.py d3d239860364745e4de6569a2e50499bd64a42d2 src/main/python/apache/aurora/config/thrift.py 5546a1e91263fb69aa9da62b98083f3b4934d27a src/main/python/apache/aurora/executor/bin/gc_executor_main.py 1a24b9fdba85bb7e303ff7878e1a239f627c2c8e src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 1f3f8309a28584a5457c85840aec6e3db1c86354 src/main/python/apache/aurora/executor/bin/thermos_runner_main.py f35034769ceddfd5eceb85d8f196069c0e40ace9 src/main/python/apache/aurora/executor/common/health_checker.py 84cfe99e6523203821fb0f59c9b721c84b18c771 src/main/python/apache/aurora/executor/common/task_info.py 544c1c10d74f4e06129490b19973d3132b5081fe src/main/python/apache/aurora/executor/executor_base.py 2b0b5f48db99e176e0ba9186f139428c828ec63d src/main/python/apache/aurora/executor/executor_vars.py a5294aaaf15fcef51e73f59050c4a4f4e8fcfa31
Re: Review Request 17771: AURORA-193: Fix license plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/#review33749 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 6, 2014, 1:27 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/ --- (Updated Feb. 6, 2014, 1:27 a.m.) Review request for Aurora, Jake Farrell and Maxim Khutornenko. Bugs: AURORA-193 https://issues.apache.org/jira/browse/AURORA-193 Repository: aurora Description --- Copy sourceSets instead of mutating it. Currently available here https://paste.apache.org/2wK3 Diffs - Diff: https://reviews.apache.org/r/17771/diff/ Testing --- ./gradlew clean build Thanks, Kevin Sweeney
