Re: Review Request 19565: Role and Role/env pages for Scheduler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/#review38325 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java https://reviews.apache.org/r/19565/#comment70369 This method makes for difficult-to-read call-sites. How about silent=true for everything to remove the extra flag? You can then add the /scheduler link to / with: Registration.registerEndpoint(binder(), /scheduler); src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html https://reviews.apache.org/r/19565/#comment70380 Consider removing the spaces on the LHS of colons: Role: myRole Environment: myEnv as opposed to Role : myRole Environment : myEnv src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html https://reviews.apache.org/r/19565/#comment70379 Is the extra if redundant here? src/main/resources/org/apache/aurora/scheduler/http/ui/home.html https://reviews.apache.org/r/19565/#comment70381 columnCollection and rowCollection probably aren't the most informative names. Can you be more descriptive? src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70390 DRY src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70392 Why not: $scope.showResources = !$scope.showResources; $scope.resourceButtonText = ($scope.showResources ? 'Show' : 'Hide') + ' Resource Consumption'; src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70396 missing semicolon src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70397 Does it make sense to s/cronJobName/jobName/, then you can reuse the sort function? (This also results in more consistent naming.) You could take this a step further to declare a local function that produces the basic information for a job (role, environment, name), and decorate that with the type-specific fields. Your call on that part. src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70395 missing semicolon src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70393 missing semicolon src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js https://reviews.apache.org/r/19565/#comment70394 missing semicolon src/main/resources/org/apache/aurora/scheduler/http/ui/role.html https://reviews.apache.org/r/19565/#comment70382 This is a copy-paste from home.html, and will probably drift. Can you use a fragment instead? src/main/resources/org/apache/aurora/scheduler/http/ui/role.html https://reviews.apache.org/r/19565/#comment70387 Right now you have a 'global' scope with: title error reloadMsg errorMsg columnCollection role environment quotaError quotaErrorMsg jobsTableConfig jobsTableColumns cronJobsTableConfig cronJobsTableColumns showResources resourceButtonText (possibly more that i've missed) And some of these have relationships. It would be nice to have relationships follow the scoping (i shouldn't have an errorMsg or reloadMsg without an error). Laying out a scoping convention early will also help define the pattern before the scope becomes unwieldy. src/main/resources/org/apache/aurora/scheduler/http/ui/role.html https://reviews.apache.org/r/19565/#comment70388 funky indent? - Bill Farner On March 23, 2014, 4:35 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 23, 2014, 4:35 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-39 https://issues.apache.org/jira/browse/AURORA-39 Repository: aurora Description --- Implemented the scheduler role and role/env pages using AngularJS. Added angular route and underscore.js modules. Diffs - 3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38336 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment70402 if instances_arg is optional, make instances_arg=None here and drop the explicit 'None' being passed elsewhere src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment70399 is this the right print function now? src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment70400 print_err? src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment70401 this error message looks invalid now src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/19431/#comment70403 passing all here will result in a ValueError from the int(x[0]), so that should probably be caught and signaled to the user as a human-readable error message. - Brian Wickman On March 22, 2014, 2:14 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 22, 2014, 2:14 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-268 https://issues.apache.org/jira/browse/aurora-268 Repository: aurora Description --- Add instance specifier syntax to commands that can specify instances for clientv2. Also, while I was at it, I added the kill/killall distinction to clientv2. Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19431/diff/ Testing --- [sun-wukong incubator-aurora (instance-syntax)]$ !./p ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 27 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.50 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 --
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 24, 2014, 2:58 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- Another round of review changes. Bugs: aurora-268 https://issues.apache.org/jira/browse/aurora-268 Repository: aurora Description --- Add instance specifier syntax to commands that can specify instances for clientv2. Also, while I was at it, I added the kill/killall distinction to clientv2. Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19431/diff/ Testing --- [sun-wukong incubator-aurora (instance-syntax)]$ !./p ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 27 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.50 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.53 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.50 seconds === src.test.python.apache.aurora.client.cli.bridge . SUCCESS src.test.python.apache.aurora.client.cli.help . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS [sun-wukong incubator-aurora (instance-syntax)]$ [sun-wukong incubator-aurora (instance-syntax)]$ grep
Re: Review Request 19431: Add instance specifier syntax to clientv2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38338 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19431/#comment70404 I think that the code is clearer when it's explicit that instances is a required parameter, and that we're deliberately passing None as a signal. src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/19431/#comment70406 all was never revealed to users, and we've decided to get rid of it. It will never show up in a user-visible way; mentioning it here will just be confusing. - Mark Chu-Carroll On March 22, 2014, 10:14 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 22, 2014, 10:14 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-268 https://issues.apache.org/jira/browse/aurora-268 Repository: aurora Description --- Add instance specifier syntax to commands that can specify instances for clientv2. Also, while I was at it, I added the kill/killall distinction to clientv2. Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19431/diff/ Testing --- [sun-wukong incubator-aurora (instance-syntax)]$ !./p ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_help.py . === 5 passed in 0.48 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 27 passed in 1.63 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_plugins.py .. === 2 passed in 0.49 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 3 items src/test/python/apache/aurora/client/cli/test_quota.py ... === 3 passed in 0.50 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.53 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items
Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API
On March 21, 2014, 11:53 p.m., Bill Farner wrote: src/test/python/apache/aurora/client/cli/test_quota.py, line 47 https://reviews.apache.org/r/19509/diff/2/?file=532010#file532010line47 Currently, the mocked calls can't detect renamed and missing thrift structs. This is one unfortunate aspect of the thrift API, you can set arbitrary attributes. However, you can harden the tests a bit more if you use the constructors. These would trip up on a refactor. I find the python repl in pants helpful to see the APIs (see below). I suggest taking the route of using constructors everywhere, probably introducing a helper method or two to cut down on the verbosity. $ ./pants py src/main/thrift/org/apache/aurora/gen:py-thrift-packaged Python 2.6.8 (unknown, Aug 25 2013, 00:04:29) [GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin Type help, copyright, credits or license for more information. (InteractiveConsole) from gen.apache.aurora.ttypes import * help(GetQuotaResult) Help on class GetQuotaResult in module gen.apache.aurora.ttypes: class GetQuotaResult(__builtin__.object) | Attributes: | - quota | - prodConsumption | - nonProdConsumption | | Methods defined here: | | __eq__(self, other) | | __init__(self, quota=None, prodConsumption=None, nonProdConsumption=None) Agreed that a constructing an object using the constructor is the best way here. Updated the code. On March 21, 2014, 11:53 p.m., Bill Farner wrote: src/test/python/apache/aurora/client/cli/test_quota.py, line 77 https://reviews.apache.org/r/19509/diff/2/?file=532010#file532010line77 Be consistent about single and double quotes, here and below. That said, this might be easier to grok with a multiline string: '''Allocated: CPU: 5 RAM: 20.00 GB Disk: 40.00 GB''' While you're at it, can you add formatting to the float values? %g as opposed to %s is probably appropriate. We are already using %f here which per the docs is a human readable version of %g. So, leaving it as is. Updated quoting to be consistent. Looked into using a multi-line string, but the text doesn't format that well because of additional spaces in the output. Since this is also the output users see and is a stylistic change, refraining from making any output format changes in this diff. On March 21, 2014, 11:53 p.m., Bill Farner wrote: src/test/python/apache/aurora/client/cli/test_quota.py, line 91 https://reviews.apache.org/r/19509/diff/2/?file=532010#file532010line91 Thanks for this coverage! Do you know if the JSON stuff will be brittle w.r.t. field ordering? That's bitten us in the past. In these cases, it's probably best to deserialize the json coming from the SUT and check for object (dict) equality. Good one. Updated the code, to turn json into dict and comparing the dicts. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38235 --- On March 21, 2014, 10:14 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 21, 2014, 10:14 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-246 https://issues.apache.org/jira/browse/AURORA-246 Repository: aurora Description --- Updated the client to consume the new getQuota API which contains nonProdConsumption(resources consumed by non-prod tasks) information also. Currently, the mocked calls can't detect renamed and missing thrift structs. Added tests to look for expected fields in GetQuotaResult and ResourceAggregate structs. Refactored tests in test_quota to remove duplicated code and added a missing test. Diffs - src/main/python/apache/aurora/client/cli/quota.py d06f21a80575058aefa3dffc72b365805d7a5ce2 src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/test/python/apache/aurora/client/cli/test_quota.py 44afd74aa5b11296951f45fe7edca8cb58b0ec18 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 27b745ea31189a0ea0731619eb4c06f802aa04b9 Diff: https://reviews.apache.org/r/19509/diff/ Testing --- ./pants src/test/python:all -vxs Works for all quota related test. src.test.python.apache.thermos.bin.test_thermos fails on my laptop because of build issues. Sending out a code review since it is an un-related issue. Will look into
Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 24, 2014, 8:47 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Changes --- updated code per Bill's comments. Bugs: AURORA-246 https://issues.apache.org/jira/browse/AURORA-246 Repository: aurora Description --- Updated the client to consume the new getQuota API which contains nonProdConsumption(resources consumed by non-prod tasks) information also. Currently, the mocked calls can't detect renamed and missing thrift structs. Added tests to look for expected fields in GetQuotaResult and ResourceAggregate structs. Refactored tests in test_quota to remove duplicated code and added a missing test. Diffs (updated) - src/main/python/apache/aurora/client/cli/quota.py d06f21a80575058aefa3dffc72b365805d7a5ce2 src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/test/python/apache/aurora/client/cli/test_quota.py 44afd74aa5b11296951f45fe7edca8cb58b0ec18 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 27b745ea31189a0ea0731619eb4c06f802aa04b9 Diff: https://reviews.apache.org/r/19509/diff/ Testing --- ./pants src/test/python:all -vxs Works for all quota related test. src.test.python.apache.thermos.bin.test_thermos fails on my laptop because of build issues. Sending out a code review since it is an un-related issue. Will look into this tomorrow, if it's a blocker. Found all the code to update by running the following query. ? git:(mansu/AURORA-246_getQuotaAPI) ag getQuotaResult -G '.py' ~/workspace/incubator-aurora src/main/python/apache/aurora/client/api/quota_check.py 90:allocated = CapacityRequest(resp.result.getQuotaResult.quota) 91:consumed = CapacityRequest(resp.result.getQuotaResult.prodConsumption) src/main/python/apache/aurora/client/cli/quota.py 65: return serialize(quota_resp.result.getQuotaResult, 69: result += get_quota_str(quota_resp.result.getQuotaResult.quota) 70: if quota_resp.result.getQuotaResult.prodConsumption: 72:result += get_quota_str(quota_resp.result.getQuotaResult.prodConsumption) 73: if quota_resp.result.getQuotaResult.nonProdConsumption: 75:result += get_quota_str(quota_resp.result.getQuotaResult.nonProdConsumption) src/main/python/apache/aurora/client/commands/admin.py 199: quota = resp.result.getQuotaResult.quota src/main/python/apache/aurora/client/commands/core.py 632: print_quota(resp.result.getQuotaResult.quota, 'Total allocated quota', role) 634: if resp.result.getQuotaResult.prodConsumption: 635:print_quota(resp.result.getQuotaResult.prodConsumption, 639: if resp.result.getQuotaResult.nonProdConsumption: 640:print_quota(resp.result.getQuotaResult.nonProdConsumption, src/test/python/apache/aurora/client/api/test_quota_check.py 49:getQuotaResult=GetQuotaResult( src/test/python/apache/aurora/client/cli/test_quota.py 35:response.result.getQuotaResult = GetQuotaResult() 36:response.result.getQuotaResult.quota = ResourceAggregate() 37:response.result.getQuotaResult.quota.numCpus = 5 38:response.result.getQuotaResult.quota.ramMb = 20480 39:response.result.getQuotaResult.quota.diskMb = 40960 40:response.result.getQuotaResult.consumed = None 47:response.result.getQuotaResult = GetQuotaResult() 48:response.result.getQuotaResult.quota = ResourceAggregate() 49:response.result.getQuotaResult.quota.numCpus = 5 50:response.result.getQuotaResult.quota.ramMb = 20480 51:response.result.getQuotaResult.quota.diskMb = 40960 52:response.result.getQuotaResult.prodConsumption = ResourceAggregate() 53:response.result.getQuotaResult.prodConsumption.numCpus = 1 54:response.result.getQuotaResult.prodConsumption.ramMb = 1024 55:response.result.getQuotaResult.prodConsumption.diskMb = 2048 56:response.result.getQuotaResult.nonProdConsumption = ResourceAggregate() 57:response.result.getQuotaResult.nonProdConsumption.numCpus = 1 58:response.result.getQuotaResult.nonProdConsumption.ramMb = 1024 59:response.result.getQuotaResult.nonProdConsumption.diskMb = 2048 ? git:(mansu/AURORA-246_getQuotaAPI) ~/workspace/incubator-aurora Thanks, Suman Karumuri
Re: Review Request 17056: fix dependencies for setup_py
On March 21, 2014, 3:07 p.m., Bill Farner wrote: Update or discard? Ping? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38108 --- On Jan. 17, 2014, 6:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17042: Add a web interface to the zookeeper instance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17042/#review38366 --- Ship it! Ship It! - Kevin Sweeney On Feb. 9, 2014, 10:40 p.m., Tobias Weingartner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17042/ --- (Updated Feb. 9, 2014, 10:40 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Add a web interface to the zookeeper instance. Diffs - examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 Diff: https://reviews.apache.org/r/17042/diff/ Testing --- $ vagrant up zookeeper # point web browser at 192.168.33.2:8080 Thanks, Tobias Weingartner
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38378 --- crap, i missed this. will merge/repost/submit. - Brian Wickman On Jan. 17, 2014, 6:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated March 24, 2014, 10:16 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- merged master Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs (updated) - src/main/python/apache/aurora/client/BUILD fafd055d8c51c24c8ded56f4316b7f6ddd96ac28 src/main/python/apache/aurora/common/BUILD ce73f93b37d96c5667a6b9bef66b8e7521f0cd83 src/main/python/apache/thermos/core/BUILD 6da1a61f328edaa0eed2fe02c8c5bdcdbda751c3 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38379 --- ping? - Mark Chu-Carroll On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 21, 2014, 2:58 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-283 https://issues.apache.org/jira/browse/aurora-283 Repository: aurora Description --- Add batching to the kill and killall commands. (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/) Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6 src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953 src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19466/diff/ Testing --- [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.35 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.57 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ... == 27 passed in 0.64 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38381 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19466/#comment70471 You don't need [] in within set() src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19466/#comment70473 I thought you were going with the max_total_failures approach, did you change your mind? - Maxim Khutornenko On March 21, 2014, 6:58 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 21, 2014, 6:58 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-283 https://issues.apache.org/jira/browse/aurora-283 Repository: aurora Description --- Add batching to the kill and killall commands. (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/) Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6 src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953 src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19466/diff/ Testing --- [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.35 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.57 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38387 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19466/#comment70485 I did. I screwed up again, uploaded the change to the wrong review. Stupid. I get completely screwed up when I try to juggle too many open reviews at once. Sorry. - Mark Chu-Carroll On March 21, 2014, 2:58 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 21, 2014, 2:58 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-283 https://issues.apache.org/jira/browse/aurora-283 Repository: aurora Description --- Add batching to the kill and killall commands. (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/) Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6 src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py aa23d5bfe81361243d82aadf9dc574608e28d953 src/test/python/apache/aurora/client/cli/test_update.py 51858b9e4ca02c2ae2151275fff9936460936bb4 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19466/diff/ Testing --- [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.35 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.57 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ...
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 24, 2014, 7:21 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Changes --- Upload to the right review. Bugs: aurora-283 https://issues.apache.org/jira/browse/aurora-283 Repository: aurora Description --- Add batching to the kill and killall commands. (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/) Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19466/diff/ Testing --- [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.35 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.57 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ... == 27 passed in 0.64 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. === 6 passed in 0.15 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_sla.py ... == 27 passed in 0.26 seconds === = test session starts
Re: Review Request 19396: Implement client command logging with a unique token.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38390 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 7:06 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/ --- (Updated March 21, 2014, 7:06 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-276 https://issues.apache.org/jira/browse/aurora-276 Repository: aurora Description --- Adding a centralized logger interface for clientv2. For the aurora analytics work, we need some hooks for logging. We'd like all client logging to go through a common interface, and for client logs that might be sent to the centralized logging service to be tagged with identifiers and userids. This change implements a simple minimal logging function that's used by clientv2 logging calls, and which attaches a universally unique client identifier to each log message. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 4a6a7eef7b781be79a3d40776a3bd6f0c6e8c4c0 src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/test/python/apache/aurora/client/cli/BUILD a48284c8cffa64b56760f8e0c587506caf1289a6 src/test/python/apache/aurora/client/cli/test_logging.py PRE-CREATION Diff: https://reviews.apache.org/r/19396/diff/ Testing --- = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.46 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.45 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.39 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.36 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.59 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ... == 27 passed in 0.64 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. === 6 passed in 0.15 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 --
Re: Review Request 19565: Role and Role/env pages for Scheduler
On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 225 https://reviews.apache.org/r/19565/diff/1/?file=533620#file533620line225 This method makes for difficult-to-read call-sites. How about silent=true for everything to remove the extra flag? You can then add the /scheduler link to / with: Registration.registerEndpoint(binder(), /scheduler); Yeah, this is better. Changed. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html, line 5 https://reviews.apache.org/r/19565/diff/1/?file=533622#file533622line5 Consider removing the spaces on the LHS of colons: Role: myRole Environment: myEnv as opposed to Role : myRole Environment : myEnv I wanted to remove them but wasn't sure if they were intentional so left them there. Removed now. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html, line 7 https://reviews.apache.org/r/19565/diff/1/?file=533622#file533622line7 Is the extra if redundant here? yes. Removed. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/home.html, line 19 https://reviews.apache.org/r/19565/diff/1/?file=533623#file533623line19 columnCollection and rowCollection probably aren't the most informative names. Can you be more descriptive? Changed. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 56 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line56 DRY Refactored error handling logic into a directive for more dryness. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 81 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line81 Why not: $scope.showResources = !$scope.showResources; $scope.resourceButtonText = ($scope.showResources ? 'Show' : 'Hide') + ' Resource Consumption'; Changed. Preferring separate strings for the button text separate since we can change the text in future without changing the logic or for i18n purposes. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 88 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line88 missing semicolon added On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 205 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line205 Does it make sense to s/cronJobName/jobName/, then you can reuse the sort function? (This also results in more consistent naming.) You could take this a step further to declare a local function that produces the basic information for a job (role, environment, name), and decorate that with the type-specific fields. Your call on that part. Good idea. Changed. Not taking it a step further, since this code more simpler to understand. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 212 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line212 missing semicolon Fixed. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 215 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line215 missing semicolon fixed On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 231 https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line231 missing semicolon fixed On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/role.html, line 2 https://reviews.apache.org/r/19565/diff/1/?file=533630#file533630line2 This is a copy-paste from home.html, and will probably drift. Can you use a fragment instead? Turned it into a directive. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/role.html, line 20 https://reviews.apache.org/r/19565/diff/1/?file=533630#file533630line20 funky indent? Fixed. On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/role.html, line 5 https://reviews.apache.org/r/19565/diff/1/?file=533630#file533630line5 Right now you have a 'global' scope with: title error reloadMsg errorMsg
Re: Review Request 19466: Add batching to the kill and killall commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38401 --- Ship it! src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19466/#comment70532 I would add something like: max_allowed:%s, actual errors:%s src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/19466/#comment70534 Unrelated: why do we have --rollback-on-failure in restart command? - Maxim Khutornenko On March 24, 2014, 11:21 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/ --- (Updated March 24, 2014, 11:21 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-283 https://issues.apache.org/jira/browse/aurora-283 Repository: aurora Description --- Add batching to the kill and killall commands. (Note that this is currently a diff relative to https://reviews.apache.org/r/19431/) Diffs - src/main/python/apache/aurora/client/cli/context.py dad4fcb63c7d7b6bce898b1a4202425f5a0d70fe src/main/python/apache/aurora/client/cli/jobs.py 3a68cf8dadcf2984a3ed97e7213cdf1fa9cb9fa4 src/main/python/apache/aurora/client/cli/options.py 1f33ea293969326c4e8cbd39e54b173f659e61bf src/main/python/apache/aurora/client/cli/task.py 8d4d38efbd126911f46bc3f8944e81bc9d149e32 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/test/python/apache/aurora/client/cli/test_kill.py 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa src/test/python/apache/aurora/client/cli/test_restart.py 7547bd79f059c9d535db926d882abc0b46f9d046 src/test/python/apache/aurora/client/cli/util.py db65eee3aeba651f3dedc76233f589a7b22020e8 Diff: https://reviews.apache.org/r/19466/diff/ Testing --- [sun-wukong incubator-aurora (batchsize)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.37 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.47 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.43 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 1 items src/test/python/apache/aurora/client/api/test_job_monitor.py . === 1 passed in 0.40 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.35 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 3.57 seconds = = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 20 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py == 20 passed in 0.25 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 collected 27 items src/test/python/apache/aurora/client/api/test_updater.py ...
Re: Review Request 19565: Role and Role/env pages for Scheduler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 25, 2014, 2:55 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- refactored quota info into a controller, folded error handling into a directive. addressed bill's code review comments. Bugs: AURORA-39 https://issues.apache.org/jira/browse/AURORA-39 Repository: aurora Description --- Implemented the scheduler role and role/env pages using AngularJS. Added angular route and underscore.js modules. Diffs (updated) - 3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 Diff: https://reviews.apache.org/r/19565/diff/ Testing --- ./gradlew clean build run on local laptop. Thanks, Suman Karumuri
