Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-08 Thread Dan Norris 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20146/
---

Review request for Aurora and Maxim Khutornenko.


Bugs: AURORA-265
https://issues.apache.org/jira/browse/AURORA-265


Repository: aurora


Description
---

AURORA-265: Add missing tooltips for task states in dictionary.js


Diffs
-

  src/main/resources/org/apache/aurora/scheduler/http/assets/dictionary.js 
92045c41706ee9315f3522c3b5bbff7f6e7d2c64 

Diff: https://reviews.apache.org/r/20146/diff/


Testing
---

Visually inspected the scheduler w/ a sample job to verify that nothing was 
messed up. I'm not sure how to force a task with the Vagrant file into DRAINING 
or THROTTLED states.


Thanks,

Dan Norris

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

2014-04-08 Thread Dan Norris 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20027/
---

(Updated April 9, 2014, 2:31 a.m.)


Review request for Aurora, Jake Farrell and Bill Farner.


Changes
---

Updated title


Summary (updated)
-

AURORA-234: Replace HTML tables in docs with markdown


Bugs: AURORA-234
https://issues.apache.org/jira/browse/AURORA-234


Repository: aurora


Description
---

AURORA-234: Consider using markdown-style tables instead of HTML


Diffs
-

  docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
  docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
  docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 

Diff: https://reviews.apache.org/r/20027/diff/


Testing
---

Generated the Aurora site using Middleman. Everything renders correctly, though 
I've updated the Jira ticket with a comparison between the two rendered tables.

Commit on Github: 
https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97


Thanks,

Dan Norris

Re: Review Request 20027: AURORA-234: Consider using markdown-style tables instead of HTML

2014-04-08 Thread Dan Norris 


> On April 5, 2014, 11:49 p.m., Bill Farner wrote:
> > Generally for markdown reviews, we like having the diff pushed to a branch 
> > on a repo fork on github.  This makes life easy for the reviewer to see 
> > exactly how the finished product will look.
> > 
> > Review meta-comment: please adjust the summary to reflect what's being 
> > done.  in the commit history, i'd rather see something like "Convert docs 
> > tables from HTML to pure markdown" as opposed to "Consider using...".

Re: meta-comment: Does that mean that I should update the ticket title in Jira 
as well? 99% of the time that's where I get the summary header from.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20027/#review39640
---


On April 9, 2014, 2:28 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20027/
> ---
> 
> (Updated April 9, 2014, 2:28 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-234
> https://issues.apache.org/jira/browse/AURORA-234
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-234: Consider using markdown-style tables instead of HTML
> 
> 
> Diffs
> -
> 
>   docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
>   docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
>   docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 
> 
> Diff: https://reviews.apache.org/r/20027/diff/
> 
> 
> Testing
> ---
> 
> Generated the Aurora site using Middleman. Everything renders correctly, 
> though I've updated the Jira ticket with a comparison between the two 
> rendered tables.
> 
> Commit on Github: 
> https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 20027: AURORA-234: Consider using markdown-style tables instead of HTML

2014-04-08 Thread Dan Norris 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20027/
---

(Updated April 9, 2014, 2:28 a.m.)


Review request for Aurora, Jake Farrell and Bill Farner.


Changes
---

Add link to commit on Github


Bugs: AURORA-234
https://issues.apache.org/jira/browse/AURORA-234


Repository: aurora


Description
---

AURORA-234: Consider using markdown-style tables instead of HTML


Diffs
-

  docs/configurationreference.md 9d5c340025d2d14be37ef7d1a67f186c8c1792db 
  docs/deploying-aurora-scheduler.md 887bf1691068037be5f9adf4ddb9e999ec1a899b 
  docs/hooks.md 77fb95598b9f86c36979089cd4aa798044329367 

Diff: https://reviews.apache.org/r/20027/diff/


Testing (updated)
---

Generated the Aurora site using Middleman. Everything renders correctly, though 
I've updated the Jira ticket with a comparison between the two rendered tables.

Commit on Github: 
https://github.com/protochron/incubator-aurora/commit/558a5a6a2f15a82e51ef7bf6d17288f67ff11a97


Thanks,

Dan Norris

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-08 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review39847
---

Ship it!



src/main/python/apache/aurora/client/BUILD


This target name actually influences what a pip-installed 
apache.aurora.clientv2 will be called, consider changing it to "aurora2"



src/main/python/apache/aurora/client/BUILD


This target name actually influences what a pip-installed 
apache.aurora.clientv2 will install into bin/, consider changing it to "aurora2"



src/main/python/apache/aurora/client/cli/BUILD


Maybe just name it aurora2?



src/main/python/apache/aurora/client/cli/BUILD


Maybe just name it aurora2?


- Kevin Sweeney


On April 2, 2014, 6:40 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19788/
> ---
> 
> (Updated April 2, 2014, 6:40 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: aurora-266
> https://issues.apache.org/jira/browse/aurora-266
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a clientv2 version of the e2e test.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/BUILD 
> 118c4a080b2aac88f1fb6365787b3bb55a665bea 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d93a2df0f146e2771de2ce6223438a671d0e92a2 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> b3292f4ec25936ff6f576518ac9814c14a9610b4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19788/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (v2_e2e)]$ sh 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> + . src/test/sh/org/apache/aurora/e2e/test_common.sh
> ++ exec
> ++ _aurora_built=false
> + RETCODE=1
> + export CLIENT_NAME=aurorav2.pex
> + CLIENT_NAME=aurorav2.pex
> + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
> + TEST_DIR=deploy_test
> + TEST_CLUSTER=example
> + TEST_ROLE=vagrant
> + TEST_ENV=test
> + TEST_JOB=flask_example
> + TEST_SCHEDULER_IP=192.168.33.6
> + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
> $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
> $EXAMPLE_DIR/flask_example_updated.aurora)
> + trap collect_result EXIT
> + vagrant up
> Bringing machine 'devtools' up with 'virtualbox' provider...
> Bringing machine 'zookeeper' up with 'virtualbox' provider...
> Bringing machine 'mesos-master' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
> Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
> Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
> [devtools] VirtualBox VM is already running.
> [zookeeper] VirtualBox VM is already running.
> [mesos-master] VirtualBox VM is already running.
> [mesos-slave1] VirtualBox VM is already running.
> [mesos-slave2] VirtualBox VM is already running.
> [aurora-scheduler] VirtualBox VM is already running.
> + rm -rf deploy_test
> + devtools_setup deploy_test
> + local _testdir=deploy_test
> ++ git branch
> ++ grep '*'
> ++ cut -c 3-
> + branch=v2_e2e
> + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
> + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
> ~/test_dev; fi'
> + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
> + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
> HEAD is now at 29ae4e5 end-to-end for clientv2
> Removing .BUILD.CPython-2.7.3.pyc
> Removing .pants.d/
> Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
> Removing build-support/pants-0.0.14-dev2.pex
> Removing build-support/pex.venv/
> Removing build-support/virtualenv-1.10.1.tar.gz
> Removing build-support/virtualenv-1.10.1/
> Removing dist/
> Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
> Removing 
> src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
> Removing src/main/python/apac