Re: Review Request 20986: Adding min_instance_count threshold to improve safe domain results.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20986/#review42415 --- Ship it! Ship It! - Brian Wickman On May 7, 2014, 1:06 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20986/ --- (Updated May 7, 2014, 1:06 a.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-305 https://issues.apache.org/jira/browse/AURORA-305 Repository: aurora Description --- Low instance count jobs prevent hosts from showing up in the safe domain list. Adding an option to control jobs included into results. Diffs - src/main/python/apache/aurora/client/api/__init__.py d8a23274bc9d0ba2d0ebc232652ff8c4c5da6eb1 src/main/python/apache/aurora/client/api/sla.py bb705caab4ef7749971613e23c8f6b0d3968ba23 src/main/python/apache/aurora/client/commands/admin.py 912851af1da0f6f706e55e28f6e949e1750b9897 src/test/python/apache/aurora/client/api/test_sla.py 359599af400d621e5652c2e56d01802a804abcc9 src/test/python/apache/aurora/client/commands/test_admin_sla.py aaf6c7f05caf8c809429a122e3d02e8ebb2fa54e Diff: https://reviews.apache.org/r/20986/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/#review42588 --- Ship it! src/test/python/apache/aurora/client/cli/test_restart.py https://reviews.apache.org/r/21205/#comment76401 checkstyle: extra newline - David McLaughlin On May 8, 2014, 2:26 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21205/ --- (Updated May 8, 2014, 2:26 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-399 https://issues.apache.org/jira/browse/aurora-399 Repository: aurora Description --- Bugfix: restart doesn't notify user about invalid max_total_failures option. Diffs - src/main/python/apache/aurora/client/cli/jobs.py cf45640a66c76ae4daa0ceaa3ff8da80c4cbe91d src/main/python/apache/aurora/client/commands/core.py 0046c7686261ec11c2064348e21a35758b449d27 src/test/python/apache/aurora/client/cli/test_restart.py 9b7a2c69b53d4be35587f630f429943a4907b74b src/test/python/apache/aurora/client/commands/test_restart.py 9af6334264f40cbccbef545bd15ffa85171ad348 Diff: https://reviews.apache.org/r/21205/diff/ Testing --- [sun-wukong incubator-aurora (restart_max)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. === 2 passed in 0.36 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/test_config.py .. === 6 passed in 0.45 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. === 6 passed in 0.41 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/api/test_job_monitor.py === 4 passed in 0.39 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. === 6 passed in 0.34 seconds == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... = 47 passed, 1 skipped in 4.05 seconds == == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py === 12 passed in 0.22 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 28 items src/test/python/apache/aurora/client/api/test_updater.py === 28 passed in 0.67 seconds === == test session starts == platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items
Review Request 21242: Added tooltip to a disabled task sandbox link.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21242/ --- Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-402 https://issues.apache.org/jira/browse/AURORA-402 Repository: aurora Description --- Added a tooltip to a disabled task sandbox link. Please see the discussion in the ticket. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html ae10d91359523a7aeff935d93d60f5561ec1290d Diff: https://reviews.apache.org/r/21242/diff/ Testing --- tested on laptop. File Attachments Inactive_sandbox_link_with_tooltip.png https://reviews.apache.org/media/uploaded/files/2014/05/08/26572a8a-b881-4d2d-9ba1-911a09953b13__Inactive_sandbox_link_with_tooltip.png Thanks, Suman Karumuri
Re: Review Request 21136: Add python import order wrapper/commit hook
On May 6, 2014, 11:29 p.m., Kevin Sweeney wrote: src/.isort.cfg, line 1 https://reviews.apache.org/r/21136/diff/1/?file=575772#file575772line1 can this live in config/ instead? that's where java checkstyle stuff lives I don't think there's any way in isort to get this to work, reading both: https://github.com/timothycrosley/isort/blob/develop/isort/main.py https://github.com/timothycrosley/isort/blob/develop/isort/settings.py We could instead just pass everything on the command line except that 'forced_separate' is not available on the command line. Pull request maybe? Alternate locations we could consider: repository root src/main/python + src/test/python (symlinked?) - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21136/#review42370 --- On May 6, 2014, 11:10 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21136/ --- (Updated May 6, 2014, 11:10 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-149 https://issues.apache.org/jira/browse/AURORA-149 Repository: aurora Description --- Adds build-support/isort wrapper for isort. Adds build-support/isort-run to run import sort, build-support/isort-check to run import order check. Adds build-support/hooks which contains hooks that people can place into their .git/hooks directory, currently just a pre-commit hook that checks import sort order (which can be overridden with an environment variable.) The ordering it produces is different than the one we currently have but closer to straight PEP8. If it runs, it's about a 500 line diff which I can send later. Diffs - build-support/hooks/pre-commit PRE-CREATION build-support/isort PRE-CREATION build-support/isort-check PRE-CREATION build-support/isort-run PRE-CREATION src/.isort.cfg PRE-CREATION Diff: https://reviews.apache.org/r/21136/diff/ Testing --- Ran the isort and ran tests, everything worked. Thanks, Brian Wickman
Re: Review Request 21188: Fix broken test build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21188/#review42452 --- Ship it! Ship It! - Maxim Khutornenko On May 8, 2014, 1:19 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21188/ --- (Updated May 8, 2014, 1:19 a.m.) Review request for Aurora and Maxim Khutornenko. Bugs: aurora-397 https://issues.apache.org/jira/browse/aurora-397 Repository: aurora Description --- Fix broken test build. Diffs - src/test/python/apache/aurora/client/cli/BUILD c0492cc41c5e253fb3a38e347081fe9ef68f3426 Diff: https://reviews.apache.org/r/21188/diff/ Testing --- [sun-wukong incubator-aurora (master)]$ ./pants src/test/python/apache/aurora/client:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)]) === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 2 items src/test/python/apache/aurora/client/test_binding_helper.py .. = 2 passed in 0.36 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/test_config.py .. = 6 passed in 0.46 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_disambiguator.py .. = 6 passed in 0.40 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items src/test/python/apache/aurora/client/api/test_job_monitor.py = 4 passed in 0.40 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_restarter.py .. = 6 passed in 0.34 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 47 items / 1 skipped src/test/python/apache/aurora/client/api/test_scheduler_client.py ... === 47 passed, 1 skipped in 3.66 seconds === === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 12 items src/test/python/apache/aurora/client/api/test_instance_watcher.py src/test/python/apache/aurora/client/api/test_health_check.py 12 passed in 0.22 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 28 items src/test/python/apache/aurora/client/api/test_updater.py 28 passed in 0.66 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 6 items src/test/python/apache/aurora/client/api/test_quota_check.py .. = 6 passed in 0.15 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 31 items src/test/python/apache/aurora/client/api/test_sla.py ... 31 passed in 0.26 seconds = === test session starts platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 plugins: cov collected 4 items
Re: Review Request 19788: Add a clientv2 version of the e2e test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/#review42425 --- Ship it! Ship It! - David McLaughlin On May 7, 2014, 7:47 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/ --- (Updated May 7, 2014, 7:47 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: aurora-266 https://issues.apache.org/jira/browse/aurora-266 Repository: aurora Description --- Add a clientv2 version of the e2e test. Diffs - src/main/python/apache/aurora/client/BUILD 118c4a080b2aac88f1fb6365787b3bb55a665bea src/main/python/apache/aurora/client/cli/BUILD 02e061c7d485cc7f24c48c0db1b5778819961f47 src/test/python/apache/aurora/client/cli/BUILD d93a2df0f146e2771de2ce6223438a671d0e92a2 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh b3292f4ec25936ff6f576518ac9814c14a9610b4 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION Diff: https://reviews.apache.org/r/19788/diff/ Testing --- [sun-wukong incubator-aurora (v2_e2e)]$ sh src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh + . src/test/sh/org/apache/aurora/e2e/test_common.sh ++ exec ++ _aurora_built=false + RETCODE=1 + export CLIENT_NAME=aurorav2.pex + CLIENT_NAME=aurorav2.pex + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask + TEST_DIR=deploy_test + TEST_CLUSTER=example + TEST_ROLE=vagrant + TEST_ENV=test + TEST_JOB=flask_example + TEST_SCHEDULER_IP=192.168.33.6 + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora $EXAMPLE_DIR/flask_example_updated.aurora) + trap collect_result EXIT + vagrant up Bringing machine 'devtools' up with 'virtualbox' provider... Bringing machine 'zookeeper' up with 'virtualbox' provider... Bringing machine 'mesos-master' up with 'virtualbox' provider... Bringing machine 'mesos-slave1' up with 'virtualbox' provider... Bringing machine 'mesos-slave2' up with 'virtualbox' provider... Bringing machine 'aurora-scheduler' up with 'virtualbox' provider... [devtools] VirtualBox VM is already running. [zookeeper] VirtualBox VM is already running. [mesos-master] VirtualBox VM is already running. [mesos-slave1] VirtualBox VM is already running. [mesos-slave2] VirtualBox VM is already running. [aurora-scheduler] VirtualBox VM is already running. + rm -rf deploy_test + devtools_setup deploy_test + local _testdir=deploy_test ++ git branch ++ grep '*' ++ cut -c 3- + branch=v2_e2e + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi' + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi' + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx' + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx' HEAD is now at 29ae4e5 end-to-end for clientv2 Removing .BUILD.CPython-2.7.3.pyc Removing .pants.d/ Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc Removing build-support/pants-0.0.14-dev2.pex Removing build-support/pex.venv/ Removing build-support/virtualenv-1.10.1.tar.gz Removing build-support/virtualenv-1.10.1/ Removing dist/ Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/thermos/common/.BUILD.CPython-2.7.3.pyc Removing src/main/python/apache/thermos/config/.BUILD.CPython-2.7.3.pyc Removing src/main/thrift/org/apache/aurora/gen/.BUILD.CPython-2.7.3.pyc Removing src/main/thrift/org/apache/thermos/.BUILD.CPython-2.7.3.pyc Removing src/test/sh/org/apache/aurora/e2e/flask/.BUILD.CPython-2.7.3.pyc + run_dev 'cd ~/test_dev ; git checkout v2_e2e; git pull' + vagrant ssh devtools -c 'cd ~/test_dev ; git checkout v2_e2e; git pull' Already on 'v2_e2e' From /vagrant 29ae4e5..d9cf866 v2_e2e - origin/v2_e2e Updating 29ae4e5..d9cf866 Fast-forward
