Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
On July 2, 2014, 11:11 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 414 https://reviews.apache.org/r/23188/diff/2/?file=623177#file623177line414 What's the motivation for including the job key? I would assume that the caller either already knows this, and if not, they can turn back around and query for the task IDs. Maxim Khutornenko wrote: TaskQuery allows pulling tasks from multiple jobs. Without specifying some kind of reference towards the parent job, pending reasons would be useless when pulled by anything other than the JobKey. Either we have to further restrict TaskQuery to require role/env/name fields or provide a reference back in the result. Feels like making this RPC effectively job-scoped is an unnecessary restriction at this point. Without specifying some kind of reference towards the parent job, pending reasons would be useless when pulled by anything other than the JobKey I disagree that they would be useless. Like i mentioned above, the caller will either have context, or they can turn around and query for the tasks to gain context. Including the job key seems arbitrary (i.e. why that and not the instance id?). - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review47247 --- On July 2, 2014, 11:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/ --- (Updated July 2, 2014, 11:07 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-377 https://issues.apache.org/jira/browse/AURORA-377 Repository: aurora Description --- Adding getPendingReason RPC to expose scheduling vetos in the UI/client. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2549dd33d08dfc6058d985127a3f0c1f3984eaa7 src/main/thrift/org/apache/aurora/gen/api.thrift 8ee43fa1f0e2e699b0f1a321e673e49221b528ad src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java ed24ca058c013dfdec8366522893bd4f83e30a9c Diff: https://reviews.apache.org/r/23188/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko
Re: Review Request 22983: AURORA-278 - Remove binaries from source RC
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/#review47403 --- Ship it! Ship It! - Kevin Sweeney On June 25, 2014, 1:18 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/ --- (Updated June 25, 2014, 1:18 p.m.) Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: AURORA-278 https://issues.apache.org/jira/browse/AURORA-278 Repository: aurora Description --- AURORA-278 - Remove binaries from source RC Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea .gitattributes PRE-CREATION CHANGELOG e52a6ed3055c2deaca252de26f3c571cf0d629a7 build-support/release/changelog 5cc908fe1d5a0f39d626719634559e32508fc6cb build-support/release/release 30fea493e33abad9acd98e35d60cf5287b9a0947 build-support/release/release-candidate 41d929f090ea376afb92f5edda697894d13f56db Diff: https://reviews.apache.org/r/22983/diff/ Testing --- ./builds-support/release/release-candidate -r 1 -l m verified gig sig, md5, sha, untared release and looked for binary artifacts. Additional review opened to address missing headers Thanks, Jake Farrell
Review Request 23315: s/Unsecure/Insecure/
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23315/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Unsecure is not a word. Diffs - src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d Diff: https://reviews.apache.org/r/23315/diff/ Testing --- ./gradlew test Thanks, Brian Wickman
Re: Review Request 23315: s/Unsecure/Insecure/
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23315/#review47406 --- Ship it! Ship It! - Kevin Sweeney On July 7, 2014, 11:28 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23315/ --- (Updated July 7, 2014, 11:28 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Unsecure is not a word. Diffs - src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d Diff: https://reviews.apache.org/r/23315/diff/ Testing --- ./gradlew test Thanks, Brian Wickman
Review Request 23317: AURORA-565:update top level README with instructions on bootstrapping and running initial test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23317/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-565 https://issues.apache.org/jira/browse/AURORA-565 Repository: aurora Description --- AURORA-565: update top level README with instructions on bootstrapping and running initial test Updates README with basic instructions to get started with Apache Aurora. Preview: https://github.com/jfarrell/incubator-aurora/tree/AURORA-565 Diffs - README.md 82096f60c5eed8d34a1c180e975052405329d39a Diff: https://reviews.apache.org/r/23317/diff/ Testing --- Thanks, Jake Farrell
Re: Review Request 23317: AURORA-565:update top level README with instructions on bootstrapping and running initial test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23317/#review47426 --- Ship it! Ship It! - Kevin Sweeney On July 7, 2014, 12:40 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23317/ --- (Updated July 7, 2014, 12:40 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-565 https://issues.apache.org/jira/browse/AURORA-565 Repository: aurora Description --- AURORA-565: update top level README with instructions on bootstrapping and running initial test Updates README with basic instructions to get started with Apache Aurora. Preview: https://github.com/jfarrell/incubator-aurora/tree/AURORA-565 Diffs - README.md 82096f60c5eed8d34a1c180e975052405329d39a Diff: https://reviews.apache.org/r/23317/diff/ Testing --- Thanks, Jake Farrell
Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs - src/main/python/apache/thermos/observer/http/assets/jquery.js 3774ff986139c8a7534e14bc8987fe80418dcc1b src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
Re: Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review47428 --- src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl https://reviews.apache.org/r/23329/#comment83209 -1, this is pretty much unacceptable from a security standpoint - data visible to the observer origin includes sensitive application logs -1 from a reliability standpoint as well - the observer is used to debug low-level infrastructure and a dependency on an external CDN doesn't work for that. - Kevin Sweeney On July 7, 2014, 6:08 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- (Updated July 7, 2014, 6:08 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs - src/main/python/apache/thermos/observer/http/assets/jquery.js 3774ff986139c8a7534e14bc8987fe80418dcc1b src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
Re: Review Request 23330: replace 143 kB favicon with 318 byte version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review47430 --- Ship it! Ship It! - Kevin Sweeney On July 7, 2014, 6:18 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 7, 2014, 6:18 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-577 https://issues.apache.org/jira/browse/AURORA-577 Repository: aurora Description --- replace 143 kB favicon with 318 byte version. $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201 $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico Diffs - src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson
