Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- In this change, i've added two outputs from thrift_wrapper_codegen.py: - A service metadata file (java) that maps RPC method names to parameter and type information - A series of html documents that describes methods and types used in the API (drawing from javadoc-style comments in api.thrift) ApiBeta.java consumes the metadata file, and uses it to instruct gson how to deserialize incoming requests. It in turn uses reflection to invoke the appropriate method on the thrift interface implementation. Diffs - build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 27599f75603542069084631baf9195b8ad75e902 src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java PRE-CREATION src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 9d500baf82914733c0f92752d9570da009870aa9 src/main/thrift/org/apache/aurora/gen/api.thrift 8ee43fa1f0e2e699b0f1a321e673e49221b528ad Diff: https://reviews.apache.org/r/23741/diff/ Testing --- Manual only, will post some snippets shortly. Thanks, Bill Farner
Re: Review Request 23718: AURORA-594: RC1 files missing Apache license headers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23718/#review48248 --- Ship it! src/main/python/apache/aurora/BUILD https://reviews.apache.org/r/23718/#comment84596 I believe this file can be deleted, i don't know of any reason for empty BUILD files to exist. - Bill Farner On July 20, 2014, 8:07 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23718/ --- (Updated July 20, 2014, 8:07 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-594 https://issues.apache.org/jira/browse/AURORA-594 Repository: aurora Description --- AURORA-594: RC1 files missing Apache license headers Adds missing license headers to empty and newly added files. Diffs - src/main/python/apache/aurora/BUILD e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 src/test/python/apache/aurora/client/cli/AuroraHooks c25bcfba2a3f58523769b966576f95809d7ebb26 src/test/python/apache/aurora/client/cli/hook_test_data/bad_syntax/AuroraHooks 6333986e9afe5b0068bfdcc9a2b3f4cb5dd03578 src/test/python/apache/aurora/client/cli/hook_test_data/exec_error/AuroraHooks 768c124aeb8bb47986312ec70641ad9d09f0913b Diff: https://reviews.apache.org/r/23718/diff/ Testing --- ran: build-support/jenkins/build.sh All test passed except test_cluster_option as outlined in AURORA-595 Thanks, Jake Farrell
Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48068 --- Ship it! Ship It! src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/23455/#comment84347 Can safely omit this - Kevin Sweeney On July 14, 2014, 10:50 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/ --- (Updated July 14, 2014, 10:50 a.m.) Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: aurora-581 https://issues.apache.org/jira/browse/aurora-581 Repository: aurora Description --- Add a lightweight version of command hooks for clientv1 commands. Diffs - src/main/python/apache/aurora/client/commands/core.py 0939f0570572375ba9b4d054ddb9849995c9048d src/test/python/apache/aurora/client/commands/test_kill.py 94bbe1bfff1c8d333837aa6bb14700714f46288b Diff: https://reviews.apache.org/r/23455/diff/ Testing --- Added new unit tests, and ran full unit test suite. Thanks, Mark Chu-Carroll
Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-593 https://issues.apache.org/jira/browse/AURORA-593 Repository: aurora Description --- Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin. Diffs - build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 Diff: https://reviews.apache.org/r/23753/diff/ Testing --- Ran jenkins locally, verified that jacoco output files are consumed and coverage graph works. Thanks, Bill Farner
Re: Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/#review48294 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 1:58 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/ --- (Updated July 21, 2014, 1:58 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-593 https://issues.apache.org/jira/browse/AURORA-593 Repository: aurora Description --- Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin. Diffs - build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 Diff: https://reviews.apache.org/r/23753/diff/ Testing --- Ran jenkins locally, verified that jacoco output files are consumed and coverage graph works. Thanks, Bill Farner
Re: Review Request 23244: Fixing return value in _check_sla.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 21, 2014, 9:39 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Changes --- + Mark. Bugs: AURORA-571 https://issues.apache.org/jira/browse/AURORA-571 Repository: aurora Description --- Fixing return value in _check_sla. Also, adding logging in drainHosts RPC to help troubleshooting occasional LOST tasks when draining. Diffs - src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java bf48db97cf882105c0b2e6b70f9a4612ce60dbe8 src/main/python/apache/aurora/admin/host_maintenance.py b5b1375b1bbaed833acf2d17ec432b3d99145fab src/test/python/apache/aurora/client/commands/test_maintenance.py c4677fc2cf4cfa792823cd0660c13371ec28301f Diff: https://reviews.apache.org/r/23244/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
On July 2, 2014, 11:11 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 414 https://reviews.apache.org/r/23188/diff/2/?file=623177#file623177line414 What's the motivation for including the job key? I would assume that the caller either already knows this, and if not, they can turn back around and query for the task IDs. Maxim Khutornenko wrote: TaskQuery allows pulling tasks from multiple jobs. Without specifying some kind of reference towards the parent job, pending reasons would be useless when pulled by anything other than the JobKey. Either we have to further restrict TaskQuery to require role/env/name fields or provide a reference back in the result. Feels like making this RPC effectively job-scoped is an unnecessary restriction at this point. Bill Farner wrote: Without specifying some kind of reference towards the parent job, pending reasons would be useless when pulled by anything other than the JobKey I disagree that they would be useless. Like i mentioned above, the caller will either have context, or they can turn around and query for the tasks to gain context. Including the job key seems arbitrary (i.e. why that and not the instance id?). Dropped. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review47247 --- On July 2, 2014, 11:07 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/ --- (Updated July 2, 2014, 11:07 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-377 https://issues.apache.org/jira/browse/AURORA-377 Repository: aurora Description --- Adding getPendingReason RPC to expose scheduling vetos in the UI/client. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2549dd33d08dfc6058d985127a3f0c1f3984eaa7 src/main/thrift/org/apache/aurora/gen/api.thrift 8ee43fa1f0e2e699b0f1a321e673e49221b528ad src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java ed24ca058c013dfdec8366522893bd4f83e30a9c Diff: https://reviews.apache.org/r/23188/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko
Re: Review Request 23254: Refactoring SchedulerCore (killTasks)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48298 --- Ping. - Maxim Khutornenko On July 3, 2014, 1:48 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/ --- (Updated July 3, 2014, 1:48 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-94 https://issues.apache.org/jira/browse/AURORA-94 Repository: aurora Description --- Splitting the earlier RB for easier reviewing. Addressing killTasks refactoring. Also moving some useful tests out of BaseSchedulerCoreImplTest. Diffs - src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 27599f75603542069084631baf9195b8ad75e902 src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 628464de0032db4eb5884e3b74346b2390408993 src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java b6d06f39ac39570eac4495d97d3adaabe8357bf7 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2549dd33d08dfc6058d985127a3f0c1f3984eaa7 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 2298971ffac45a284f9130e2122aeea8b39dc852 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 94eb0a22037187625636b24707d4ac6741b55f22 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c Diff: https://reviews.apache.org/r/23254/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review48300 --- Ship it! Still think it's worth keeping but don't want to block it. - Maxim Khutornenko On July 17, 2014, 10:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- (Updated July 17, 2014, 10:53 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-340 https://issues.apache.org/jira/browse/AURORA-340 Repository: aurora Description --- Remove IsolatedSchedulerModule and surrounding code. Diffs - build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 92cf4423ee34f11bbfaca6261e3e85802ad46de9 src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 2c06e2463f1d9f51968ff7bba956515f807d8d9c src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java c6672fbfbf6e07b7fd3029a73334b52c4074c3a7 src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java 781414c5660558fa1628758e50dc82178717a723 src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java ef8c08cf2d33fb119a271151dc34245c1c30d11f Diff: https://reviews.apache.org/r/20648/diff/ Testing --- ./gradlew build sh examples/vagrant/test_tutorial.sh Thanks, Bill Farner
Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review48303 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 2:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/ --- (Updated July 21, 2014, 2:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-377 https://issues.apache.org/jira/browse/AURORA-377 Repository: aurora Description --- Adding getPendingReason RPC to expose scheduling vetos in the UI/client. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2549dd33d08dfc6058d985127a3f0c1f3984eaa7 src/main/thrift/org/apache/aurora/gen/api.thrift 8ee43fa1f0e2e699b0f1a321e673e49221b528ad src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java ed24ca058c013dfdec8366522893bd4f83e30a9c Diff: https://reviews.apache.org/r/23188/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko
Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review48304 --- Ship it! Ship It! - Kevin Sweeney On July 17, 2014, 3:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- (Updated July 17, 2014, 3:53 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-340 https://issues.apache.org/jira/browse/AURORA-340 Repository: aurora Description --- Remove IsolatedSchedulerModule and surrounding code. Diffs - build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java 92cf4423ee34f11bbfaca6261e3e85802ad46de9 src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 2c06e2463f1d9f51968ff7bba956515f807d8d9c src/main/java/org/apache/aurora/scheduler/log/testing/FileLog.java c6672fbfbf6e07b7fd3029a73334b52c4074c3a7 src/main/java/org/apache/aurora/scheduler/log/testing/FileLogStreamModule.java 781414c5660558fa1628758e50dc82178717a723 src/test/java/org/apache/aurora/scheduler/log/testing/FileLogTest.java ef8c08cf2d33fb119a271151dc34245c1c30d11f Diff: https://reviews.apache.org/r/20648/diff/ Testing --- ./gradlew build sh examples/vagrant/test_tutorial.sh Thanks, Bill Farner
Re: Review Request 23776: Add --stacktrace to gradle build command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23776/ --- (Updated July 21, 2014, 10:27 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description (updated) --- I'm hoping this gives more insight into some recent build flakiness, specifically this error: net.rubygrapefruit.platform.internal.jni.PosixFileFunctions.symlink(Ljava/lang/String;Ljava/lang/String;Lnet/rubygrapefruit/platform/internal/FunctionResult;)V This appears to be related to GRADLE-3076 [1], but --stacktrace may give us more information. [1] http://issues.gradle.org/browse/GRADLE-3076 Diffs - build-support/jenkins/build.sh 466aae208659cb08d633c12b674a0c9ec2819bba Diff: https://reviews.apache.org/r/23776/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 23254: Refactoring SchedulerCore (killTasks)
On July 21, 2014, 10:16 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 721 https://reviews.apache.org/r/23254/diff/1/?file=623290#file623290line721 We should avoid taking advantage of passing nulls where possible, and in fact i suggest changing addMessage to MorePreconditions.checkNotBlank on that. However, you'll need to take care in cases like addMessage(x, x, exception.getMessage()). For those, it makes sense to add an overload that accepts an Exception instead of String. Makes sense. Done. On July 21, 2014, 10:16 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java, line 1 https://reviews.apache.org/r/23254/diff/1/?file=623294#file623294line1 Is this file relevant to the change? This is related to the Also moving some useful tests out of BaseSchedulerCoreImplTest. part of the changelist. Trying to balance the diff size. On July 21, 2014, 10:16 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 431 https://reviews.apache.org/r/23254/diff/1/?file=623295#file623295line431 There's a subtle detail in this test case, that active() is automatically added to the task query. Can you break that out into an independent test case? Sure, done. On July 21, 2014, 10:16 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 509 https://reviews.apache.org/r/23254/diff/1/?file=623295#file623295line509 Use a constant for string that is otherwise magic. Done. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48302 --- On July 3, 2014, 1:48 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/ --- (Updated July 3, 2014, 1:48 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-94 https://issues.apache.org/jira/browse/AURORA-94 Repository: aurora Description --- Splitting the earlier RB for easier reviewing. Addressing killTasks refactoring. Also moving some useful tests out of BaseSchedulerCoreImplTest. Diffs - src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 27599f75603542069084631baf9195b8ad75e902 src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 628464de0032db4eb5884e3b74346b2390408993 src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java b6d06f39ac39570eac4495d97d3adaabe8357bf7 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2549dd33d08dfc6058d985127a3f0c1f3984eaa7 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 2298971ffac45a284f9130e2122aeea8b39dc852 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 94eb0a22037187625636b24707d4ac6741b55f22 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c Diff: https://reviews.apache.org/r/23254/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko
Re: Review Request 23254: Refactoring SchedulerCore (killTasks)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48316 --- Ship it! Ship It! - Bill Farner On July 21, 2014, 11:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/ --- (Updated July 21, 2014, 11:23 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-94 https://issues.apache.org/jira/browse/AURORA-94 Repository: aurora Description --- Splitting the earlier RB for easier reviewing. Addressing killTasks refactoring. Also moving some useful tests out of BaseSchedulerCoreImplTest. Diffs - src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 27599f75603542069084631baf9195b8ad75e902 src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 628464de0032db4eb5884e3b74346b2390408993 src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java b6d06f39ac39570eac4495d97d3adaabe8357bf7 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 95ee7b784889d66cae9b714bd88c27a136a54b3a src/main/java/org/apache/aurora/scheduler/thrift/Util.java 4ebb608d28b667bf47573524aa8878ac3b21ecfe src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 8692051fae08a59e4b70b330eb6723f72ff04d43 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 2298971ffac45a284f9130e2122aeea8b39dc852 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java d2bd65eef5a8ceea92dd62044e5e2c621c4a4f3e src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 94eb0a22037187625636b24707d4ac6741b55f22 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28761d5bbfdd2fea4714c79b47be5f5eb3a5280 Diff: https://reviews.apache.org/r/23254/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko
Review Request 23782: Revert Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23782/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- This wound up breaking coverage reports in a way such that they were generated, but did not accurately report coverage. Going to TBR commit to make progress. Diffs - build.gradle bd34f1039f93186bb95787d84cc0be190305a08e Diff: https://reviews.apache.org/r/23782/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23666/#review48322 --- Do you think this should be obviated by https://reviews.apache.org/r/23741/ ? - Bill Farner On July 21, 2014, 10:58 p.m., Misho Krastev wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23666/ --- (Updated July 21, 2014, 10:58 p.m.) Review request for Aurora. Repository: aurora Description --- REST service for aurora client commands, built using Tornado Web framework This is a draft implementation of a REST server exposing APIs to call Aurora client commands. It is a wrapper around the aurora command-line client and aurora client code. It implements some but not all of the commands available with the aurora command-line client. Comments on the code as well suggestions for improvements and enhancements are requested. This work is a eBay project that we would like to contribute to the Aurora project. Note: development is still ongoing to add unittests and to resolve the issues discovered with the stress tests. Note(2): GitHub repo -- https://github.com/misho-kr/incubator-aurora Diffs - 3rdparty/python/BUILD 641d610deb58fd102ec584e3deaa388b51a6f221 docs/client-rest-api.md PRE-CREATION src/main/python/apache/aurora/client/bin/BUILD 43d747956df0611b0880f64df9955d5f5806901c src/main/python/apache/aurora/client/bin/aurora_rest.py PRE-CREATION src/main/python/apache/aurora/client/rest/BUILD PRE-CREATION src/main/python/apache/aurora/client/rest/application.py PRE-CREATION src/main/python/apache/aurora/client/rest/application_async.py PRE-CREATION src/main/python/apache/aurora/client/rest/coroutine_executor.py PRE-CREATION src/main/python/apache/aurora/client/rest/external_executor.py PRE-CREATION src/main/python/apache/aurora/client/rest/internal_executor.py PRE-CREATION src/main/python/apache/aurora/client/rest/mp_executor.py PRE-CREATION src/main/python/apache/aurora/client/rest/mt_executor.py PRE-CREATION Diff: https://reviews.apache.org/r/23666/diff/ Testing --- Stress testing with Locust to verify the REST service can handle multiple requests simultaneously. Not all of them passed, particularly the ones with the internal executor that calls Aurora client api. Thanks, Misho Krastev
