Re: Review Request 24852: Add command output tests for job create, job killall, job kill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/ --- (Updated Aug. 22, 2014, 11:04 a.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Changes --- rebase to master. Bugs: aurora-645 https://issues.apache.org/jira/browse/aurora-645 Repository: aurora Description --- Add tests to ensure that IO behavior of client commands is correct. Improve IO behavior in the IO client, so that users get more information. Formorely, many commands succeeded silently, when it would be more helpful to actually tell the user that you did something. (This shouldn't affect scripting, because in these commands, the only result that's needed by a scripter is succeess/failure, which is carried by the exit code.) Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py 0108d9134a94facb25356fe46a5680eab2bcf2d3 src/main/python/apache/aurora/client/cli/jobs.py 109ce59e3e8dc1c6f4fb918522718cc47867020d src/test/python/apache/aurora/client/cli/test_create.py b70363a93572a0ff88541154adfed59b57ef9d30 src/test/python/apache/aurora/client/cli/test_kill.py ee64908855a4960f44ce96c810e69dd105d2ce5d src/test/python/apache/aurora/client/cli/test_restart.py 14a08e873058374a9bfe4ffbff8ae7279123f264 Diff: https://reviews.apache.org/r/24852/diff/ Testing --- Ran test suite. Thanks, Mark Chu-Carroll
Review Request 24982: Fixing checkstyle build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-311 https://issues.apache.org/jira/browse/AURORA-311 Repository: aurora Description --- Fixing checkstyle build break introduced in https://issues.apache.org/jira/browse/AURORA-311 Diffs - src/main/java/org/apache/aurora/scheduler/DriverFactory.java f300ec900d5bc00782c90f9218ca29151a3c8bdc Diff: https://reviews.apache.org/r/24982/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24982: Fixing checkstyle build break.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/#review51294 --- Ship it! Ship It! - David McLaughlin On Aug. 22, 2014, 3:49 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/ --- (Updated Aug. 22, 2014, 3:49 p.m.) Review request for Aurora and David McLaughlin. Bugs: AURORA-311 https://issues.apache.org/jira/browse/AURORA-311 Repository: aurora Description --- Fixing checkstyle build break introduced in https://issues.apache.org/jira/browse/AURORA-311 Diffs - src/main/java/org/apache/aurora/scheduler/DriverFactory.java f300ec900d5bc00782c90f9218ca29151a3c8bdc Diff: https://reviews.apache.org/r/24982/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51306 --- src/main/python/apache/aurora/admin/host_maintenance.py https://reviews.apache.org/r/24871/#comment89470 If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such) src/main/python/apache/aurora/client/commands/maintenance.py https://reviews.apache.org/r/24871/#comment89472 ack on this- it'd be nice to still have a '1-command-for-all-the-things' but that's aight - Joe Smith On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 21, 2014, 4:23 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
On Aug. 22, 2014, 6:39 p.m., Joe Smith wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 187 https://reviews.apache.org/r/24871/diff/2/?file=68#file68line187 If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such) I don't see why we should remove it. This is a nice to have feature, which adds flexibility in case someone needs to run a post-drain script. What's pressing the removal? - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51306 --- On Aug. 21, 2014, 11:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 21, 2014, 11:23 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
On Aug. 22, 2014, 11:39 a.m., Joe Smith wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 187 https://reviews.apache.org/r/24871/diff/2/?file=68#file68line187 If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such) Maxim Khutornenko wrote: I don't see why we should remove it. This is a nice to have feature, which adds flexibility in case someone needs to run a post-drain script. What's pressing the removal? Keeping the callback here isn't necessary- instead of specifying a callback, the caller of this should just operate on the hosts once this function returns and hosts are drained. (It was only useful before since it was sandwiched inbetween the drain/end_maintenance, but now the end_maintenance is gone) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51306 --- On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 21, 2014, 4:23 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Review Request 24995: Adding support for a pre-update quota check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- First step towards checking quota in startJobUpdate RPC. The final thrift wiring is to follow. Diffs - src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 24145f52a17ec9b7458aa5578a5b99ef5b1cddab src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java f679f38f0fcff8abf2442cfcd885cd202ac55528 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java fa611a913bad40a8c0515c578b394c460340e574 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 997ade0be58723d1d91725061bb128ccf45e25b4 Diff: https://reviews.apache.org/r/24995/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
On Aug. 22, 2014, 6:39 p.m., Joe Smith wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 187 https://reviews.apache.org/r/24871/diff/2/?file=68#file68line187 If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do the callback anymore. (It'll remove some complexity here, and we can just make the callers worry about formatting and such) Maxim Khutornenko wrote: I don't see why we should remove it. This is a nice to have feature, which adds flexibility in case someone needs to run a post-drain script. What's pressing the removal? Joe Smith wrote: Keeping the callback here isn't necessary- instead of specifying a callback, the caller of this should just operate on the hosts once this function returns and hosts are drained. (It was only useful before since it was sandwiched inbetween the drain/end_maintenance, but now the end_maintenance is gone) Moved the post-drain callback from HostMaintenance into maintenance to keep it as an option post drain operation. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51306 --- On Aug. 21, 2014, 11:23 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 21, 2014, 11:23 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 22, 2014, 9:26 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Changes --- Moved post-drain callback into host_drain command. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs (updated) - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51319 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 22, 2014, 5:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 22, 2014, 5:26 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 22, 2014, 11:46 p.m.) Review request for Aurora, Joe Smith and Mark Chu-Carroll. Changes --- Adding missing build target. Bugs: AURORA-43 https://issues.apache.org/jira/browse/AURORA-43 Repository: aurora Description --- Converting perform_maintenance_hosts into host_drain. Also, renaming maintenance commands to address AURORA-43. Diffs (updated) - src/main/python/apache/aurora/admin/admin_util.py 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab src/main/python/apache/aurora/admin/host_maintenance.py 162f9afea67e409d784e436c96f55ceed0537ca1 src/main/python/apache/aurora/client/commands/maintenance.py a54f0f663590033989db0d2cf3521453bf87de6a src/test/python/apache/aurora/admin/BUILD f423e63c125414e3e8a8213f43b24de592e0314a src/test/python/apache/aurora/admin/test_host_maintenance.py d8aeffb5035a55ced485318444002141dada5bfc src/test/python/apache/aurora/client/commands/test_maintenance.py a748c0183997a59f1773a2be62ec17f6c11ddd3a Diff: https://reviews.apache.org/r/24871/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
